| Message ID | 20231221185702.24685-1-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: tps65219: don't use CONFIG_DEBUG_GPIO | expand |
On Thu, Dec 21, 2023 at 8:57 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > CONFIG_DEBUG_GPIO should only be used to enable debug log messages and > for core GPIOLIB debugging. Don't use it to control the execution of > potentially buggy code. Just put it under an always-false #if. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
On Thu, Dec 21, 2023 at 7:57 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > CONFIG_DEBUG_GPIO should only be used to enable debug log messages and > for core GPIOLIB debugging. Don't use it to control the execution of > potentially buggy code. Just put it under an always-false #if. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Maybe I would have simply deleted the code, but OK. I bet some static analyzers will promptly return complaints about "no #if 0 in the kernel" :/ In this case it's an OK compromise. Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, Dec 21, 2023 at 7:57 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > CONFIG_DEBUG_GPIO should only be used to enable debug log messages and > for core GPIOLIB debugging. Don't use it to control the execution of > potentially buggy code. Just put it under an always-false #if. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > drivers/gpio/gpio-tps65219.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c > index 7b38aa360112..cd1f17041f8c 100644 > --- a/drivers/gpio/gpio-tps65219.c > +++ b/drivers/gpio/gpio-tps65219.c > @@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off > * Below can be used for test purpose only. > */ > > - if (IS_ENABLED(CONFIG_DEBUG_GPIO)) { > - int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, > - TPS65219_GPIO0_DIR_MASK, direction); > - if (ret) { > - dev_err(dev, > - "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n", > - direction, offset); > - return ret; > - } > +#if 0 > + int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, > + TPS65219_GPIO0_DIR_MASK, direction); > + if (ret) { > + dev_err(dev, > + "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n", > + direction, offset); > + return ret; > } > +#endif > > dev_err(dev, > "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n", > -- > 2.40.1 > Patch applied. Bart
diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c index 7b38aa360112..cd1f17041f8c 100644 --- a/drivers/gpio/gpio-tps65219.c +++ b/drivers/gpio/gpio-tps65219.c @@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off * Below can be used for test purpose only. */ - if (IS_ENABLED(CONFIG_DEBUG_GPIO)) { - int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, - TPS65219_GPIO0_DIR_MASK, direction); - if (ret) { - dev_err(dev, - "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n", - direction, offset); - return ret; - } +#if 0 + int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, + TPS65219_GPIO0_DIR_MASK, direction); + if (ret) { + dev_err(dev, + "GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n", + direction, offset); + return ret; } +#endif dev_err(dev, "GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",