mbox series

[v2,0/6] mfd: tmio: simplify header and move to platform_data

Message ID 20240213220221.2380-8-wsa+renesas@sang-engineering.com
Headers show
Series mfd: tmio: simplify header and move to platform_data | expand

Message

Wolfram Sang Feb. 13, 2024, 10:02 p.m. UTC 
Changes since v1:

* rebased to rc4
* collected all needed acks (Thanks!)
* capitalized first letter in commit subject

The MFD parts of the TMIO have been removed by Arnd, so that only the
SD/MMC related functionality is left. Remove the outdated remains in the
public header file and then move it to platform_data as the data is now
specific for the SD/MMC part.

Based on 6.8-rc4, build bot is happy. Branch is here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification

(just missing Adrian's ack for SH which came just now)

We agreed already that this should go in via MFD. Thanks!

All the best!

   Wolfram


Wolfram Sang (6):
  mfd: tmio: Remove obsolete platform_data
  mfd: tmio: Remove obsolete io accessors
  mmc: tmio/sdhi: Fix includes
  mfd: tmio: Update include files
  mfd: tmio: Sanitize comments
  mfd: tmio: Move header to platform_data

 MAINTAINERS                                   |   2 +-
 arch/sh/boards/board-sh7757lcr.c              |   2 +-
 arch/sh/boards/mach-ap325rxa/setup.c          |   2 +-
 arch/sh/boards/mach-ecovec24/setup.c          |   2 +-
 arch/sh/boards/mach-kfr2r09/setup.c           |   2 +-
 arch/sh/boards/mach-migor/setup.c             |   2 +-
 arch/sh/boards/mach-se/7724/setup.c           |   2 +-
 drivers/mmc/host/renesas_sdhi_core.c          |   2 +-
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |   5 +-
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      |   5 +-
 drivers/mmc/host/tmio_mmc_core.c              |   3 +-
 drivers/mmc/host/uniphier-sd.c                |   2 +-
 include/linux/mfd/tmio.h                      | 133 ------------------
 include/linux/platform_data/tmio.h            |  64 +++++++++
 14 files changed, 81 insertions(+), 147 deletions(-)
 delete mode 100644 include/linux/mfd/tmio.h
 create mode 100644 include/linux/platform_data/tmio.h

Comments

Geert Uytterhoeven Feb. 14, 2024, 4:09 p.m. UTC | #1 
On Tue, Feb 13, 2024 at 11:18 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> TMIO uses an of_* function, and SDHI uses pm_runtime functions. Add the
> includes directly, so we can clean up another header properly. Sort the
> pagemap include while we are here.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402070323.JpYfFtkQ-lkp@intel.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Lee Jones Feb. 23, 2024, 3:20 p.m. UTC | #2 
On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> Changes since v1:
> 
> * rebased to rc4
> * collected all needed acks (Thanks!)
> * capitalized first letter in commit subject
> 
> The MFD parts of the TMIO have been removed by Arnd, so that only the
> SD/MMC related functionality is left. Remove the outdated remains in the
> public header file and then move it to platform_data as the data is now
> specific for the SD/MMC part.
> 
> [...]

Applied, thanks!

[1/6] mfd: tmio: Remove obsolete platform_data
      commit: 58d6d15662e4039fab7d786f0426843befa77ad4
[2/6] mfd: tmio: Remove obsolete io accessors
      commit: e927d7bac109d8ca1729dda47a8dbc220efdb50e
[3/6] mmc: tmio/sdhi: Fix includes
      commit: bed05c68aa8f078206143700cd37e42a0084155f
[4/6] mfd: tmio: Update include files
      commit: 3ef94c41db82573dc1e1dd6c259aec8ef6caaaf3
[5/6] mfd: tmio: Sanitize comments
      commit: 2d417dda59123b9523a19ce75fea3fd1056c3b4c
[6/6] mfd: tmio: Move header to platform_data
      commit: 858b29729c9d319b9cd1441646cc3af246d3c3f9

--
Lee Jones [李琼斯]
Wolfram Sang July 7, 2024, 5:41 a.m. UTC | #3 
On Fri, Feb 23, 2024 at 03:20:00PM +0000, Lee Jones wrote:
> On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> > Changes since v1:
> > 
> > * rebased to rc4
> > * collected all needed acks (Thanks!)
> > * capitalized first letter in commit subject
> > 
> > The MFD parts of the TMIO have been removed by Arnd, so that only the
> > SD/MMC related functionality is left. Remove the outdated remains in the
> > public header file and then move it to platform_data as the data is now
> > specific for the SD/MMC part.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/6] mfd: tmio: Remove obsolete platform_data
>       commit: 58d6d15662e4039fab7d786f0426843befa77ad4
> [2/6] mfd: tmio: Remove obsolete io accessors
>       commit: e927d7bac109d8ca1729dda47a8dbc220efdb50e
> [3/6] mmc: tmio/sdhi: Fix includes
>       commit: bed05c68aa8f078206143700cd37e42a0084155f
> [4/6] mfd: tmio: Update include files
>       commit: 3ef94c41db82573dc1e1dd6c259aec8ef6caaaf3
> [5/6] mfd: tmio: Sanitize comments
>       commit: 2d417dda59123b9523a19ce75fea3fd1056c3b4c
> [6/6] mfd: tmio: Move header to platform_data
>       commit: 858b29729c9d319b9cd1441646cc3af246d3c3f9

This series is not upstream yet?
Geert Uytterhoeven July 7, 2024, 7:48 p.m. UTC | #4 
On Sun, Jul 7, 2024 at 7:41 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Fri, Feb 23, 2024 at 03:20:00PM +0000, Lee Jones wrote:
> > On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> > > Changes since v1:
> > >
> > > * rebased to rc4
> > > * collected all needed acks (Thanks!)
> > > * capitalized first letter in commit subject
> > >
> > > The MFD parts of the TMIO have been removed by Arnd, so that only the
> > > SD/MMC related functionality is left. Remove the outdated remains in the
> > > public header file and then move it to platform_data as the data is now
> > > specific for the SD/MMC part.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/6] mfd: tmio: Remove obsolete platform_data
> >       commit: 58d6d15662e4039fab7d786f0426843befa77ad4
> > [2/6] mfd: tmio: Remove obsolete io accessors
> >       commit: e927d7bac109d8ca1729dda47a8dbc220efdb50e
> > [3/6] mmc: tmio/sdhi: Fix includes
> >       commit: bed05c68aa8f078206143700cd37e42a0084155f
> > [4/6] mfd: tmio: Update include files
> >       commit: 3ef94c41db82573dc1e1dd6c259aec8ef6caaaf3
> > [5/6] mfd: tmio: Sanitize comments
> >       commit: 2d417dda59123b9523a19ce75fea3fd1056c3b4c
> > [6/6] mfd: tmio: Move header to platform_data
> >       commit: 858b29729c9d319b9cd1441646cc3af246d3c3f9
>
> This series is not upstream yet?

FTR, it entered linux-next in next-20240402, but disappeared after
next-20240510.

Gr{oetje,eeting}s,

                        Geert
Lee Jones July 9, 2024, 9:33 a.m. UTC | #5 
On Sun, 07 Jul 2024, Geert Uytterhoeven wrote:

> On Sun, Jul 7, 2024 at 7:41 AM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > On Fri, Feb 23, 2024 at 03:20:00PM +0000, Lee Jones wrote:
> > > On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> > > > Changes since v1:
> > > >
> > > > * rebased to rc4
> > > > * collected all needed acks (Thanks!)
> > > > * capitalized first letter in commit subject
> > > >
> > > > The MFD parts of the TMIO have been removed by Arnd, so that only the
> > > > SD/MMC related functionality is left. Remove the outdated remains in the
> > > > public header file and then move it to platform_data as the data is now
> > > > specific for the SD/MMC part.
> > > >
> > > > [...]
> > >
> > > Applied, thanks!
> > >
> > > [1/6] mfd: tmio: Remove obsolete platform_data
> > >       commit: 58d6d15662e4039fab7d786f0426843befa77ad4
> > > [2/6] mfd: tmio: Remove obsolete io accessors
> > >       commit: e927d7bac109d8ca1729dda47a8dbc220efdb50e
> > > [3/6] mmc: tmio/sdhi: Fix includes
> > >       commit: bed05c68aa8f078206143700cd37e42a0084155f
> > > [4/6] mfd: tmio: Update include files
> > >       commit: 3ef94c41db82573dc1e1dd6c259aec8ef6caaaf3
> > > [5/6] mfd: tmio: Sanitize comments
> > >       commit: 2d417dda59123b9523a19ce75fea3fd1056c3b4c
> > > [6/6] mfd: tmio: Move header to platform_data
> > >       commit: 858b29729c9d319b9cd1441646cc3af246d3c3f9
> >
> > This series is not upstream yet?
> 
> FTR, it entered linux-next in next-20240402, but disappeared after
> next-20240510.

That's very odd.  I cannot explain that.

I'll go apply it again.  Sorry for this.
Lee Jones July 9, 2024, 9:40 a.m. UTC | #6 
On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> Changes since v1:
> 
> * rebased to rc4
> * collected all needed acks (Thanks!)
> * capitalized first letter in commit subject
> 
> The MFD parts of the TMIO have been removed by Arnd, so that only the
> SD/MMC related functionality is left. Remove the outdated remains in the
> public header file and then move it to platform_data as the data is now
> specific for the SD/MMC part.
> 
> [...]

Applied, thanks!

[1/6] mfd: tmio: Remove obsolete platform_data
      commit: ef6dfcbcbbf7d9a414feb44aa093d2d8592a2e20
[2/6] mfd: tmio: Remove obsolete io accessors
      commit: 6bec678b9872271ce2e0879c360ad7a1a524c7fa
[3/6] mmc: tmio/sdhi: Fix includes
      commit: 4377aef83d0db25efc928a633ee80698b8520c8e
[4/6] mfd: tmio: Update include files
      commit: d411ccbe103d665a31861987e2f1b36944ab63f2
[5/6] mfd: tmio: Sanitize comments
      commit: 763135b819ad3e3e0301b66094d50923e64092a7
[6/6] mfd: tmio: Move header to platform_data
      commit: 70b46487b1558eb25ea6e533c905131b10596dc0

--
Lee Jones [李琼斯]
Lee Jones July 9, 2024, 9:41 a.m. UTC | #7 
On Tue, 09 Jul 2024, Lee Jones wrote:

> On Tue, 13 Feb 2024 23:02:19 +0100, Wolfram Sang wrote:
> > Changes since v1:
> > 
> > * rebased to rc4
> > * collected all needed acks (Thanks!)
> > * capitalized first letter in commit subject
> > 
> > The MFD parts of the TMIO have been removed by Arnd, so that only the
> > SD/MMC related functionality is left. Remove the outdated remains in the
> > public header file and then move it to platform_data as the data is now
> > specific for the SD/MMC part.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/6] mfd: tmio: Remove obsolete platform_data
>       commit: ef6dfcbcbbf7d9a414feb44aa093d2d8592a2e20
> [2/6] mfd: tmio: Remove obsolete io accessors
>       commit: 6bec678b9872271ce2e0879c360ad7a1a524c7fa
> [3/6] mmc: tmio/sdhi: Fix includes
>       commit: 4377aef83d0db25efc928a633ee80698b8520c8e
> [4/6] mfd: tmio: Update include files
>       commit: d411ccbe103d665a31861987e2f1b36944ab63f2
> [5/6] mfd: tmio: Sanitize comments
>       commit: 763135b819ad3e3e0301b66094d50923e64092a7
> [6/6] mfd: tmio: Move header to platform_data
>       commit: 70b46487b1558eb25ea6e533c905131b10596dc0

Applied and pushed - should be in tomorrow's -next.
Wolfram Sang July 9, 2024, 10:37 a.m. UTC | #8 
> Applied and pushed - should be in tomorrow's -next.

Thank you!