mbox series

[0/6] crypto: qat - fix warnings reported by clang

Message ID 20240216151959.19382-1-adam.guerin@intel.com
Headers show
Series crypto: qat - fix warnings reported by clang | expand

Message

Adam Guerin Feb. 16, 2024, 3:19 p.m. UTC
This set fixes a list of warnings found by compiling the QAT driver with
"CC=clang W=2" and with the Clang tool scan-build.

These fixes include removing unused macros in both adf_cnv_dbgfs.c and
qat_comp_alg.c, fix initialization of multiple variables, check that
delta_us is not 0, and fixing the comment structures in multiple files.

Adam Guerin (6):
  crypto: qat - remove unused macros in qat_comp_alg.c
  crypto: qat - removed unused macro in adf_cnv_dbgfs.c
  crypto: qat - avoid division by zero
  crypto: qat - remove double initialization of value
  crypto: qat - remove unnecessary description from comment
  crypto: qat - fix comment structure

 drivers/crypto/intel/qat/qat_common/adf_clock.c     | 3 +++
 drivers/crypto/intel/qat/qat_common/adf_cnv_dbgfs.c | 1 -
 drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c   | 4 ++--
 drivers/crypto/intel/qat/qat_common/adf_gen4_ras.c  | 6 ++----
 drivers/crypto/intel/qat/qat_common/adf_isr.c       | 2 --
 drivers/crypto/intel/qat/qat_common/adf_vf_isr.c    | 2 --
 drivers/crypto/intel/qat/qat_common/qat_comp_algs.c | 9 ---------
 drivers/crypto/intel/qat/qat_common/qat_crypto.c    | 4 ++--
 8 files changed, 9 insertions(+), 22 deletions(-)


base-commit: 7a35f3adf4535a9a56ef7b3e75355806632030ca

Comments

Herbert Xu Feb. 24, 2024, 12:51 a.m. UTC | #1
On Fri, Feb 16, 2024 at 03:19:54PM +0000, Adam Guerin wrote:
> This set fixes a list of warnings found by compiling the QAT driver with
> "CC=clang W=2" and with the Clang tool scan-build.
> 
> These fixes include removing unused macros in both adf_cnv_dbgfs.c and
> qat_comp_alg.c, fix initialization of multiple variables, check that
> delta_us is not 0, and fixing the comment structures in multiple files.
> 
> Adam Guerin (6):
>   crypto: qat - remove unused macros in qat_comp_alg.c
>   crypto: qat - removed unused macro in adf_cnv_dbgfs.c
>   crypto: qat - avoid division by zero
>   crypto: qat - remove double initialization of value
>   crypto: qat - remove unnecessary description from comment
>   crypto: qat - fix comment structure
> 
>  drivers/crypto/intel/qat/qat_common/adf_clock.c     | 3 +++
>  drivers/crypto/intel/qat/qat_common/adf_cnv_dbgfs.c | 1 -
>  drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c   | 4 ++--
>  drivers/crypto/intel/qat/qat_common/adf_gen4_ras.c  | 6 ++----
>  drivers/crypto/intel/qat/qat_common/adf_isr.c       | 2 --
>  drivers/crypto/intel/qat/qat_common/adf_vf_isr.c    | 2 --
>  drivers/crypto/intel/qat/qat_common/qat_comp_algs.c | 9 ---------
>  drivers/crypto/intel/qat/qat_common/qat_crypto.c    | 4 ++--
>  8 files changed, 9 insertions(+), 22 deletions(-)
> 
> 
> base-commit: 7a35f3adf4535a9a56ef7b3e75355806632030ca
> -- 
> 2.40.1

All applied.  Thanks.