mbox series

[0/3] Add devicetree support of USB for QDU/QRU1000

Message ID 20240311120859.18489-1-quic_kbajaj@quicinc.com
Headers show
Series Add devicetree support of USB for QDU/QRU1000 | expand

Message

Komal Bajaj March 11, 2024, 12:08 p.m. UTC 
This series adds devicetree nodes to support interconnects and usb for qdu/qru1000.
This is based on previously sent driver series[1].
[1]
https://lore.kernel.org/linux-arm-msm/20240311120215.16845-1-quic_kbajaj@quicinc.com/

Komal Bajaj (3):
  arm64: dts: qcom: qdu1000: Add USB3 and PHY support
  arm64: dts: qcom: qdu1000-idp: enable USB nodes
  arm64: dts: qcom: qru1000-idp: enable USB nodes

 arch/arm64/boot/dts/qcom/qdu1000-idp.dts |  24 +++++
 arch/arm64/boot/dts/qcom/qdu1000.dtsi    | 119 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/qru1000-idp.dts |  24 +++++
 3 files changed, 167 insertions(+)

--
2.42.0

Comments

Krzysztof Kozlowski March 11, 2024, 4:32 p.m. UTC | #1 
On 11/03/2024 13:08, Komal Bajaj wrote:
> @@ -6,6 +6,7 @@
>  #include <dt-bindings/clock/qcom,qdu1000-gcc.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/dma/qcom-gpi.h>
> +#include <dt-bindings/interconnect/qcom,icc.h>
>  #include <dt-bindings/interconnect/qcom,qdu1000-rpmh.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/power/qcom-rpmpd.h>
> @@ -913,6 +914,124 @@ opp-384000000 {
>  			};
>  		};
> 
> +		usb_1_hsphy: phy@88e3000 {
> +			compatible = "qcom,qdu1000-usb-hs-phy",
> +				     "qcom,usb-snps-hs-7nm-phy";
> +			reg = <0x0 0x088e3000 0x0 0x120>;
> +			#phy-cells = <0>;
> +
> +			clocks =<&gcc GCC_USB2_CLKREF_EN>;
> +			clock-names = "ref";
> +
> +			resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
> +
> +			status = "disabled";
> +		};
> +
> +		usb_1_qmpphy: phy-wrapper@88e5000 {

That's a phy, isn't it? So node name "phy".

Best regards,
Krzysztof
Komal Bajaj March 19, 2024, 8:32 a.m. UTC | #2 
On 3/11/2024 10:02 PM, Krzysztof Kozlowski wrote:
> On 11/03/2024 13:08, Komal Bajaj wrote:
>> @@ -6,6 +6,7 @@
>>   #include <dt-bindings/clock/qcom,qdu1000-gcc.h>
>>   #include <dt-bindings/clock/qcom,rpmh.h>
>>   #include <dt-bindings/dma/qcom-gpi.h>
>> +#include <dt-bindings/interconnect/qcom,icc.h>
>>   #include <dt-bindings/interconnect/qcom,qdu1000-rpmh.h>
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>>   #include <dt-bindings/power/qcom-rpmpd.h>
>> @@ -913,6 +914,124 @@ opp-384000000 {
>>   			};
>>   		};
>>
>> +		usb_1_hsphy: phy@88e3000 {
>> +			compatible = "qcom,qdu1000-usb-hs-phy",
>> +				     "qcom,usb-snps-hs-7nm-phy";
>> +			reg = <0x0 0x088e3000 0x0 0x120>;
>> +			#phy-cells = <0>;
>> +
>> +			clocks =<&gcc GCC_USB2_CLKREF_EN>;
>> +			clock-names = "ref";
>> +
>> +			resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
>> +
>> +			status = "disabled";
>> +		};
>> +
>> +		usb_1_qmpphy: phy-wrapper@88e5000 {
> 
> That's a phy, isn't it? So node name "phy".

My mistake, will correct it.

Thanks
Komal

> 
> Best regards,
> Krzysztof
>