| Message ID | 20240314232201.2102178-9-jan.dakinevich@salutedevices.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce support of audio for Amlogic A1 SoC family | expand |
On 15/03/2024 00:21, Jan Dakinevich wrote: > Add "amlogic,t9015-a1" compatible string and new device tree phandle > options. I don't understand the second part. You did not add any options, no phandles. You added some defines for something, so say what are these "something". > > Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> > --- > .../devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 + > include/dt-bindings/sound/meson-g12a-toacodec.h | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml > index 23f82bb89750..c47604aa590f 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml > @@ -26,6 +26,7 @@ properties: > - items: > - enum: > - amlogic,sm1-toacodec > + - amlogic,a1-toacodec Keep alphabetical order. Don't stuff new entries to the end... Best regards, Krzysztof
I mean the following... This commit adds new defines to meson-g12a-toacodec.h header. These defines are used in the following way: sound-dai = <&toacodec TOACODEC_IN_A>; sound-dai = <&toacodec TOACODEC_CAPTURE_OUT_A>; So, can you make an advise how to call something like "&toacodec" to which I declare new parameters. On 3/15/24 12:58, Krzysztof Kozlowski wrote: > On 15/03/2024 00:21, Jan Dakinevich wrote: >> Add "amlogic,t9015-a1" compatible string and new device tree phandle >> options. > > I don't understand the second part. You did not add any options, no > phandles. You added some defines for something, so say what are these > "something". > >> >> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> >> --- >> .../devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 + >> include/dt-bindings/sound/meson-g12a-toacodec.h | 5 +++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml >> index 23f82bb89750..c47604aa590f 100644 >> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml >> +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml >> @@ -26,6 +26,7 @@ properties: >> - items: >> - enum: >> - amlogic,sm1-toacodec >> + - amlogic,a1-toacodec > > Keep alphabetical order. Don't stuff new entries to the end... > > > > > Best regards, > Krzysztof >
On 17/03/2024 15:29, Jan Dakinevich wrote: > I mean the following... This commit adds new defines to > meson-g12a-toacodec.h header. These defines are used in the following way: > > sound-dai = <&toacodec TOACODEC_IN_A>; > sound-dai = <&toacodec TOACODEC_CAPTURE_OUT_A>; > > So, can you make an advise how to call something like "&toacodec" to > which I declare new parameters. &toacodec is phandle but it is not really relevant here. You should explain what these defines are. DAI ids? Best regards, Krzysztof
On 3/17/24 17:46, Krzysztof Kozlowski wrote: > On 17/03/2024 15:29, Jan Dakinevich wrote: >> I mean the following... This commit adds new defines to >> meson-g12a-toacodec.h header. These defines are used in the following way: >> >> sound-dai = <&toacodec TOACODEC_IN_A>; >> sound-dai = <&toacodec TOACODEC_CAPTURE_OUT_A>; >> >> So, can you make an advise how to call something like "&toacodec" to >> which I declare new parameters. > > &toacodec is phandle but it is not really relevant here. You should > explain what these defines are. DAI ids? > Yes, these are DAI ids. Ok, I'll write it in next version. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml index 23f82bb89750..c47604aa590f 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml @@ -26,6 +26,7 @@ properties: - items: - enum: - amlogic,sm1-toacodec + - amlogic,a1-toacodec - const: amlogic,g12a-toacodec reg: diff --git a/include/dt-bindings/sound/meson-g12a-toacodec.h b/include/dt-bindings/sound/meson-g12a-toacodec.h index 69d7a75592a2..f726e2c6064d 100644 --- a/include/dt-bindings/sound/meson-g12a-toacodec.h +++ b/include/dt-bindings/sound/meson-g12a-toacodec.h @@ -7,4 +7,9 @@ #define TOACODEC_IN_C 2 #define TOACODEC_OUT 3 +#define TOACODEC_CAPTURE_OUT_A 4 +#define TOACODEC_CAPTURE_OUT_B 5 +#define TOACODEC_CAPTURE_OUT_C 6 +#define TOACODEC_CAPTURE_IN 7 + #endif /* __DT_MESON_G12A_TOACODEC_H */
Add "amlogic,t9015-a1" compatible string and new device tree phandle options. Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> --- .../devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 + include/dt-bindings/sound/meson-g12a-toacodec.h | 5 +++++ 2 files changed, 6 insertions(+)