| Message ID | 20240401101339.506639-1-oswald.buddenhagen@gmx.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: soc/au1x: declare that FIFO is reported in frames | expand |
On Mon, 01 Apr 2024 12:13:39 +0200, Oswald Buddenhagen wrote: > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> > --- > > Is this right? The comment on the field says "fifo entries of AC97/I2S > PSC", which suggests frames, but that may mean whatever. > > Cc: Manuel Lauss <mano@roarinelk.homelinux.net> Use a right subject prefix (ASoC in this case) and put the corresponding maintainers to Cc. thanks, Takashi > --- > sound/soc/au1x/dbdma2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/au1x/dbdma2.c b/sound/soc/au1x/dbdma2.c > index ea01d6490cec..2c8c01a5fb8f 100644 > --- a/sound/soc/au1x/dbdma2.c > +++ b/sound/soc/au1x/dbdma2.c > @@ -66,7 +66,8 @@ struct au1xpsc_audio_dmadata { > /* PCM hardware DMA capabilities - platform specific */ > static const struct snd_pcm_hardware au1xpsc_pcm_hardware = { > .info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | > - SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH, > + SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH | > + SNDRV_PCM_INFO_FIFO_IN_FRAMES, > .period_bytes_min = AU1XPSC_PERIOD_MIN_BYTES, > .period_bytes_max = 4096 * 1024 - 1, > .periods_min = 2, > -- > 2.42.0.419.g70bf8a5751 >
diff --git a/sound/soc/au1x/dbdma2.c b/sound/soc/au1x/dbdma2.c index ea01d6490cec..2c8c01a5fb8f 100644 --- a/sound/soc/au1x/dbdma2.c +++ b/sound/soc/au1x/dbdma2.c @@ -66,7 +66,8 @@ struct au1xpsc_audio_dmadata { /* PCM hardware DMA capabilities - platform specific */ static const struct snd_pcm_hardware au1xpsc_pcm_hardware = { .info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | - SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH, + SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH | + SNDRV_PCM_INFO_FIFO_IN_FRAMES, .period_bytes_min = AU1XPSC_PERIOD_MIN_BYTES, .period_bytes_max = 4096 * 1024 - 1, .periods_min = 2,
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> --- Is this right? The comment on the field says "fifo entries of AC97/I2S PSC", which suggests frames, but that may mean whatever. Cc: Manuel Lauss <mano@roarinelk.homelinux.net> --- sound/soc/au1x/dbdma2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.42.0.419.g70bf8a5751