| Message ID | 20240409053704.428336-1-saravanak@google.com |
|---|---|
| Headers | show |
| Series | fw_devlink overlay fix | expand |
Hi Saravana, +CC Luca and Thomas On Mon, 8 Apr 2024 22:37:01 -0700 Saravana Kannan <saravanak@google.com> wrote: > Don't bother reviewing this patch. It needs to be tested and possibly > refactored first. > > Geert and Herve, > > This patch serious should hopefully fix both of your use cases > [1][2][3]. Can you please check to make sure the device links created > to/from the overlay devices are to/from the right ones? > > I've only compile tested it. If I made some obvious mistake, feel free > to fix it and give it a shot. > > Cc: Rob Herring <robh@kernel.org> > > [1] - https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ > [2] - https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ > [3] - https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ > I tested your patches. Concerning my use cases, they fix the issue described in https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ But not the one described in https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ A link is still present between the i2c@600 and the PCI device. instead of the i2c@600 and the pci-ep-bus. Adding the patch clearing the FWNODE_FLAG_NOT_DEVICE in device_add() available at [1] on top of your patches fixes the link issue. With this additional patch applied, the link is present between the i2c@600 and the pci-ep-bus. [1] https://lore.kernel.org/lkml/20240220111044.133776-2-herve.codina@bootlin.com/ Best regards, Hervé
On Tue, Apr 9, 2024 at 8:10 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Saravana, > > On Tue, Apr 9, 2024 at 7:37 AM Saravana Kannan <saravanak@google.com> wrote: > > Don't bother reviewing this patch. It needs to be tested and possibly > > refactored first. > > > > Geert and Herve, > > > > This patch serious should hopefully fix both of your use cases > > [1][2][3]. Can you please check to make sure the device links created > > to/from the overlay devices are to/from the right ones? > > Thanks for your series! > > After applying the first patch (the revert), the issue reported in > [1] is back, as expected. > After applying both patches, applying[A]/unapplying[B]/reapplying[C] > overlay [4] works as without this series, so > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Note that the state of /sys/class/devlink/ after [C] is still not the > same as after [A], as reported before in [5]: > - platform:e6060000.pinctrl--platform:keys link is not recreated in [B], > - nothing changes in /sys/class/devlink in [C]. > But that issue is not introduced in this series. Thanks for the testing and additional info! Looks like I'll need to make more changes to accommodate more cases. I'll send out v3 once I figure it out, but it should continue working for you. -Saravana > > > [1] - https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ > > [4] "arm64: dts: renesas: ebisu: cn41: Add overlay for MSIOF0 and 25LC040" > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/renesas-overlays&id=222a4936b0d3dabd43bdffb3a578423bff97b02d > [5] https://lore.kernel.org/lkml/CAMuHMdXNoYH8PJE1xb4PK-vzjXtOzrxNJoZhsHT-H4Ucm=7_ig@mail.gmail.com/ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds