| Message ID | 20240412103554.3487290-1-wtli@nuvoton.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC | expand |
On Fri, 12 Apr 2024 18:35:52 +0800, Seven Lee wrote: > Change the original fixed delay to the assignment from the property. It > will make it more flexible to different platforms to avoid pop noise at > the beginning of recording. > > Signed-off-by: Seven Lee <wtli@nuvoton.com> > --- > .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/nuvoton,nau8821.example.dtb: codec@1b: Unevaluated properties are not allowed ('nuvoton,nuvoton,adc-delay-ms' was unexpected) from schema $id: http://devicetree.org/schemas/sound/nuvoton,nau8821.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240412103554.3487290-1-wtli@nuvoton.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote: > Change the original fixed delay to the assignment from the property. It > will make it more flexible to different platforms to avoid pop noise at > the beginning of recording. > > Signed-off-by: Seven Lee <wtli@nuvoton.com> > --- > .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml > index 054b53954ac3..a726c5a9b067 100644 > --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml > @@ -103,6 +103,13 @@ properties: > just limited to the left adc for design demand. > type: boolean > > + nuvoton,adc-delay-ms: > + description: Delay (in ms) to make input path stable and avoid pop noise. > + The default value is 125 and range between 125 to 500 ms. No need to state constraints in prose. > + minimum: 125 > + maximum: 500 > + default: 125 > + > '#sound-dai-cells': > const: 0 > > @@ -136,6 +143,7 @@ examples: > nuvoton,jack-eject-debounce = <0>; > nuvoton,dmic-clk-threshold = <3072000>; > nuvoton,dmic-slew-rate = <0>; > + nuvoton,nuvoton,adc-delay-ms = <125>; > #sound-dai-cells = <0>; > }; > }; > -- > 2.25.1 >
Rob Herring 於 4/12/2024 11:52 PM 寫道: > CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content. > > > On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote: >> Change the original fixed delay to the assignment from the property. It >> will make it more flexible to different platforms to avoid pop noise at >> the beginning of recording. >> >> Signed-off-by: Seven Lee <wtli@nuvoton.com> >> --- >> .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml >> index 054b53954ac3..a726c5a9b067 100644 >> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml >> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml >> @@ -103,6 +103,13 @@ properties: >> just limited to the left adc for design demand. >> type: boolean >> >> + nuvoton,adc-delay-ms: >> + description: Delay (in ms) to make input path stable and avoid pop noise. >> + The default value is 125 and range between 125 to 500 ms. > No need to state constraints in prose. okay, I will fix it. > >> + minimum: 125 >> + maximum: 500 >> + default: 125 >> + >> '#sound-dai-cells': >> const: 0 >> >> @@ -136,6 +143,7 @@ examples: >> nuvoton,jack-eject-debounce = <0>; >> nuvoton,dmic-clk-threshold = <3072000>; >> nuvoton,dmic-slew-rate = <0>; >> + nuvoton,nuvoton,adc-delay-ms = <125>; >> #sound-dai-cells = <0>; >> }; >> }; >> -- >> 2.25.1 >>
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml index 054b53954ac3..a726c5a9b067 100644 --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml @@ -103,6 +103,13 @@ properties: just limited to the left adc for design demand. type: boolean + nuvoton,adc-delay-ms: + description: Delay (in ms) to make input path stable and avoid pop noise. + The default value is 125 and range between 125 to 500 ms. + minimum: 125 + maximum: 500 + default: 125 + '#sound-dai-cells': const: 0 @@ -136,6 +143,7 @@ examples: nuvoton,jack-eject-debounce = <0>; nuvoton,dmic-clk-threshold = <3072000>; nuvoton,dmic-slew-rate = <0>; + nuvoton,nuvoton,adc-delay-ms = <125>; #sound-dai-cells = <0>; }; };
Change the original fixed delay to the assignment from the property. It will make it more flexible to different platforms to avoid pop noise at the beginning of recording. Signed-off-by: Seven Lee <wtli@nuvoton.com> --- .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)