diff mbox series

gdb/testsuite: Use default gdb_expect timeout in runto

Message ID 20240420165903.930352-1-thiago.bauermann@linaro.org
State New
Headers show
Series gdb/testsuite: Use default gdb_expect timeout in runto | expand

Commit Message

Thiago Jung Bauermann April 20, 2024, 4:59 p.m. UTC 
runto uses a hard-coded timeout of 30s in its invocation of gdb_expect.
This is normally fine, but for very a slow system (e.g., an emulator) it
may not be enough time for GDB to reach the intended breakpoint.

gdb_expect can obtain a timeout value from user-configurable variables
when it's not given one explicitly, so use that mechanism instead since
the user will have already adjusted the timeout variable to account for
the slow system.
---

Hello,

When running testcases on a slow emulator, they failed while GDB was
starting up the inferior. This patch fixes the problem.

 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thiago Jung Bauermann April 22, 2024, 4:15 p.m. UTC | #1 
Hello Tom,

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Thiago" == Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
> Thiago> runto uses a hard-coded timeout of 30s in its invocation of gdb_expect.
> Thiago> This is normally fine, but for very a slow system (e.g., an emulator) it
> Thiago> may not be enough time for GDB to reach the intended breakpoint.
>
> Thiago> gdb_expect can obtain a timeout value from user-configurable variables
> Thiago> when it's not given one explicitly, so use that mechanism instead since
> Thiago> the user will have already adjusted the timeout variable to account for
> Thiago> the slow system.
>
> This seems fine to me.
> Approved-By: Tom Tromey <tom@tromey.com>

Thank you! Pushed as commit fdaa4939e502.

--
Thiago
diff mbox series

Patch

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index ddee928d5104..cbd37fd30947 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -768,7 +768,7 @@  proc runto { linespec args } {
     
     # the "at foo.c:36" output we get with -g.
     # the "in func" output we get without -g.
-    gdb_expect 30 {
+    gdb_expect {
 	-re "(?:Break|Temporary break).* at .*:$decimal.*$gdb_prompt $" {
 	    if { $print_pass } {
 		pass $test_name