mbox series

[0/6] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs

Message ID 20240422213006.505576-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Headers show
Series Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs | expand

Message

Prabhakar April 22, 2024, 9:30 p.m. UTC
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi All,

- RZ/G2UL and RZ/Five ("r9a07g043")
- RZ/G2L(C) ("r9a07g044")
- RZ/V2L ("r9a07g054")
- RZ/G3S ("r9a08g045")
- RZ/V2M ("r9a09g011")

The SD/MMC Interface in the above listed SoCs is not identical to that of
R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the
above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied.

Cheers,
Prabhakar

Lad Prabhakar (6):
  dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
  dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
  mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S,
    and RZ/V2M SoCs
  arm64: dts: renesas: r9a09g011: Update fallback string for SDHI nodes
  arm64: dts: renesas: rzg2l-family: Update fallback string for SDHI
    nodes
  arm64: dts: renesas: r9a08g045: Update fallback string for SDHI nodes

 .../devicetree/bindings/mmc/renesas,sdhi.yaml | 38 ++++++++-----------
 arch/arm64/boot/dts/renesas/r9a07g043.dtsi    |  4 +-
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  4 +-
 arch/arm64/boot/dts/renesas/r9a07g054.dtsi    |  4 +-
 arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  6 +--
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi    |  6 +--
 drivers/mmc/host/renesas_sdhi_internal_dmac.c |  8 ++--
 7 files changed, 31 insertions(+), 39 deletions(-)

Comments

Krzysztof Kozlowski April 23, 2024, 6:29 a.m. UTC | #1
On 22/04/2024 23:30, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Drop 'items' keyword from compatible list which have single const value.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 29f2400247eb..90c8b1b727a8 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -12,16 +12,11 @@ maintainers:
>  properties:
>    compatible:
>      oneOf:
> -      - items:
> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> -      - items:
> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
> -      - items:
> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> -      - items:
> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> -      - items:
> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1

That's just an enum.

>        - items:
>            - enum:
>                - renesas,sdhi-r8a7778 # R-Car M1
> @@ -40,8 +35,7 @@ properties:
>                - renesas,sdhi-r8a7793  # R-Car M2-N
>                - renesas,sdhi-r8a7794  # R-Car E2
>            - const: renesas,rcar-gen2-sdhi # R-Car Gen2 and RZ/G1
> -      - items:
> -          - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
> +      - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)

This as well



Best regards,
Krzysztof
Geert Uytterhoeven April 23, 2024, 6:53 a.m. UTC | #2
Hi Prabhakar,

On Mon, Apr 22, 2024 at 11:30 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> - RZ/G2UL and RZ/Five ("r9a07g043")
> - RZ/G2L(C) ("r9a07g044")
> - RZ/V2L ("r9a07g054")
> - RZ/G3S ("r9a08g045")
> - RZ/V2M ("r9a09g011")
>
> The above SoCs have HS400 disabled and use fixed address mode. Add a
> generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
> where fixed_addr_mode and hs400_disabled quirks are applied.

Thanks for your patch!
>
> Note, 'renesas,sdhi-r9a09g011' is dropped as we will be using
> 'renesas,rzg2l-sdhi' as a fallback string for RZ/V2M SoC.

Doesn't that break backwards compatibility with existing DTBs?

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index 53d34c3eddce..1828c37e0198 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -210,7 +210,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks_r8a77990 = {
>         .manual_tap_correction = true,
>  };
>
> -static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 = {
> +static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l = {
>         .fixed_addr_mode = true,
>         .hs400_disabled = true,
>  };
> @@ -255,9 +255,9 @@ static const struct renesas_sdhi_of_data_with_quirks of_r8a77990_compatible = {
>         .quirks = &sdhi_quirks_r8a77990,
>  };
>
> -static const struct renesas_sdhi_of_data_with_quirks of_r9a09g011_compatible = {
> +static const struct renesas_sdhi_of_data_with_quirks of_rzg2l_compatible = {
>         .of_data = &of_data_rcar_gen3,
> -       .quirks = &sdhi_quirks_r9a09g011,
> +       .quirks = &sdhi_quirks_rzg2l,
>  };
>
>  static const struct renesas_sdhi_of_data_with_quirks of_rcar_gen3_compatible = {
> @@ -283,7 +283,7 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
>         { .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
>         { .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
>         { .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
> -       { .compatible = "renesas,sdhi-r9a09g011", .data = &of_r9a09g011_compatible, },

Hence I think the above line should be kept, but changed to point
to &of_rzg2l_compatible.

> +       { .compatible = "renesas,rzg2l-sdhi", .data = &of_rzg2l_compatible, },
>         { .compatible = "renesas,rcar-gen3-sdhi", .data = &of_rcar_gen3_compatible, },
>         { .compatible = "renesas,rcar-gen4-sdhi", .data = &of_rcar_gen3_compatible, },
>         {},

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven April 23, 2024, 6:57 a.m. UTC | #3
Hi Prabhakar,

On Mon, Apr 22, 2024 at 11:30 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> - RZ/G2UL and RZ/Five ("r9a07g043")
> - RZ/G2L(C) ("r9a07g044")
> - RZ/V2L ("r9a07g054")
> - RZ/G3S ("r9a08g045")
> - RZ/V2M ("r9a09g011")
>
> The SD/MMC Interface in the above listed SoCs is not identical to that of
> R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
> Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
> 'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the
> above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied.

Thanks for your series!

> Lad Prabhakar (6):
>   dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
>   dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
>   mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S,
>     and RZ/V2M SoCs
>   arm64: dts: renesas: r9a09g011: Update fallback string for SDHI nodes
>   arm64: dts: renesas: rzg2l-family: Update fallback string for SDHI
>     nodes
>   arm64: dts: renesas: r9a08g045: Update fallback string for SDHI nodes

The DTS patches have a hard dependency on the driver changes, right?
So they cannot be applied in parallel.

Gr{oetje,eeting}s,

                        Geert
Prabhakar April 23, 2024, 7:11 a.m. UTC | #4
Hi Geert,

Thank you for the review.

On Tue, Apr 23, 2024 at 7:53 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Apr 22, 2024 at 11:30 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > - RZ/G2UL and RZ/Five ("r9a07g043")
> > - RZ/G2L(C) ("r9a07g044")
> > - RZ/V2L ("r9a07g054")
> > - RZ/G3S ("r9a08g045")
> > - RZ/V2M ("r9a09g011")
> >
> > The above SoCs have HS400 disabled and use fixed address mode. Add a
> > generic compatible 'renesas,rzg2l-sdhi' fallback string for these SoCs,
> > where fixed_addr_mode and hs400_disabled quirks are applied.
>
> Thanks for your patch!
> >
> > Note, 'renesas,sdhi-r9a09g011' is dropped as we will be using
> > 'renesas,rzg2l-sdhi' as a fallback string for RZ/V2M SoC.
>
> Doesn't that break backwards compatibility with existing DTBs?
>
I was in two minds here, as similarly to the RZ/G2L family the RZ/V2M
has Gen3 compat string as a fallback in the DTSI. So for existing DTBs
this would still work (but with no quirks applied). But as you say
I'll keep this to make sure we dont break anything,

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > index 53d34c3eddce..1828c37e0198 100644
> > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> > @@ -210,7 +210,7 @@ static const struct renesas_sdhi_quirks sdhi_quirks_r8a77990 = {
> >         .manual_tap_correction = true,
> >  };
> >
> > -static const struct renesas_sdhi_quirks sdhi_quirks_r9a09g011 = {
> > +static const struct renesas_sdhi_quirks sdhi_quirks_rzg2l = {
> >         .fixed_addr_mode = true,
> >         .hs400_disabled = true,
> >  };
> > @@ -255,9 +255,9 @@ static const struct renesas_sdhi_of_data_with_quirks of_r8a77990_compatible = {
> >         .quirks = &sdhi_quirks_r8a77990,
> >  };
> >
> > -static const struct renesas_sdhi_of_data_with_quirks of_r9a09g011_compatible = {
> > +static const struct renesas_sdhi_of_data_with_quirks of_rzg2l_compatible = {
> >         .of_data = &of_data_rcar_gen3,
> > -       .quirks = &sdhi_quirks_r9a09g011,
> > +       .quirks = &sdhi_quirks_rzg2l,
> >  };
> >
> >  static const struct renesas_sdhi_of_data_with_quirks of_rcar_gen3_compatible = {
> > @@ -283,7 +283,7 @@ static const struct of_device_id renesas_sdhi_internal_dmac_of_match[] = {
> >         { .compatible = "renesas,sdhi-r8a77970", .data = &of_r8a77970_compatible, },
> >         { .compatible = "renesas,sdhi-r8a77990", .data = &of_r8a77990_compatible, },
> >         { .compatible = "renesas,sdhi-r8a77995", .data = &of_rcar_gen3_nohs400_compatible, },
> > -       { .compatible = "renesas,sdhi-r9a09g011", .data = &of_r9a09g011_compatible, },
>
> Hence I think the above line should be kept, but changed to point
> to &of_rzg2l_compatible.
>
OK, will do.

Cheers,
Prabhakar
Prabhakar April 23, 2024, 7:14 a.m. UTC | #5
Hi Geert,

On Tue, Apr 23, 2024 at 7:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Apr 22, 2024 at 11:30 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > - RZ/G2UL and RZ/Five ("r9a07g043")
> > - RZ/G2L(C) ("r9a07g044")
> > - RZ/V2L ("r9a07g054")
> > - RZ/G3S ("r9a08g045")
> > - RZ/V2M ("r9a09g011")
> >
> > The SD/MMC Interface in the above listed SoCs is not identical to that of
> > R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
> > Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
> > 'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the
> > above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied.
>
> Thanks for your series!
>
> > Lad Prabhakar (6):
> >   dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
> >   dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
> >   mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S,
> >     and RZ/V2M SoCs
> >   arm64: dts: renesas: r9a09g011: Update fallback string for SDHI nodes
> >   arm64: dts: renesas: rzg2l-family: Update fallback string for SDHI
> >     nodes
> >   arm64: dts: renesas: r9a08g045: Update fallback string for SDHI nodes
>
> The DTS patches have a hard dependency on the driver changes, right?
> So they cannot be applied in parallel.
>
Agreed, I sent them together to make the DT bot happy for the dtbs
checks. While sending a v2 Ill split them up.

Cheers,
Prabhakar
Prabhakar April 23, 2024, 7:21 a.m. UTC | #6
Hi Krzysztof,

Thank you for the review.

On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 22/04/2024 23:30, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Drop 'items' keyword from compatible list which have single const value.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
> >  1 file changed, 6 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 29f2400247eb..90c8b1b727a8 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -12,16 +12,11 @@ maintainers:
> >  properties:
> >    compatible:
> >      oneOf:
> > -      - items:
> > -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> > -      - items:
> > -          - const: renesas,sdhi-r7s72100 # RZ/A1H
> > -      - items:
> > -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > -      - items:
> > -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > -      - items:
> > -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> > +      - const: renesas,sdhi-r7s72100 # RZ/A1H
> > +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
>
> That's just an enum.
>
Are you suggesting to group them into a single enum instead...?

> >        - items:
> >            - enum:
> >                - renesas,sdhi-r8a7778 # R-Car M1
> > @@ -40,8 +35,7 @@ properties:
> >                - renesas,sdhi-r8a7793  # R-Car M2-N
> >                - renesas,sdhi-r8a7794  # R-Car E2
> >            - const: renesas,rcar-gen2-sdhi # R-Car Gen2 and RZ/G1
> > -      - items:
> > -          - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
> > +      - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
>
> This as well
... including this?

Cheers,
Prabhakar
Krzysztof Kozlowski April 23, 2024, 9:59 a.m. UTC | #7
On 23/04/2024 09:21, Lad, Prabhakar wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
> On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 22/04/2024 23:30, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> Drop 'items' keyword from compatible list which have single const value.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
>>>  1 file changed, 6 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> index 29f2400247eb..90c8b1b727a8 100644
>>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> @@ -12,16 +12,11 @@ maintainers:
>>>  properties:
>>>    compatible:
>>>      oneOf:
>>> -      - items:
>>> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
>>> -      - items:
>>> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> -      - items:
>>> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> -      - items:
>>> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> -      - items:
>>> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
>>> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>
>> That's just an enum.
>>
> Are you suggesting to group them into a single enum instead...?

Yes. That's preferred form, easier to read, because it clearly documents
that binding enumerates.

But just in case you start changing all const to enums: don't. Comment
is for this patch, since you already want to touch these things.

Best regards,
Krzysztof
Prabhakar April 23, 2024, 11:26 a.m. UTC | #8
On Tue, Apr 23, 2024 at 10:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 23/04/2024 09:21, Lad, Prabhakar wrote:
> > Hi Krzysztof,
> >
> > Thank you for the review.
> >
> > On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 22/04/2024 23:30, Prabhakar wrote:
> >>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>>
> >>> Drop 'items' keyword from compatible list which have single const value.
> >>>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>> ---
> >>>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
> >>>  1 file changed, 6 insertions(+), 12 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> index 29f2400247eb..90c8b1b727a8 100644
> >>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >>> @@ -12,16 +12,11 @@ maintainers:
> >>>  properties:
> >>>    compatible:
> >>>      oneOf:
> >>> -      - items:
> >>> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> -      - items:
> >>> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
> >>> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> >>> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> >>> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
> >>
> >> That's just an enum.
> >>
> > Are you suggesting to group them into a single enum instead...?
>
> Yes. That's preferred form, easier to read, because it clearly documents
> that binding enumerates.
>
Agreed.

> But just in case you start changing all const to enums: don't. Comment
> is for this patch, since you already want to touch these things.
>
Indeed.

Cheers,
Prabhakar
Geert Uytterhoeven May 30, 2024, 1:43 p.m. UTC | #9
On Tue, Apr 23, 2024 at 8:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Apr 22, 2024 at 11:30 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > - RZ/G2UL and RZ/Five ("r9a07g043")
> > - RZ/G2L(C) ("r9a07g044")
> > - RZ/V2L ("r9a07g054")
> > - RZ/G3S ("r9a08g045")
> > - RZ/V2M ("r9a09g011")
> >
> > The SD/MMC Interface in the above listed SoCs is not identical to that of
> > R-Car Gen3. These SoCs have HS400 disabled and use fixed address mode.
> > Therefore, we need to apply fixed_addr_mode and hs400_disabled quirks.
> > 'renesas,rzg2l-sdhi' is introduced as a generic compatible string for the
> > above SoCs where fixed_addr_mode and hs400_disabled quirks will be applied.
>
> Thanks for your series!
>
> > Lad Prabhakar (6):
> >   dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
> >   dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility
> >   mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S,
> >     and RZ/V2M SoCs
> >   arm64: dts: renesas: r9a09g011: Update fallback string for SDHI nodes
> >   arm64: dts: renesas: rzg2l-family: Update fallback string for SDHI
> >     nodes
> >   arm64: dts: renesas: r9a08g045: Update fallback string for SDHI nodes
>
> The DTS patches have a hard dependency on the driver changes, right?
> So they cannot be applied in parallel.

As this dependency is not i v6.10-rc1, I will queue the DTS patches
in renesas-devel for v6.11.

Gr{oetje,eeting}s,

                        Geert