| Message ID | 20240130060838.3895599-1-quic_periyasa@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Refactor the hardware recovery procedures | expand |
On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: > Currently, in multi-wiphy models, the recovery handler access mac80211 > HW from the radio/link structure. This will be incorrect for single wiphy > model, as they will hold multiple link/radio structures. To fix this, > access mac80211 HW based on the number of hardware in the SoC/chip. This > approach makes the recovery handler compatible with both multi wiphy and > single wiphy models. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: > Currently, in multi wiphy models, the mac80211 hardware state is maintained > within the radio/link structure. However, in single wiphy models, the > mac80211 hardware state is needed at the hardware abstraction layer > (ath12k_hw). Therefore, move the hardware state from the radio/link > structure to the hardware abstraction layer (ath12k_hw). Additionally, > update the naming convention of the state enums to enhance clarity and > consistency. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: > Currently, hardware recovery procedure supports multi wiphy model. However, > to support single wiphy model, we need to refactor the hardware recovery > procedure. This patchset allows the logic to work both multi wiphy models > and future single wiphy models. > > Karthikeyan Periyasamy (3): > wifi: ath12k: Refactor the hardware recovery procedure > wifi: ath12k: Refactor hardware recovery synchronous > wifi: ath12k: Refactor the hardware state > > drivers/net/wireless/ath/ath12k/core.c | 97 ++++++++++++++------------ > drivers/net/wireless/ath/ath12k/core.h | 25 +++++-- > drivers/net/wireless/ath/ath12k/mac.c | 95 +++++++++++++++++-------- > drivers/net/wireless/ath/ath12k/reg.c | 5 +- > 4 files changed, 137 insertions(+), 85 deletions(-) > > > base-commit: 17f4b952f067b1f87d14e6df4c8c216fe7a245d1 since the "[PATCH 0/8] wifi: ath12k: Introduce device group abstraction" series depends upon this series, is there a plan to re-spin a new version that addresses Kalle's concerns?
On 4/24/2024 2:25 AM, Jeff Johnson wrote: > On 1/29/2024 10:08 PM, Karthikeyan Periyasamy wrote: >> Currently, hardware recovery procedure supports multi wiphy model. However, >> to support single wiphy model, we need to refactor the hardware recovery >> procedure. This patchset allows the logic to work both multi wiphy models >> and future single wiphy models. >> >> Karthikeyan Periyasamy (3): >> wifi: ath12k: Refactor the hardware recovery procedure >> wifi: ath12k: Refactor hardware recovery synchronous >> wifi: ath12k: Refactor the hardware state >> >> drivers/net/wireless/ath/ath12k/core.c | 97 ++++++++++++++------------ >> drivers/net/wireless/ath/ath12k/core.h | 25 +++++-- >> drivers/net/wireless/ath/ath12k/mac.c | 95 +++++++++++++++++-------- >> drivers/net/wireless/ath/ath12k/reg.c | 5 +- >> 4 files changed, 137 insertions(+), 85 deletions(-) >> >> >> base-commit: 17f4b952f067b1f87d14e6df4c8c216fe7a245d1 > > since the "[PATCH 0/8] wifi: ath12k: Introduce device group abstraction" > series depends upon this series, is there a plan to re-spin a new version that > addresses Kalle's concerns? > yes, will respin the next version.