diff mbox series

[v3,50/68] selftests/resctrl: Drop duplicate -D_GNU_SOURCE

Message ID	20240509200022.253089-51-edliaw@google.com
State	Superseded
Headers	show Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA32A14290F for <linux-kselftest@vger.kernel.org>; Thu, 9 May 2024 20:03:16 +0000 (UTC) Date: Thu, 9 May 2024 19:58:42 +0000 In-Reply-To: <20240509200022.253089-1-edliaw@google.com> Precedence: bulk Mime-Version: 1.0 References: <20240509200022.253089-1-edliaw@google.com> Message-ID: <20240509200022.253089-51-edliaw@google.com> Subject: [PATCH v3 50/68] selftests/resctrl: Drop duplicate -D_GNU_SOURCE From: Edward Liaw <edliaw@google.com> To: shuah@kernel.org, " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " <mic@digikod.net>, " =?utf-8?q?G?= =?utf-8?q?=C3=BCnther_Noack?= " <gnoack@google.com>, Christian Brauner <brauner@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, Fenghua Yu <fenghua.yu@intel.com>, Reinette Chatre <reinette.chatre@intel.com> Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Edward Liaw <edliaw@google.com>, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>, Muhammad Usama Anjum <usama.anjum@collabora.com> Content-Type: text/plain; charset="UTF-8"
Series	Define _GNU_SOURCE for sources using \| expand [v3,00/68] Define _GNU_SOURCE for sources using [v3,01/68] selftests: Compile kselftest headers with -D_GNU_SOURCE [v3,02/68] selftests/sgx: Include KHDR_INCLUDES in Makefile [v3,03/68] selftests: Compile with -D_GNU_SOURCE when including lib.mk [v3,04/68] selftests/arm64: Drop define _GNU_SOURCE [v3,05/68] selftests/arm64: Drop duplicate -D_GNU_SOURCE [v3,06/68] selftests/bpf: Drop define _GNU_SOURCE [v3,07/68] selftests/breakpoints: Drop define _GNU_SOURCE [v3,08/68] selftests/cachestat: Drop define _GNU_SOURCE [v3,09/68] selftests/capabilities: Drop define _GNU_SOURCE [v3,10/68] selftests/cgroup: Drop define _GNU_SOURCE [v3,11/68] selftests/clone3: Drop define _GNU_SOURCE [v3,12/68] selftests/core: Drop define _GNU_SOURCE [v3,13/68] selftests/damon: Drop define _GNU_SOURCE [v3,14/68] selftests/drivers: Drop define _GNU_SOURCE [v3,15/68] selftests/exec: Drop duplicate -D_GNU_SOURCE [v3,16/68] selftests/fchmodat2: Drop define _GNU_SOURCE [v3,17/68] selftests/filelock: Drop define _GNU_SOURCE [v3,18/68] selftests/filesystems: Drop define _GNU_SOURCE [v3,19/68] selftests/firmware: Drop define _GNU_SOURCE [v3,20/68] selftests/fpu: Drop define _GNU_SOURCE [v3,21/68] selftests/futex: Drop define _GNU_SOURCE [v3,22/68] selftests/futex: Drop duplicate -D_GNU_SOURCE [v3,23/68] selftests/intel_pstate: Drop duplicate -D_GNU_SOURCE [v3,24/68] selftests/iommu: Drop duplicate -D_GNU_SOURCE [v3,25/68] selftests/ipc: Drop define _GNU_SOURCE [v3,26/68] selftests/kcmp: Drop define _GNU_SOURCE [v3,27/68] selftests/landlock: Drop define _GNU_SOURCE [v3,28/68] selftests/lsm: Drop define _GNU_SOURCE [v3,29/68] selftests/membarrier: Drop define _GNU_SOURCE [v3,30/68] selftests/memfd: Drop define _GNU_SOURCE [v3,31/68] selftests/mincore: Drop define _GNU_SOURCE [v3,32/68] selftests/mm: Drop define _GNU_SOURCE [v3,33/68] selftests/mount: Drop define _GNU_SOURCE [v3,34/68] selftests/mount_setattr: Drop define _GNU_SOURCE [v3,35/68] selftests/move_mount_set_group: Drop define _GNU_SOURCE [v3,36/68] selftests/mqueue: Drop define _GNU_SOURCE [v3,37/68] selftests/net: Drop define _GNU_SOURCE [v3,38/68] selftests/net: Drop duplicate -D_GNU_SOURCE [v3,39/68] selftests/nolibc: Drop define _GNU_SOURCE [v3,40/68] selftests/nsfs: Drop define _GNU_SOURCE [v3,41/68] selftests/openat2: Drop define _GNU_SOURCE [v3,42/68] selftests/perf_events: Drop define _GNU_SOURCE [v3,43/68] selftests/pid_namespace: Drop define _GNU_SOURCE [v3,44/68] selftests/pidfd: Drop define _GNU_SOURCE [v3,45/68] selftests/ptrace: Drop define _GNU_SOURCE [v3,46/68] selftests/powerpc: Drop define _GNU_SOURCE [v3,47/68] selftests/proc: Drop define _GNU_SOURCE [v3,48/68] selftests/proc: Drop duplicate -D_GNU_SOURCE [v3,49/68] selftests/ptp: Drop define _GNU_SOURCE [v3,50/68] selftests/resctrl: Drop duplicate -D_GNU_SOURCE [v3,51/68] selftests/riscv: Drop define _GNU_SOURCE [v3,52/68] selftests/riscv: Drop duplicate -D_GNU_SOURCE [v3,53/68] selftests/rlimits: Drop define _GNU_SOURCE [v3,54/68] selftests/rseq: Drop define _GNU_SOURCE [v3,55/68] selftests/safesetid: Drop define _GNU_SOURCE [v3,56/68] selftests/sched: Drop define _GNU_SOURCE [v3,57/68] selftests/seccomp: Drop define _GNU_SOURCE [v3,58/68] selftests/sigaltstack: Drop define _GNU_SOURCE [v3,59/68] selftests/splice: Drop define _GNU_SOURCE [v3,60/68] selftests/syscall_user_dispatch: Drop define _GNU_SOURCE [v3,61/68] selftests/thermal: Drop define _GNU_SOURCE [v3,62/68] selftests/timens: Drop define _GNU_SOURCE [v3,63/68] selftests/tmpfs: Drop duplicate -D_GNU_SOURCE [v3,64/68] selftests/uevent: Drop define _GNU_SOURCE [v3,65/68] selftests/user_events: Drop define _GNU_SOURCE [v3,66/68] selftests/vDSO: Drop define _GNU_SOURCE [v3,67/68] selftests/wireguard: Drop define _GNU_SOURCE [v3,68/68] selftests/x86: Drop define _GNU_SOURCE

Commit Message

Edward Liaw May 9, 2024, 7:58 p.m. UTC

-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.

Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/resctrl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Reinette Chatre May 9, 2024, 10:22 p.m. UTC | #1

Hi Edward,

On 5/9/2024 12:58 PM, Edward Liaw wrote:
> -D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---

Thank you very much.

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette

diff mbox series

Patch

diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
index 021863f86053..f408bd6bfc3d 100644
--- a/tools/testing/selftests/resctrl/Makefile
+++ b/tools/testing/selftests/resctrl/Makefile
@@ -1,6 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0
 
-CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE
+CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2
 CFLAGS += $(KHDR_INCLUDES)
 
 TEST_GEN_PROGS := resctrl_tests