| Message ID | 20240509-videocc-sm8150-dt-node-v4-0-e9617f65e946@quicinc.com |
|---|---|
| Headers | show |
| Series | Add DT support for video clock controller on SM8150 | expand |
On Thu, May 09, 2024 at 03:54:03PM +0530, Satya Priya Kakitapalli wrote: > SM8150 videocc needs AHB clock, so update the bindings for sm8150 > to add the AHB clock. Breaking the ABI is fine because ____. > > Fixes: df3f61d2cdc9 ("dt-bindings: clock: add SM8150 QCOM video clock bindings") > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> > --- > .../devicetree/bindings/clock/qcom,videocc.yaml | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > index 6999e36ace1b..68bac801adb0 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml > @@ -75,7 +75,6 @@ allOf: > enum: > - qcom,sc7180-videocc > - qcom,sdm845-videocc > - - qcom,sm8150-videocc > then: > properties: > clocks: > @@ -101,6 +100,22 @@ allOf: > - const: bi_tcxo > - const: bi_tcxo_ao > > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8150-videocc > + then: > + properties: > + clocks: > + items: > + - description: AHB > + - description: Board XO source > + clock-names: > + items: > + - const: iface > + - const: bi_tcxo > + > - if: > properties: > compatible: > > -- > 2.25.1 >
On Thu, 09 May 2024 15:54:02 +0530, Satya Priya Kakitapalli wrote:
>
Applied, thanks!
[2/2] arm64: dts: qcom: sm8150: Add video clock controller node
commit: cfe9685473add0ae76952f0eb54489c3547db335
Best regards,
Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> --- Changes in v4: - Correct the Fixes tag in [1/2] - Link to v3: https://lore.kernel.org/r/20240509-videocc-sm8150-dt-node-v3-0-7135e8060f62@quicinc.com Changes in v3: - Adding the required-opps property back, which was removed in v2. - This is needed because the lowest power state for MMCX on sm8150 platform is retention, but we want to enable the power domain in low_svs not retention. - Link to v2: https://lore.kernel.org/r/20240401-videocc-sm8150-dt-node-v2-0-3b87cd2add96@quicinc.com Changes in v2: - As per Dmitry's comments, there is no need to update to index based lookup for already existing drivers, hence keeping clock-names property. - Updated the videocc bindings to add AHB clock for the sm8150 platform. - Link to v1: https://lore.kernel.org/r/20240313-videocc-sm8150-dt-node-v1-0-ae8ec3c822c2@quicinc.com --- Satya Priya Kakitapalli (2): dt-bindings: clock: qcom: Add AHB clock for SM8150 arm64: dts: qcom: sm8150: Add video clock controller node .../devicetree/bindings/clock/qcom,videocc.yaml | 17 ++++++++++++++++- arch/arm64/boot/dts/qcom/sa8155p.dtsi | 4 ++++ arch/arm64/boot/dts/qcom/sm8150.dtsi | 14 ++++++++++++++ 3 files changed, 34 insertions(+), 1 deletion(-) --- base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd change-id: 20240308-videocc-sm8150-dt-node-6f163b492f7c Best regards,