| Message ID | 1399066407-25621-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Rejected |
| Headers | show |
No, that line has to be here for quick changing to debug version. Thanks, Maxim. On 05/03/2014 01:33 AM, Anders Roxell wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > Makefile.inc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Makefile.inc b/Makefile.inc > index a5aeb8b..019836a 100644 > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -19,7 +19,6 @@ COPY := cp -r > > EXTRA_CFLAGS += -DODP_DEBUG=1 > EXTRA_CFLAGS += -O3 > -#EXTRA_CFLAGS += -O0 -g > EXTRA_CFLAGS += -pthread > EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > EXTRA_CFLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > No, that line has to be here for quick changing to debug version. > I hope that was a joke right? whats the problem with: make CFLAGS="-O0 -g" Cheers, Anders > > Thanks, > Maxim. > > > On 05/03/2014 01:33 AM, Anders Roxell wrote: > >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> Makefile.inc | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Makefile.inc b/Makefile.inc >> index a5aeb8b..019836a 100644 >> --- a/Makefile.inc >> +++ b/Makefile.inc >> @@ -19,7 +19,6 @@ COPY := cp -r >> EXTRA_CFLAGS += -DODP_DEBUG=1 >> EXTRA_CFLAGS += -O3 >> -#EXTRA_CFLAGS += -O0 -g >> EXTRA_CFLAGS += -pthread >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes >> -Wmissing-prototypes >> EXTRA_CFLAGS += -Wmissing-declarations -Wold-style-definition >> -Wpointer-arith >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 05/05/2014 01:52 PM, Anders Roxell wrote: > > > > On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > No, that line has to be here for quick changing to debug version. > > > I hope that was a joke right? > > whats the problem with: > make CFLAGS="-O0 -g" > > Cheers, > Anders cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c first option has more priority then second, right? Maxim. > > Thanks, > Maxim. > > > On 05/03/2014 01:33 AM, Anders Roxell wrote: > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org > <mailto:anders.roxell@linaro.org>> > --- > Makefile.inc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Makefile.inc b/Makefile.inc > index a5aeb8b..019836a 100644 > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -19,7 +19,6 @@ COPY := cp -r > EXTRA_CFLAGS += -DODP_DEBUG=1 > EXTRA_CFLAGS += -O3 > -#EXTRA_CFLAGS += -O0 -g > EXTRA_CFLAGS += -pthread > EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes > -Wmissing-prototypes > EXTRA_CFLAGS += -Wmissing-declarations > -Wold-style-definition -Wpointer-arith > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > http://lists.linaro.org/mailman/listinfo/lng-odp > >
Another approach perhaps? ifeq ($(DEBUG),yes) EXTRA_CFLAGS += -O0 -g EXTRA_CFLAGS += -DODP_DEBUG=1 else EXTRA_CFLAGS += -O3 endif $ make DEBUG=yes On 5 May 2014 11:59, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 05/05/2014 01:52 PM, Anders Roxell wrote: > >> >> >> >> On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org>> wrote: >> >> No, that line has to be here for quick changing to debug version. >> >> >> I hope that was a joke right? >> >> whats the problem with: >> make CFLAGS="-O0 -g" >> >> Cheers, >> Anders > > cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 > -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align > -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef > -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c > > first option has more priority then second, right? > > Maxim. > > >> >> Thanks, >> Maxim. >> >> >> On 05/03/2014 01:33 AM, Anders Roxell wrote: >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org >> <mailto:anders.roxell@linaro.org>> >> >> --- >> Makefile.inc | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Makefile.inc b/Makefile.inc >> index a5aeb8b..019836a 100644 >> --- a/Makefile.inc >> +++ b/Makefile.inc >> @@ -19,7 +19,6 @@ COPY := cp -r >> EXTRA_CFLAGS += -DODP_DEBUG=1 >> EXTRA_CFLAGS += -O3 >> -#EXTRA_CFLAGS += -O0 -g >> EXTRA_CFLAGS += -pthread >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes >> -Wmissing-prototypes >> EXTRA_CFLAGS += -Wmissing-declarations >> -Wold-style-definition -Wpointer-arith >> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp
Hi, On Mon, May 5, 2014 at 3:08 PM, Ola Liljedahl <ola.liljedahl@linaro.org>wrote: > Another approach perhaps? > > ifeq ($(DEBUG),yes) > EXTRA_CFLAGS += -O0 -g > EXTRA_CFLAGS += -DODP_DEBUG=1 > else > EXTRA_CFLAGS += -O3 > endif > > $ make DEBUG=yes > That was my thought as well. > > On 5 May 2014 11:59, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > > On 05/05/2014 01:52 PM, Anders Roxell wrote: > > > >> > >> > >> > >> On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org > >> <mailto:maxim.uvarov@linaro.org>> wrote: > >> > >> No, that line has to be here for quick changing to debug version. > >> > >> > >> I hope that was a joke right? > >> > >> whats the problem with: > >> make CFLAGS="-O0 -g" > >> > >> Cheers, > >> Anders > > > > cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 > > -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > > -Wmissing-declarations -Wold-style-definition -Wpointer-arith > -Wcast-align > > -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security > -Wundef > > -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c > > > > first option has more priority then second, right? > > > > Maxim. > > > > > >> > >> Thanks, > >> Maxim. > >> > >> > >> On 05/03/2014 01:33 AM, Anders Roxell wrote: > >> > >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org > >> <mailto:anders.roxell@linaro.org>> > >> > >> --- > >> Makefile.inc | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/Makefile.inc b/Makefile.inc > >> index a5aeb8b..019836a 100644 > >> --- a/Makefile.inc > >> +++ b/Makefile.inc > >> @@ -19,7 +19,6 @@ COPY := cp -r > >> EXTRA_CFLAGS += -DODP_DEBUG=1 > >> EXTRA_CFLAGS += -O3 > >> -#EXTRA_CFLAGS += -O0 -g > >> EXTRA_CFLAGS += -pthread > >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes > >> -Wmissing-prototypes > >> EXTRA_CFLAGS += -Wmissing-declarations > >> -Wold-style-definition -Wpointer-arith > >> > >> > >> > >> _______________________________________________ > >> lng-odp mailing list > >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > >> http://lists.linaro.org/mailman/listinfo/lng-odp > >> > >> > > > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 5 May 2014 11:59, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 05/05/2014 01:52 PM, Anders Roxell wrote: > > >> >> >> On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org <mailto: >> maxim.uvarov@linaro.org>> wrote: >> >> No, that line has to be here for quick changing to debug version. >> >> >> I hope that was a joke right? >> >> whats the problem with: >> make CFLAGS="-O0 -g" >> >> Cheers, >> Anders >> > cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 > -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align > -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef > -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c > > first option has more priority then second, right? > argh... you right! I missed that, I'm sorry! > > Maxim. > > > >> Thanks, >> Maxim. >> >> >> On 05/03/2014 01:33 AM, Anders Roxell wrote: >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org >> <mailto:anders.roxell@linaro.org>> >> >> --- >> Makefile.inc | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Makefile.inc b/Makefile.inc >> index a5aeb8b..019836a 100644 >> --- a/Makefile.inc >> +++ b/Makefile.inc >> @@ -19,7 +19,6 @@ COPY := cp -r >> EXTRA_CFLAGS += -DODP_DEBUG=1 >> EXTRA_CFLAGS += -O3 >> -#EXTRA_CFLAGS += -O0 -g >> EXTRA_CFLAGS += -pthread >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes >> -Wmissing-prototypes >> EXTRA_CFLAGS += -Wmissing-declarations >> -Wold-style-definition -Wpointer-arith >> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >
On 5 May 2014 14:08, Ola Liljedahl <ola.liljedahl@linaro.org> wrote: > Another approach perhaps? > > ifeq ($(DEBUG),yes) > EXTRA_CFLAGS += -O0 -g > EXTRA_CFLAGS += -DODP_DEBUG=1 > else > EXTRA_CFLAGS += -O3 > endif > > $ make DEBUG=yes > +1 Cheers, Anders > > On 5 May 2014 11:59, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > > On 05/05/2014 01:52 PM, Anders Roxell wrote: > > > >> > >> > >> > >> On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org > >> <mailto:maxim.uvarov@linaro.org>> wrote: > >> > >> No, that line has to be here for quick changing to debug version. > >> > >> > >> I hope that was a joke right? > >> > >> whats the problem with: > >> make CFLAGS="-O0 -g" > >> > >> Cheers, > >> Anders > > > > cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 > > -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > > -Wmissing-declarations -Wold-style-definition -Wpointer-arith > -Wcast-align > > -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security > -Wundef > > -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c > > > > first option has more priority then second, right? > > > > Maxim. > > > > > >> > >> Thanks, > >> Maxim. > >> > >> > >> On 05/03/2014 01:33 AM, Anders Roxell wrote: > >> > >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org > >> <mailto:anders.roxell@linaro.org>> > >> > >> --- > >> Makefile.inc | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/Makefile.inc b/Makefile.inc > >> index a5aeb8b..019836a 100644 > >> --- a/Makefile.inc > >> +++ b/Makefile.inc > >> @@ -19,7 +19,6 @@ COPY := cp -r > >> EXTRA_CFLAGS += -DODP_DEBUG=1 > >> EXTRA_CFLAGS += -O3 > >> -#EXTRA_CFLAGS += -O0 -g > >> EXTRA_CFLAGS += -pthread > >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes > >> -Wmissing-prototypes > >> EXTRA_CFLAGS += -Wmissing-declarations > >> -Wold-style-definition -Wpointer-arith > >> > >> > >> > >> _______________________________________________ > >> lng-odp mailing list > >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > >> http://lists.linaro.org/mailman/listinfo/lng-odp > >> > >> > > > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > http://lists.linaro.org/mailman/listinfo/lng-odp >
I also started to type that +1 On 5 May 2014 08:26, Anders Roxell <anders.roxell@linaro.org> wrote: > > > > On 5 May 2014 14:08, Ola Liljedahl <ola.liljedahl@linaro.org> wrote: > >> Another approach perhaps? >> >> ifeq ($(DEBUG),yes) >> EXTRA_CFLAGS += -O0 -g >> EXTRA_CFLAGS += -DODP_DEBUG=1 >> else >> EXTRA_CFLAGS += -O3 >> endif >> >> $ make DEBUG=yes >> > > +1 > > Cheers, > Anders > > >> >> On 5 May 2014 11:59, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >> > On 05/05/2014 01:52 PM, Anders Roxell wrote: >> > >> >> >> >> >> >> >> >> On 5 May 2014 11:47, Maxim Uvarov <maxim.uvarov@linaro.org >> >> <mailto:maxim.uvarov@linaro.org>> wrote: >> >> >> >> No, that line has to be here for quick changing to debug version. >> >> >> >> >> >> I hope that was a joke right? >> >> >> >> whats the problem with: >> >> make CFLAGS="-O0 -g" >> >> >> >> Cheers, >> >> Anders >> > >> > cc -c -MD -I../../include -I./include -I./include/api -DODP_DEBUG=1 -O3 >> > -pthread -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes >> > -Wmissing-declarations -Wold-style-definition -Wpointer-arith >> -Wcast-align >> > -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security >> -Wundef >> > -Wwrite-strings -O0 -g -o obj/odp_queue.o source/odp_queue.c >> > >> > first option has more priority then second, right? >> > >> > Maxim. >> > >> > >> >> >> >> Thanks, >> >> Maxim. >> >> >> >> >> >> On 05/03/2014 01:33 AM, Anders Roxell wrote: >> >> >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org >> >> <mailto:anders.roxell@linaro.org>> >> >> >> >> --- >> >> Makefile.inc | 1 - >> >> 1 file changed, 1 deletion(-) >> >> >> >> diff --git a/Makefile.inc b/Makefile.inc >> >> index a5aeb8b..019836a 100644 >> >> --- a/Makefile.inc >> >> +++ b/Makefile.inc >> >> @@ -19,7 +19,6 @@ COPY := cp -r >> >> EXTRA_CFLAGS += -DODP_DEBUG=1 >> >> EXTRA_CFLAGS += -O3 >> >> -#EXTRA_CFLAGS += -O0 -g >> >> EXTRA_CFLAGS += -pthread >> >> EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes >> >> -Wmissing-prototypes >> >> EXTRA_CFLAGS += -Wmissing-declarations >> >> -Wold-style-definition -Wpointer-arith >> >> >> >> >> >> >> >> _______________________________________________ >> >> lng-odp mailing list >> >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> > >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> > http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > >
diff --git a/Makefile.inc b/Makefile.inc index a5aeb8b..019836a 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -19,7 +19,6 @@ COPY := cp -r EXTRA_CFLAGS += -DODP_DEBUG=1 EXTRA_CFLAGS += -O3 -#EXTRA_CFLAGS += -O0 -g EXTRA_CFLAGS += -pthread EXTRA_CFLAGS += -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes EXTRA_CFLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- Makefile.inc | 1 - 1 file changed, 1 deletion(-)