mbox series

[v1,0/6] leds: spi-byte: Cleanup, fix a leak, and make it agnostic

Message ID 20240606173037.3091598-1-andriy.shevchenko@linux.intel.com
Headers show
Series leds: spi-byte: Cleanup, fix a leak, and make it agnostic | expand

Message

Andy Shevchenko June 6, 2024, 5:29 p.m. UTC 
Clean up the driver, fix one leak, and make it possible to use outside
of OF systems.

Andy Shevchenko (6):
  leds: spi-byte: call of_node_put() on error path
  leds: spi-byte: Get rid of custom led_init_default_state_get()
  leds: spi-byte: Make use of device properties
  leds: spi-byte: Utilise temporary variable for struct device
  leds: spi-byte: Use devm_mutex_init() for mutex initialization
  leds: spi-byte: Move OF ID table closer to their user

 drivers/leds/Kconfig         |  1 -
 drivers/leds/leds-spi-byte.c | 63 +++++++++++++-----------------------
 2 files changed, 22 insertions(+), 42 deletions(-)

Comments

Andy Shevchenko June 6, 2024, 5:54 p.m. UTC | #1 
On Thu, Jun 06, 2024 at 08:29:18PM +0300, Andy Shevchenko wrote:
> Add a missing call to of_node_put(np) on error.

Oh, yeah, this might need the Fixes tag. depending if you want to backport
this fix or no hurry.
Lee Jones June 13, 2024, 4:05 p.m. UTC | #2 
On Thu, 06 Jun 2024 20:29:17 +0300, Andy Shevchenko wrote:
> Clean up the driver, fix one leak, and make it possible to use outside
> of OF systems.
> 
> Andy Shevchenko (6):
>   leds: spi-byte: call of_node_put() on error path
>   leds: spi-byte: Get rid of custom led_init_default_state_get()
>   leds: spi-byte: Make use of device properties
>   leds: spi-byte: Utilise temporary variable for struct device
>   leds: spi-byte: Use devm_mutex_init() for mutex initialization
>   leds: spi-byte: Move OF ID table closer to their user
> 
> [...]

Applied, thanks!

[1/6] leds: spi-byte: call of_node_put() on error path
      commit: 057739faa00602ca64090e084a664715ee74eb3c
[2/6] leds: spi-byte: Get rid of custom led_init_default_state_get()
      commit: 9cb832b2c7bcd8b5decd9e9c07302c802ee25faa
[3/6] leds: spi-byte: Make use of device properties
      commit: 3e3735a40ec6694fa70ae20d33545783b9d555af
[4/6] leds: spi-byte: Utilise temporary variable for struct device
      commit: dc5f64e4c1531d935c239eb4db3957c5cf569bb6
[5/6] leds: spi-byte: Use devm_mutex_init() for mutex initialization
      commit: cc5f66ad5640340ab8fb5753acc7218e2b60d36c
[6/6] leds: spi-byte: Move OF ID table closer to their user
      commit: 2ac2628cc23cae5c3a317eaa7f0d3a1d9359a3c9

--
Lee Jones [李琼斯]