| Message ID | 20240614030912.10736-1-jiapeng.chong@linux.alibaba.com |
|---|---|
| State | Accepted |
| Commit | f0da7a231c7d0bafb6bb56da597cb2bfaf2c7028 |
| Headers | show |
| Series | crypto: lib/mpi - Use swap() in mpi_ec_mul_point() | expand |
On Fri, Jun 14, 2024 at 11:09:11AM +0800, Jiapeng Chong wrote: > Use existing swap() function rather than duplicating its implementation. > > ./lib/crypto/mpi/ec.c:1291:20-21: WARNING opportunity for swap(). > ./lib/crypto/mpi/ec.c:1292:20-21: WARNING opportunity for swap(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9328 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > lib/crypto/mpi/ec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Patch applied. Thanks.
diff --git a/lib/crypto/mpi/ec.c b/lib/crypto/mpi/ec.c index e16dca1e23d5..4781f00982ef 100644 --- a/lib/crypto/mpi/ec.c +++ b/lib/crypto/mpi/ec.c @@ -1285,14 +1285,12 @@ void mpi_ec_mul_point(MPI_POINT result, sum = &p2_; for (j = nbits-1; j >= 0; j--) { - MPI_POINT t; - sw = mpi_test_bit(scalar, j); point_swap_cond(q1, q2, sw, ctx); montgomery_ladder(prd, sum, q1, q2, point->x, ctx); point_swap_cond(prd, sum, sw, ctx); - t = q1; q1 = prd; prd = t; - t = q2; q2 = sum; sum = t; + swap(q1, prd); + swap(q2, sum); } mpi_clear(result->y);
Use existing swap() function rather than duplicating its implementation. ./lib/crypto/mpi/ec.c:1291:20-21: WARNING opportunity for swap(). ./lib/crypto/mpi/ec.c:1292:20-21: WARNING opportunity for swap(). Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9328 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- lib/crypto/mpi/ec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)