| Message ID | 20240615-md-arm-lib-crypto-v1-1-27b67bf8573c@quicinc.com |
|---|---|
| State | Accepted |
| Commit | 3cbe18b0bc9f0653709adbdadad04491a190c71a |
| Headers | show |
| Series | crypto: lib - add missing MODULE_DESCRIPTION() macros | expand |
On Sat, Jun 15, 2024 at 11:14:57PM -0700, Jeff Johnson wrote: > With ARCH=arm, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/crypto/libsha256.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro to all > files which have a MODULE_LICENSE(). > > This includes sha1.c and utils.c which, although they did not produce > a warning with the arm allmodconfig configuration, may cause this > warning with other configurations. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > lib/crypto/sha1.c | 1 + > lib/crypto/sha256.c | 1 + > lib/crypto/utils.c | 1 + > 3 files changed, 3 insertions(+) Patch applied. Thanks.
diff --git a/lib/crypto/sha1.c b/lib/crypto/sha1.c index 1aebe7be9401..6d2922747cab 100644 --- a/lib/crypto/sha1.c +++ b/lib/crypto/sha1.c @@ -137,4 +137,5 @@ void sha1_init(__u32 *buf) } EXPORT_SYMBOL(sha1_init); +MODULE_DESCRIPTION("SHA-1 Algorithm"); MODULE_LICENSE("GPL"); diff --git a/lib/crypto/sha256.c b/lib/crypto/sha256.c index 3ac1ef8677db..3f42d203c7bc 100644 --- a/lib/crypto/sha256.c +++ b/lib/crypto/sha256.c @@ -165,4 +165,5 @@ void sha256(const u8 *data, unsigned int len, u8 *out) } EXPORT_SYMBOL(sha256); +MODULE_DESCRIPTION("SHA-256 Algorithm"); MODULE_LICENSE("GPL"); diff --git a/lib/crypto/utils.c b/lib/crypto/utils.c index c852c7151b0a..373364141408 100644 --- a/lib/crypto/utils.c +++ b/lib/crypto/utils.c @@ -85,4 +85,5 @@ void __crypto_xor(u8 *dst, const u8 *src1, const u8 *src2, unsigned int len) } EXPORT_SYMBOL_GPL(__crypto_xor); +MODULE_DESCRIPTION("Crypto library utility functions"); MODULE_LICENSE("GPL");
With ARCH=arm, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/crypto/libsha256.o Add the missing invocation of the MODULE_DESCRIPTION() macro to all files which have a MODULE_LICENSE(). This includes sha1.c and utils.c which, although they did not produce a warning with the arm allmodconfig configuration, may cause this warning with other configurations. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- lib/crypto/sha1.c | 1 + lib/crypto/sha256.c | 1 + lib/crypto/utils.c | 1 + 3 files changed, 3 insertions(+) --- base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 change-id: 20240615-md-arm-lib-crypto-455de535d8a0