mbox series

[v2,0/7] UFS patches for kernel 6.11

Message ID 20240627195918.2709502-1-bvanassche@acm.org
Headers show
Series UFS patches for kernel 6.11 | expand

Message

Bart Van Assche June 27, 2024, 7:58 p.m. UTC 
Hi Martin,

Please consider this series of UFS driver patches for the next merge window.

Thank you,

Bart.

Changes compared to v1:
 - Based upon reviewer feedback, a new patch that renames the
   MASK_TRANSFER_REQUESTS_SLOTS constant has been added.
 - Because there is no agreement about these patches, the following three
   patches have been left out: "Make ufshcd_poll() complain about unsupported
   arguments", "Make the polling code report which command has been completed"
   and also "Check for completion from the timeout handler".

Bart Van Assche (7):
  scsi: ufs: Declare ufshcd_mcq_poll_cqe_lock() once
  scsi: ufs: Initialize struct uic_command once
  scsi: ufs: Remove two constants
  scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant
  scsi: ufs: Initialize hba->reserved_slot earlier
  scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac()
  scsi: ufs: Make .get_hba_mac() optional

 drivers/ufs/core/ufs-mcq.c     | 19 ++++++---
 drivers/ufs/core/ufshcd-priv.h | 10 -----
 drivers/ufs/core/ufshcd.c      | 73 ++++++++++++++++------------------
 include/ufs/ufshcd.h           |  8 ++--
 include/ufs/ufshci.h           |  3 +-
 5 files changed, 55 insertions(+), 58 deletions(-)

Comments

Keoseong Park June 28, 2024, 2:13 a.m. UTC | #1 
> ufshcd_mcq_poll_cqe_lock() is declared in include/ufs/ufshcd.h and also in
> drivers/ufs/core/ufshcd-priv.h. Remove the declaration from the latter file.

Hi Bart,

The functions below seem to be the same case.
 - ufshcd_mcq_write_cqis()
 - ufshcd_mcq_read_cqis()
 - ufshcd_mcq_config_mac()
 - ufshcd_mcq_make_queues_operational()

How about including these cases in the patch as well?

Best Regards,
Keoseong

> 
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/ufs/core/ufshcd-priv.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
> index f42d99ce5bf1..0bce72848402 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -72,8 +72,6 @@ u32 ufshcd_mcq_read_cqis(struct ufs_hba *hba, int i);
>  void ufshcd_mcq_write_cqis(struct ufs_hba *hba, u32 val, int i);
>  struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
>  					   struct request *req);
> -unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
> -				       struct ufs_hw_queue *hwq);
>  void ufshcd_mcq_compl_all_cqes_lock(struct ufs_hba *hba,
>  				    struct ufs_hw_queue *hwq);
>  bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd);
Bart Van Assche June 28, 2024, 7:28 p.m. UTC | #2 
On 6/27/24 7:13 PM, Keoseong Park wrote:
>> ufshcd_mcq_poll_cqe_lock() is declared in include/ufs/ufshcd.h and also in
>> drivers/ufs/core/ufshcd-priv.h. Remove the declaration from the latter file.
> 
> Hi Bart,
> 
> The functions below seem to be the same case.
>   - ufshcd_mcq_write_cqis()
>   - ufshcd_mcq_read_cqis()
>   - ufshcd_mcq_config_mac()
>   - ufshcd_mcq_make_queues_operational()
> 
> How about including these cases in the patch as well?

I will do that.

Thanks,

Bart.