diff mbox series

[3/6] bus: mhi: increase RDDM timeout

Message ID 20240718061344.575653-4-quic_gokulsri@quicinc.com
State New
Headers show
Series add improvements to mhi driver | expand

Commit Message

Gokul Sriram Palanisamy July 18, 2024, 6:13 a.m. UTC 
From: Praveenkumar I <quic_ipkumar@quicinc.com>

Host sometimes misses the EE RDDM during kernel panic causing
RDDM failure. Increase RDDM timeout to overcome this issue.

Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
---
 drivers/bus/mhi/host/boot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeffrey Hugo July 18, 2024, 4:23 p.m. UTC | #1 
On 7/18/2024 12:13 AM, Gokul Sriram Palanisamy wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
> 
> Host sometimes misses the EE RDDM during kernel panic causing
> RDDM failure. Increase RDDM timeout to overcome this issue.

If we are in the middle of a Linux kernel panic, the host is going down, 
so why do we care about RDDM?

How did you determine the new value?

Really seems like significantly more detail is needed here.
Jeffrey Hugo July 28, 2024, 8:24 p.m. UTC | #2 
On 7/28/2024 7:41 AM, Gokul Sriram P wrote:
> 
> On 7/18/2024 9:53 PM, Jeffrey Hugo wrote:
>> On 7/18/2024 12:13 AM, Gokul Sriram Palanisamy wrote:
>>> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>>>
>>> Host sometimes misses the EE RDDM during kernel panic causing
>>> RDDM failure. Increase RDDM timeout to overcome this issue.
>>
>> If we are in the middle of a Linux kernel panic, the host is going 
>> down, so why do we care about RDDM?
>>
>> How did you determine the new value?
>>
>> Really seems like significantly more detail is needed here.
> 
> If kernel panic was due to mhi, we need to have the RDDM dump and this 
> is already supported in upstream MHI.

Why would mhi cause a linux kernel panic?  That just sounds insane to 
me.  Also what you point to is not used, so I fail to see how it relates 
to your point here.

I'm still unconvinced that this change brings any value.
diff mbox series

Patch

diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
index 1a918e340424..324510d2c7fd 100644
--- a/drivers/bus/mhi/host/boot.c
+++ b/drivers/bus/mhi/host/boot.c
@@ -77,7 +77,7 @@  static int __mhi_download_rddm_in_panic(struct mhi_controller *mhi_cntrl)
 	enum mhi_ee_type ee;
 	const u32 delayus = 2000;
 	u32 retry = (mhi_cntrl->timeout_ms * 1000) / delayus;
-	const u32 rddm_timeout_us = 200000;
+	const u32 rddm_timeout_us = 400000;
 	int rddm_retry = rddm_timeout_us / delayus;
 	void __iomem *base = mhi_cntrl->bhie;
 	struct device *dev = &mhi_cntrl->mhi_dev->dev;