Message ID | 20240812144131.369378-1-quic_depengs@quicinc.com |
---|---|
Headers | show |
Series | media: qcom: camss: Add sm8550 support | expand |
On 12/08/2024 15:41, Depeng Shao wrote: > v4: > - Update dt-bindings based on comments - Krzysztof, bod, Vladimir > - Move common code into csid core and vfe core driver - bod > - Remove *_relaxed in the csid and vfe drivers - Krzysztof > - Reorganize patches in logical junks, make sure that new added > structures have users in current patch - Krzysztof > - Remove notify function and add new functions in camss for buf done > and reg update - bod > - Remove custom code to get csid base - bod > - Remove ISR function in vfe780 driver since it is never fired - bod > - Move csid_top_base to camss structure since we only have one csid > top block, and just need to get base once for csid top > - Add Vladimir's RB > - Remove prerequisite-patch-id in the cover letter since the changes > have been merged > - Add dtsi patch link for reference - Krzysztof > https://lore.kernel.org/all/20240807123333.2056518-1-quic_depengs@quicinc.com/ > - Link to v3: https://lore.kernel.org/all/20240709160656.31146-1-quic_depengs@quicinc.com/ > > v3: > - Rebased the change based on below change which will be merged firstly. > "Move camss version related defs in to resources" > Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/ > - Rebased the change based on Bryan's csiphy optimization change and add > these changes into this series, so that the new csiphy-3ph driver don't > need to add duplicate code. This has got Bryan's permission to add his > patches into this series. > - Refactor some changes based on the comments to move the random code to > patches where they are used. > - Remove the vfe780 irq function since it isn't doing the actual work. > - Add dt-binding for sm8550 camss driver. > Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/ > > v2: > - Update some commit messages > Link to V1: https://lore.kernel.org/all/20240320134227.16587-1-quic_depengs@quicinc.com/ > > v1: > SM8550 is a Qualcomm flagship SoC. This series adds support to > bring up the CSIPHY, CSID, VFE/RDI interfaces in SM8550. > > SM8550 provides > > - 3 x VFE, 3 RDI per VFE > - 2 x VFE Lite, 4 RDI per VFE > - 3 x CSID > - 2 x CSID Lite > - 8 x CSI PHY > > --- @Depeng. Can you please fix the following checkpatch splats. scripts/checkpatch.pl --strict *.patch total: 0 errors, 0 warnings, 0 checks, 20 lines checked 0001-media-qcom-camss-csiphy-3ph-Fix-trivial-indentation-.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 589 lines checked 0002-media-qcom-camss-csiphy-3ph-Remove-redundant-PHY-ini.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 40 lines checked 0003-media-qcom-camss-csiphy-3ph-Rename-struct.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 49 lines checked 0004-media-qcom-camss-csiphy-Add-an-init-callback-to-CSI-.patch has no obvious style problems and is ready for submission. total: 0 errors, 0 warnings, 0 checks, 82 lines checked 0005-media-qcom-camss-csiphy-3ph-Move-CSIPHY-variables-to.patch has no obvious style problems and is ready for submission. CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues #33: FILE: drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:45: +#define CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(offset, n) (offset + 0x4 * (n)) CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues #38: FILE: drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:49: +#define CSIPHY_3PH_CMN_CSI_COMMON_STATUSn(offset, n) ((offset + 0xb0) + 0x4 * (n)) total: 0 errors, 0 warnings, 2 checks, 157 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0006-media-qcom-camss-csiphy-3ph-Use-an-offset-variable-t.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 total: 0 errors, 1 warnings, 0 checks, 517 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0007-dt-bindings-media-camss-Add-qcom-sm8550-camss-bindin.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. CHECK: Alignment should match open parenthesis #255: FILE: drivers/media/platform/qcom/camss/camss-csid.c:616: + dev_info(csid->camss->dev, "CSID:%d HW Version = %u.%u.%u\n", + csid->id, hw_gen, hw_rev, hw_step); total: 0 errors, 0 warnings, 1 checks, 289 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0008-media-qcom-camss-csid-Move-common-code-into-csid-cor.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. CHECK: braces {} should be used on all arms of this statement #677: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:470: + if (output->buf[index]) { [...] + } else [...] CHECK: Unbalanced braces around else statement #682: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:475: + } else CHECK: Alignment should match open parenthesis #775: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:568: + if (output->state == VFE_OUTPUT_ON && + output->gen2.active_num < 2) { total: 0 errors, 0 warnings, 3 checks, 885 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0009-media-qcom-camss-vfe-Move-common-code-into-vfe-core.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 0 checks, 67 lines checked 0010-media-qcom-camss-Add-sm8550-compatible.patch has no obvious style problems and is ready for submission. 0010-media-qcom-camss-Add-sm8550-compatible.patch:6: drvier ==> driver total: 0 errors, 0 warnings, 0 checks, 253 lines checked 0011-media-qcom-camss-csiphy-3ph-Add-Gen2-v2.1.2-two-phas.patch has no obvious style problems and is ready for submission. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 CHECK: Please use a blank line after function/struct/union/enum declarations #146: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:100: +} +#define REG_UPDATE_RDI reg_update_rdi CHECK: Alignment should match open parenthesis #337: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:291: + writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i), + csid->base + CSID_BUF_DONE_IRQ_CLEAR); CHECK: Alignment should match open parenthesis #340: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.c:294: + writel(BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i), + csid->base + CSID_BUF_DONE_IRQ_MASK); CHECK: Please don't use multiple blank lines #412: FILE: drivers/media/platform/qcom/camss/camss-csid-gen3.h:21: + + CHECK: Unnecessary parentheses around camss->vfe[hw_id] #643: FILE: drivers/media/platform/qcom/camss/camss.c:1854: + vfe = &(camss->vfe[hw_id]); total: 0 errors, 1 warnings, 5 checks, 607 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0012-media-qcom-camss-Add-CSID-Gen3-support-for-sm8550.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 CHECK: Alignment should match open parenthesis #219: FILE: drivers/media/platform/qcom/camss/camss-vfe.c:684: + time = wait_for_completion_timeout(&vfe->reset_complete, + msecs_to_jiffies(VFE_RESET_TIMEOUT_MS)); CHECK: Unnecessary parentheses around camss->csid[hw_id] #415: FILE: drivers/media/platform/qcom/camss/camss.c:1973: + csid = &(camss->csid[hw_id]); total: 0 errors, 1 warnings, 2 checks, 388 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0013-media-qcom-camss-Add-support-for-VFE-hardware-versio.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --- bod