| Message ID | 20240929112908.99612-2-lujianhua000@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sm8250-xiaomi-elish: Add qca6390-pmu node | expand |
On Sun, Sep 29, 2024 at 07:29:07PM GMT, Jianhua Lu wrote: > Add wifi node and this wifi module is connected to pice port. Could you please add ath11k probe messages to the log? We might need to add an additional node with the calibration variant. > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > --- > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index ebea283f56ea..05a71462325c 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -680,6 +680,23 @@ &pcie0_phy { > status = "okay"; > }; > > +&pcieport0 { > + wifi@0 { > + compatible = "pci17cb,1101"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > + vddaon-supply = <&vreg_pmu_aon_0p59>; > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > + }; > +}; > + > &pm8150_gpios { > vol_up_n: vol-up-n-state { > pins = "gpio6"; > -- > 2.46.0 >
On Mon, Oct 07, 2024 at 12:02:34AM +0300, Dmitry Baryshkov wrote: > On Sun, Sep 29, 2024 at 07:29:07PM GMT, Jianhua Lu wrote: > > Add wifi node and this wifi module is connected to pice port. > > Could you please add ath11k probe messages to the log? We might need to > add an additional node with the calibration variant. > Hi, Dmitry. Do you mean that I should add ath11k probe message to the commit message? The following is ath11k probe message: [ 10.285469] ath11k_pci 0000:01:00.0: Adding to iommu group 12 [ 10.285637] ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned [ 10.285699] ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) [ 10.286003] ath11k_pci 0000:01:00.0: MSI vectors: 32 [ 10.286023] ath11k_pci 0000:01:00.0: qca6390 hw2.0 [ 10.652407] ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff [ 10.652429] ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id I'm not sure if it's necessary to add calibration variant because wifi works normally on this board without adding calibration variant.
On Mon, Oct 07, 2024 at 10:57:17AM GMT, Jianhua Lu wrote: > On Mon, Oct 07, 2024 at 12:02:34AM +0300, Dmitry Baryshkov wrote: > > On Sun, Sep 29, 2024 at 07:29:07PM GMT, Jianhua Lu wrote: > > > Add wifi node and this wifi module is connected to pice port. > > > > Could you please add ath11k probe messages to the log? We might need to > > add an additional node with the calibration variant. > > > Hi, Dmitry. Do you mean that I should add ath11k probe message to the commit message? > The following is ath11k probe message: > [ 10.285469] ath11k_pci 0000:01:00.0: Adding to iommu group 12 > [ 10.285637] ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned > [ 10.285699] ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) > [ 10.286003] ath11k_pci 0000:01:00.0: MSI vectors: 32 > [ 10.286023] ath11k_pci 0000:01:00.0: qca6390 hw2.0 > [ 10.652407] ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff > [ 10.652429] ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id > > I'm not sure if it's necessary to add calibration variant because wifi > works normally on this board without adding calibration variant. Added ath11k ML and corresponding maintainers to cc. Please cc them in future revisions of this patchset. If you were to send the next iteration of the series, please include the quoted log into the commit message. The board_id 0xff most likely requires calibration variant. Please consider adding one and submitting board.elf following the process specified at [1]. [1] https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index ebea283f56ea..05a71462325c 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -680,6 +680,23 @@ &pcie0_phy { status = "okay"; }; +&pcieport0 { + wifi@0 { + compatible = "pci17cb,1101"; + reg = <0x10000 0x0 0x0 0x0 0x0>; + + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; + vddaon-supply = <&vreg_pmu_aon_0p59>; + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; + }; +}; + &pm8150_gpios { vol_up_n: vol-up-n-state { pins = "gpio6";
Add wifi node and this wifi module is connected to pice port. Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> --- .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)