diff mbox series

ARM: mach-snapdragon: configure a larger default SYS_MALLOC_LEN for fastboot

Message ID 20241016-topic-sm8x50-bigger-malloc-len-v1-1-361b132ce7d4@linaro.org
State Accepted
Commit c75a535bd3e853d0a0842f9b180cb611455c433e
Headers show
Series ARM: mach-snapdragon: configure a larger default SYS_MALLOC_LEN for fastboot | expand

Commit Message

Neil Armstrong Oct. 16, 2024, 9:25 a.m. UTC
Fastboot is very hungry when it flashes larges chunks, and 8MiB
is way too small, allocate a much bigger size like other platforms
using Fastboot.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm/mach-snapdragon/Kconfig | 3 +++
 1 file changed, 3 insertions(+)


---
base-commit: d5cab0d6adc26ec1bbd45c2fed101184d04454ae
change-id: 20241016-topic-sm8x50-bigger-malloc-len-911bea6a047f

Best regards,

Comments

Caleb Connolly Oct. 17, 2024, 3:24 p.m. UTC | #1
On 16/10/2024 11:25, Neil Armstrong wrote:
> Fastboot is very hungry when it flashes larges chunks, and 8MiB
> is way too small, allocate a much bigger size like other platforms
> using Fastboot.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Confirmed on RB1 (1GiB total RAM) that this doesn't cause any issues.

Tested-by: Caleb Connolly <caleb.connolly@linaro.org> # rb1
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>

> ---
>   arch/arm/mach-snapdragon/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
> index 536960b83c3..2985d9d3ca4 100644
> --- a/arch/arm/mach-snapdragon/Kconfig
> +++ b/arch/arm/mach-snapdragon/Kconfig
> @@ -11,6 +11,9 @@ config SYS_VENDOR
>   	  Based on this option board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD>
>   	  will be used as the custom board directory.
>   
> +config SYS_MALLOC_LEN
> +	default 0x10000000
> +
>   config SYS_MALLOC_F_LEN
>   	default 0x2000
>   
> 
> ---
> base-commit: d5cab0d6adc26ec1bbd45c2fed101184d04454ae
> change-id: 20241016-topic-sm8x50-bigger-malloc-len-911bea6a047f
> 
> Best regards,
Caleb Connolly Nov. 14, 2024, 6:13 p.m. UTC | #2
On Wed, 16 Oct 2024 11:25:32 +0200, Neil Armstrong wrote:
> Fastboot is very hungry when it flashes larges chunks, and 8MiB
> is way too small, allocate a much bigger size like other platforms
> using Fastboot.
> 
> 

Applied, thanks!

[1/1] ARM: mach-snapdragon: configure a larger default SYS_MALLOC_LEN for fastboot
      commit: 325e210fc0e47871e13a497c2c6883bd9a17ad5d

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/mach-snapdragon/Kconfig b/arch/arm/mach-snapdragon/Kconfig
index 536960b83c3..2985d9d3ca4 100644
--- a/arch/arm/mach-snapdragon/Kconfig
+++ b/arch/arm/mach-snapdragon/Kconfig
@@ -11,6 +11,9 @@  config SYS_VENDOR
 	  Based on this option board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD>
 	  will be used as the custom board directory.
 
+config SYS_MALLOC_LEN
+	default 0x10000000
+
 config SYS_MALLOC_F_LEN
 	default 0x2000