mbox series

[0/2] pinctrl: qcom: Introduce pinctrl for SM8750

Message ID 20241021230414.2632428-1-quic_molvera@quicinc.com
Headers show
Series pinctrl: qcom: Introduce pinctrl for SM8750 | expand

Message

Melody Olvera Oct. 21, 2024, 11:04 p.m. UTC 
Add pinctrl block for the SM8750 SoC.

The Qualcomm Technologies, Inc. SM8750 SoC is the latest in the line of
consumer mobile device SoCs. See more at:
https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/images/company/news-media/media-center/press-kits/snapdragon-summit-2024/day-1/documents/Snapdragon8EliteProductBrief.pdf

Melody Olvera (2):
  dt-bindings: pinctrl: qcom: Add sm8750 pinctrl
  pinctrl: qcom: Add sm8750 pinctrl driver

 .../bindings/pinctrl/qcom,sm8750-tlmm.yaml    |  138 ++
 drivers/pinctrl/qcom/Kconfig.msm              |    8 +
 drivers/pinctrl/qcom/Makefile                 |    1 +
 drivers/pinctrl/qcom/pinctrl-sm8750.c         | 1734 +++++++++++++++++
 4 files changed, 1881 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8750.c


base-commit: 63b3ff03d91ae8f875fe8747c781a521f78cde17

Comments

Bjorn Andersson Oct. 23, 2024, 3:22 a.m. UTC | #1 
On Mon, Oct 21, 2024 at 04:04:13PM GMT, Melody Olvera wrote:
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml
[..]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    tlmm: pinctrl@f100000 {
> +        compatible = "qcom,sm8750-tlmm";
> +        reg = <0x0f100000 0x300000>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        gpio-ranges = <&tlmm 0 0 211>;

I know it's just an example, but I think this number should be 216.
Please also correct it in the dtsi, where you made it 220.

Regards,
Bjorn

> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> +
> +        gpio-wo-state {
> +            pins = "gpio1";
> +            function = "gpio";
> +        };
> +
> +        uart-w-state {
> +            rx-pins {
> +                pins = "gpio60";
> +                function = "qup1_se7";
> +                bias-pull-up;
> +            };
> +
> +            tx-pins {
> +                pins = "gpio61";
> +                function = "qup1_se7";
> +                bias-disable;
> +            };
> +        };
> +    };
> +...
> -- 
> 2.46.1
>
Krzysztof Kozlowski Oct. 23, 2024, 8:16 a.m. UTC | #2 
On Mon, Oct 21, 2024 at 04:04:13PM -0700, Melody Olvera wrote:
> Add documentation for the Qualcomm sm8750 tlmm.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  .../bindings/pinctrl/qcom,sm8750-tlmm.yaml    | 138 ++++++++++++++++++
>  1 file changed, 138 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml
> 

With issue pointed out by Bjorn:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Melody Olvera Oct. 23, 2024, 6:16 p.m. UTC | #3 
On 10/22/2024 8:22 PM, Bjorn Andersson wrote:
> On Mon, Oct 21, 2024 at 04:04:13PM GMT, Melody Olvera wrote:
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml
> [..]
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    tlmm: pinctrl@f100000 {
>> +        compatible = "qcom,sm8750-tlmm";
>> +        reg = <0x0f100000 0x300000>;
>> +        gpio-controller;
>> +        #gpio-cells = <2>;
>> +        gpio-ranges = <&tlmm 0 0 211>;
> I know it's just an example, but I think this number should be 216.
> Please also correct it in the dtsi, where you made it 220.

Will do.

>> +        interrupt-controller;
>> +        #interrupt-cells = <2>;
>> +        interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
>> +
>> +        gpio-wo-state {
>> +            pins = "gpio1";
>> +            function = "gpio";
>> +        };
>> +
>> +        uart-w-state {
>> +            rx-pins {
>> +                pins = "gpio60";
>> +                function = "qup1_se7";
>> +                bias-pull-up;
>> +            };
>> +
>> +            tx-pins {
>> +                pins = "gpio61";
>> +                function = "qup1_se7";
>> +                bias-disable;
>> +            };
>> +        };
>> +    };
>> +...
>> -- 
>> 2.46.1
>>