diff mbox series

disk: Mark static functions in part_efi.c

Message ID 20241026080555.135472-1-ilias.apalodimas@linaro.org
State Accepted
Commit 4ea1deb4bfdbda6e66cbb8a10967008a35cef1ef
Headers show
Series disk: Mark static functions in part_efi.c | expand

Commit Message

Ilias Apalodimas Oct. 26, 2024, 8:05 a.m. UTC
Mark all the functions that are only defined locally as static and
quiesce W=1 warnings

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 disk/part_efi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heinrich Schuchardt Oct. 28, 2024, 6:11 a.m. UTC | #1
On 10/26/24 10:05, Ilias Apalodimas wrote:
> Mark all the functions that are only defined locally as static and
> quiesce W=1 warnings
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>   disk/part_efi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index 7f04c6ecd69e..cb2fcc2bab2d 100644
> --- a/disk/part_efi.c
> +++ b/disk/part_efi.c
> @@ -216,7 +216,7 @@ int get_disk_guid(struct blk_desc *desc, char *guid)
>   	return 0;
>   }
>
> -void part_print_efi(struct blk_desc *desc)
> +static void part_print_efi(struct blk_desc *desc)
>   {
>   	ALLOC_CACHE_ALIGN_BUFFER_PAD(gpt_header, gpt_head, 1, desc->blksz);
>   	gpt_entry *gpt_pte = NULL;
> @@ -258,7 +258,7 @@ void part_print_efi(struct blk_desc *desc)
>   	return;
>   }
>
> -int part_get_info_efi(struct blk_desc *desc, int part,
> +static int part_get_info_efi(struct blk_desc *desc, int part,
>   		      struct disk_partition *info)
>   {
>   	ALLOC_CACHE_ALIGN_BUFFER_PAD(gpt_header, gpt_head, 1, desc->blksz);

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Tom Rini Oct. 29, 2024, 10:28 p.m. UTC | #2
On Sat, 26 Oct 2024 11:05:53 +0300, Ilias Apalodimas wrote:

> Mark all the functions that are only defined locally as static and
> quiesce W=1 warnings
> 
> 

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/disk/part_efi.c b/disk/part_efi.c
index 7f04c6ecd69e..cb2fcc2bab2d 100644
--- a/disk/part_efi.c
+++ b/disk/part_efi.c
@@ -216,7 +216,7 @@  int get_disk_guid(struct blk_desc *desc, char *guid)
 	return 0;
 }
 
-void part_print_efi(struct blk_desc *desc)
+static void part_print_efi(struct blk_desc *desc)
 {
 	ALLOC_CACHE_ALIGN_BUFFER_PAD(gpt_header, gpt_head, 1, desc->blksz);
 	gpt_entry *gpt_pte = NULL;
@@ -258,7 +258,7 @@  void part_print_efi(struct blk_desc *desc)
 	return;
 }
 
-int part_get_info_efi(struct blk_desc *desc, int part,
+static int part_get_info_efi(struct blk_desc *desc, int part,
 		      struct disk_partition *info)
 {
 	ALLOC_CACHE_ALIGN_BUFFER_PAD(gpt_header, gpt_head, 1, desc->blksz);