Message ID | 20241103192315.288743-1-linux@treblig.org |
---|---|
State | New |
Headers | show |
Series | media: platform: samsung: s5p-jpeg: Remove deadcode | expand |
Hi David, Thank you for the patch. On 11/3/24 20:23, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > exynos3250_jpeg_operating() has been unused since it was added in 2014's > commit 3246fdaa0ac2 ("[media] s5p-jpeg: Add support for Exynos3250 SoC") > > exynos4_jpeg_get_fifo_status(), exynos4_jpeg_get_frame_size(), and > exynos4_jpeg_set_timer_count() have been unused since they were added by > commit 80529ae5c137 ("[media] s5p-jpeg: JPEG codec") > > Remove them. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > .../samsung/s5p-jpeg/jpeg-hw-exynos3250.c | 5 ----- > .../samsung/s5p-jpeg/jpeg-hw-exynos3250.h | 1 - > .../samsung/s5p-jpeg/jpeg-hw-exynos4.c | 19 ------------------- > .../samsung/s5p-jpeg/jpeg-hw-exynos4.h | 4 ---- > 4 files changed, 29 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c > index 637a5104d948..6657d294c10a 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c > @@ -427,11 +427,6 @@ void exynos3250_jpeg_clear_int_status(void __iomem *regs, > writel(value, regs + EXYNOS3250_JPGINTST); > } > > -unsigned int exynos3250_jpeg_operating(void __iomem *regs) > -{ > - return readl(regs + S5P_JPGOPR) & EXYNOS3250_JPGOPR_MASK; > -} > - > unsigned int exynos3250_jpeg_compressed_size(void __iomem *regs) > { > return readl(regs + EXYNOS3250_JPGCNT) & EXYNOS3250_JPGCNT_MASK; > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h > index 15af928fad76..709c61ae322c 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h > @@ -45,7 +45,6 @@ void exynos3250_jpeg_rstart(void __iomem *regs); > unsigned int exynos3250_jpeg_get_int_status(void __iomem *regs); > void exynos3250_jpeg_clear_int_status(void __iomem *regs, > unsigned int value); > -unsigned int exynos3250_jpeg_operating(void __iomem *regs); > unsigned int exynos3250_jpeg_compressed_size(void __iomem *regs); > void exynos3250_jpeg_dec_stream_size(void __iomem *regs, unsigned int size); > void exynos3250_jpeg_dec_scaling_ratio(void __iomem *regs, unsigned int sratio); > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c > index 0828cfa783fe..479288fc8c77 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c > @@ -185,11 +185,6 @@ unsigned int exynos4_jpeg_get_int_status(void __iomem *base) > return readl(base + EXYNOS4_INT_STATUS_REG); > } > > -unsigned int exynos4_jpeg_get_fifo_status(void __iomem *base) > -{ > - return readl(base + EXYNOS4_FIFO_STATUS_REG); > -} > - > void exynos4_jpeg_set_huf_table_enable(void __iomem *base, int value) > { > unsigned int reg; > @@ -300,22 +295,8 @@ void exynos4_jpeg_set_dec_bitstream_size(void __iomem *base, unsigned int size) > writel(size, base + EXYNOS4_BITSTREAM_SIZE_REG); > } > > -void exynos4_jpeg_get_frame_size(void __iomem *base, > - unsigned int *width, unsigned int *height) > -{ > - *width = (readl(base + EXYNOS4_DECODE_XY_SIZE_REG) & > - EXYNOS4_DECODED_SIZE_MASK); > - *height = (readl(base + EXYNOS4_DECODE_XY_SIZE_REG) >> 16) & > - EXYNOS4_DECODED_SIZE_MASK; > -} > - > unsigned int exynos4_jpeg_get_frame_fmt(void __iomem *base) > { > return readl(base + EXYNOS4_DECODE_IMG_FMT_REG) & > EXYNOS4_JPEG_DECODED_IMG_FMT_MASK; > } > - > -void exynos4_jpeg_set_timer_count(void __iomem *base, unsigned int size) > -{ > - writel(size, base + EXYNOS4_INT_TIMER_COUNT_REG); > -} > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h > index 3e2887526960..b941cc89e4ba 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h > @@ -35,10 +35,6 @@ void exynos4_jpeg_select_dec_h_tbl(void __iomem *base, char c, char x); > void exynos4_jpeg_set_encode_hoff_cnt(void __iomem *base, unsigned int fmt); > void exynos4_jpeg_set_dec_bitstream_size(void __iomem *base, unsigned int size); > unsigned int exynos4_jpeg_get_stream_size(void __iomem *base); > -void exynos4_jpeg_get_frame_size(void __iomem *base, > - unsigned int *width, unsigned int *height); > unsigned int exynos4_jpeg_get_frame_fmt(void __iomem *base); > -unsigned int exynos4_jpeg_get_fifo_status(void __iomem *base); > -void exynos4_jpeg_set_timer_count(void __iomem *base, unsigned int size); > > #endif /* JPEG_HW_EXYNOS4_H_ */ Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c index 637a5104d948..6657d294c10a 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.c @@ -427,11 +427,6 @@ void exynos3250_jpeg_clear_int_status(void __iomem *regs, writel(value, regs + EXYNOS3250_JPGINTST); } -unsigned int exynos3250_jpeg_operating(void __iomem *regs) -{ - return readl(regs + S5P_JPGOPR) & EXYNOS3250_JPGOPR_MASK; -} - unsigned int exynos3250_jpeg_compressed_size(void __iomem *regs) { return readl(regs + EXYNOS3250_JPGCNT) & EXYNOS3250_JPGCNT_MASK; diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h index 15af928fad76..709c61ae322c 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos3250.h @@ -45,7 +45,6 @@ void exynos3250_jpeg_rstart(void __iomem *regs); unsigned int exynos3250_jpeg_get_int_status(void __iomem *regs); void exynos3250_jpeg_clear_int_status(void __iomem *regs, unsigned int value); -unsigned int exynos3250_jpeg_operating(void __iomem *regs); unsigned int exynos3250_jpeg_compressed_size(void __iomem *regs); void exynos3250_jpeg_dec_stream_size(void __iomem *regs, unsigned int size); void exynos3250_jpeg_dec_scaling_ratio(void __iomem *regs, unsigned int sratio); diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c index 0828cfa783fe..479288fc8c77 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.c @@ -185,11 +185,6 @@ unsigned int exynos4_jpeg_get_int_status(void __iomem *base) return readl(base + EXYNOS4_INT_STATUS_REG); } -unsigned int exynos4_jpeg_get_fifo_status(void __iomem *base) -{ - return readl(base + EXYNOS4_FIFO_STATUS_REG); -} - void exynos4_jpeg_set_huf_table_enable(void __iomem *base, int value) { unsigned int reg; @@ -300,22 +295,8 @@ void exynos4_jpeg_set_dec_bitstream_size(void __iomem *base, unsigned int size) writel(size, base + EXYNOS4_BITSTREAM_SIZE_REG); } -void exynos4_jpeg_get_frame_size(void __iomem *base, - unsigned int *width, unsigned int *height) -{ - *width = (readl(base + EXYNOS4_DECODE_XY_SIZE_REG) & - EXYNOS4_DECODED_SIZE_MASK); - *height = (readl(base + EXYNOS4_DECODE_XY_SIZE_REG) >> 16) & - EXYNOS4_DECODED_SIZE_MASK; -} - unsigned int exynos4_jpeg_get_frame_fmt(void __iomem *base) { return readl(base + EXYNOS4_DECODE_IMG_FMT_REG) & EXYNOS4_JPEG_DECODED_IMG_FMT_MASK; } - -void exynos4_jpeg_set_timer_count(void __iomem *base, unsigned int size) -{ - writel(size, base + EXYNOS4_INT_TIMER_COUNT_REG); -} diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h index 3e2887526960..b941cc89e4ba 100644 --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-hw-exynos4.h @@ -35,10 +35,6 @@ void exynos4_jpeg_select_dec_h_tbl(void __iomem *base, char c, char x); void exynos4_jpeg_set_encode_hoff_cnt(void __iomem *base, unsigned int fmt); void exynos4_jpeg_set_dec_bitstream_size(void __iomem *base, unsigned int size); unsigned int exynos4_jpeg_get_stream_size(void __iomem *base); -void exynos4_jpeg_get_frame_size(void __iomem *base, - unsigned int *width, unsigned int *height); unsigned int exynos4_jpeg_get_frame_fmt(void __iomem *base); -unsigned int exynos4_jpeg_get_fifo_status(void __iomem *base); -void exynos4_jpeg_set_timer_count(void __iomem *base, unsigned int size); #endif /* JPEG_HW_EXYNOS4_H_ */