| Message ID | 20241028-upstream_s32cc_gmac-v4-5-03618f10e3e2@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45 | expand |
On Mon, Oct 28, 2024 at 09:24:47PM +0100, Jan Petrous via B4 Relay wrote: > From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> > > Utilize a new helper function rgmii_clock(). > > Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > index ec924c6c76c6..5080891c33e0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > @@ -181,24 +181,19 @@ static void dwc_qos_remove(struct platform_device *pdev) > static void tegra_eqos_fix_speed(void *priv, unsigned int speed, unsigned int mode) > { > struct tegra_eqos *eqos = priv; > - unsigned long rate = 125000000; > + long rate = 125000000; > bool needs_calibration = false; > u32 value; > int err; Hi Jan, As it seems that there will be another revision anyway, please update the above so that the local variable declarations are in reverse xmas tree order - longest line to shortest. Likewise in s32_dwmac_probe() in the patch "net: stmmac: dwmac-s32: add basic NXP S32G/S32R glue driver". ...
On Tue, Nov 05, 2024 at 01:42:06PM +0000, Simon Horman wrote: > On Mon, Oct 28, 2024 at 09:24:47PM +0100, Jan Petrous via B4 Relay wrote: > > From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> > > > > Utilize a new helper function rgmii_clock(). > > > > Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > > index ec924c6c76c6..5080891c33e0 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c > > @@ -181,24 +181,19 @@ static void dwc_qos_remove(struct platform_device *pdev) > > static void tegra_eqos_fix_speed(void *priv, unsigned int speed, unsigned int mode) > > { > > struct tegra_eqos *eqos = priv; > > - unsigned long rate = 125000000; > > + long rate = 125000000; > > bool needs_calibration = false; > > u32 value; > > int err; > > Hi Jan, > > As it seems that there will be another revision anyway, > please update the above so that the local variable declarations > are in reverse xmas tree order - longest line to shortest. > > Likewise in s32_dwmac_probe() in the patch > "net: stmmac: dwmac-s32: add basic NXP S32G/S32R glue driver". > Hi Simon, thanks for review, I will add those formating fixes in v5. BR. /Jan
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c index ec924c6c76c6..5080891c33e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c @@ -181,24 +181,19 @@ static void dwc_qos_remove(struct platform_device *pdev) static void tegra_eqos_fix_speed(void *priv, unsigned int speed, unsigned int mode) { struct tegra_eqos *eqos = priv; - unsigned long rate = 125000000; + long rate = 125000000; bool needs_calibration = false; u32 value; int err; switch (speed) { case SPEED_1000: - needs_calibration = true; - rate = 125000000; - break; - case SPEED_100: needs_calibration = true; - rate = 25000000; - break; + fallthrough; case SPEED_10: - rate = 2500000; + rate = rgmii_clock(speed); break; default: