| Message ID | 20241118-b4-max17042-v3-0-9bcaeda42a06@gmail.com |
|---|---|
| Headers | show |
| Series | power: supply: max17042: cleanup and more features | expand |
Hi Dzmitry, On 18-Nov-24 11:09 AM, Dzmitry Sankouski wrote: > Fuelgauge blocks often are incorporated in bigger chip, > which may use only 1 line for interrupts. Make interrupt > shared. > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/power/supply/max17042_battery.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c > index 496c3e1f2ee6..99bf6915aa23 100644 > --- a/drivers/power/supply/max17042_battery.c > +++ b/drivers/power/supply/max17042_battery.c > @@ -1103,14 +1103,7 @@ static int max17042_probe(struct i2c_client *client) > } > > if (client->irq) { > - unsigned int flags = IRQF_ONESHOT; > - > - /* > - * On ACPI systems the IRQ may be handled by ACPI-event code, > - * so we need to share (if the ACPI code is willing to share). > - */ > - if (acpi_id) > - flags |= IRQF_SHARED | IRQF_PROBE_SHARED; > + unsigned int flags = IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; > > ret = devm_request_threaded_irq(&client->dev, client->irq, > NULL, >
Fuelgauge blocks often are incorporated in bigger chip, which may use only 1 line for interrupts. Shared-irq handles that case by requesting irq as shared. Maxim PMICs may include fuel gauge with additional features, which is out of single Linux power supply driver scope. For example, in max77705 PMIC fuelgauge has additional registers, like IIN_REG, VSYS_REG, ISYS_REG. Those needed to measure PMIC input current, system voltage and current respectively. Those measurements cannot be bound to any of fuelgauge properties. The solution here add and option to use max17042 driver as a MFD sub device, thus allowing any additional functionality be implemented as another sub device. This will help to reduce code duplication in MFD fuel gauge drivers. Make max17042 interrupt shared, and add platform driver version. Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- Changes in v3: - pass dev pointer to probe - Link to v2: https://lore.kernel.org/r/20241108-b4-max17042-v2-0-f058f7a16bab@gmail.com Changes in v2: - drop NACKed commits - make shared interrupts unconditionally - rework descriptions - add platform driver version - Link to v1: https://lore.kernel.org/r/20241109-b4-max17042-v1-0-9e2b07e54e76@gmail.com --- Dzmitry Sankouski (2): power: supply: max17042: make interrupt shared power: supply: max17042: add platform driver variant drivers/power/supply/max17042_battery.c | 123 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 91 insertions(+), 32 deletions(-) --- base-commit: ae58226b89ac0cffa05ba7357733776542e40216 change-id: 20241108-b4-max17042-9306fc75afae Best regards,