| Message ID | 20241120095428.1122935-3-quic_chejiang@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add qcom,product-variant properties in Qualcomm | expand |
On 20/11/2024 10:54, Cheng Jiang wrote:
> Add QCA6698 qcom,qca6698-bt compatible strings.
We see this from the diff. Say something useful...
Best regards,
Krzysztof
On 21/11/2024 05:12, Cheng Jiang wrote: > Hi Dmitry, > > On 11/20/2024 6:44 PM, Dmitry Baryshkov wrote: >> On Wed, Nov 20, 2024 at 05:54:26PM +0800, Cheng Jiang wrote: >>> Add QCA6698 qcom,qca6698-bt compatible strings. >> >> Why? Is it the same chip as WCN6855 or a different chip? Is it >> completely compatible? >> > They are different chips. But it's compatible with WCN6855. That's what the commit msg is for. Do not say what is obvious, visible from the diff. Best regards, Krzysztof
On Thu, 21 Nov 2024 at 06:12, Cheng Jiang <quic_chejiang@quicinc.com> wrote: > > Hi Dmitry, > > On 11/20/2024 6:44 PM, Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 05:54:26PM +0800, Cheng Jiang wrote: > >> Add QCA6698 qcom,qca6698-bt compatible strings. > > > > Why? Is it the same chip as WCN6855 or a different chip? Is it > > completely compatible? > > > They are different chips. But it's compatible with WCN6855. So, do we really need new compat? Will/can it use the same firmware? > >> > >> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > >> --- > >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >> index 9019fe7bcdc6..527f947289af 100644 > >> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >> @@ -18,6 +18,7 @@ properties: > >> enum: > >> - qcom,qca2066-bt > >> - qcom,qca6174-bt > >> + - qcom,qca6698-bt > >> - qcom,qca9377-bt > >> - qcom,wcn3988-bt > >> - qcom,wcn3990-bt > >> @@ -175,6 +176,7 @@ allOf: > >> compatible: > >> contains: > >> enum: > >> + - qcom,qca6698-bt > >> - qcom,wcn6855-bt > >> then: > >> required: > >> -- > >> 2.25.1 > >> > > >
Hi Dmitry, On 11/22/2024 12:28 AM, Dmitry Baryshkov wrote: > On Thu, 21 Nov 2024 at 06:12, Cheng Jiang <quic_chejiang@quicinc.com> wrote: >> >> Hi Dmitry, >> >> On 11/20/2024 6:44 PM, Dmitry Baryshkov wrote: >>> On Wed, Nov 20, 2024 at 05:54:26PM +0800, Cheng Jiang wrote: >>>> Add QCA6698 qcom,qca6698-bt compatible strings. >>> >>> Why? Is it the same chip as WCN6855 or a different chip? Is it >>> completely compatible? >>> >> They are different chips. But it's compatible with WCN6855. > > So, do we really need new compat? Will/can it use the same firmware? We need to use a different firmware. Let me check if using "firmware-name" allows us to omit the new soc type.
On 11/22/2024 9:55 AM, Cheng Jiang (IOE) wrote: > Hi Dmitry, > > On 11/22/2024 12:28 AM, Dmitry Baryshkov wrote: >> On Thu, 21 Nov 2024 at 06:12, Cheng Jiang <quic_chejiang@quicinc.com> wrote: >>> >>> Hi Dmitry, >>> >>> On 11/20/2024 6:44 PM, Dmitry Baryshkov wrote: >>>> On Wed, Nov 20, 2024 at 05:54:26PM +0800, Cheng Jiang wrote: >>>>> Add QCA6698 qcom,qca6698-bt compatible strings. >>>> >>>> Why? Is it the same chip as WCN6855 or a different chip? Is it >>>> completely compatible? >>>> >>> They are different chips. But it's compatible with WCN6855. >> >> So, do we really need new compat? Will/can it use the same firmware? > We need to use a different firmware. Let me check if using > "firmware-name" allows us to omit the new soc type. > From the driver's perspective, the only change is the need to load a > different firmware. > it is a good idea to use existing optional property firmware-name to specify RAMPATCH additionally. that would simplify logic a lot for your requirements. (^^)(^^). >> >>>>> >>>>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> >>>>> --- >>>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>> index 9019fe7bcdc6..527f947289af 100644 >>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>> @@ -18,6 +18,7 @@ properties: >>>>> enum: >>>>> - qcom,qca2066-bt >>>>> - qcom,qca6174-bt >>>>> + - qcom,qca6698-bt >>>>> - qcom,qca9377-bt >>>>> - qcom,wcn3988-bt >>>>> - qcom,wcn3990-bt >>>>> @@ -175,6 +176,7 @@ allOf: >>>>> compatible: >>>>> contains: >>>>> enum: >>>>> + - qcom,qca6698-bt >>>>> - qcom,wcn6855-bt >>>>> then: >>>>> required: >>>>> -- >>>>> 2.25.1 >>>>> >>>> >>> >> >> >
On Fri, 22 Nov 2024 at 03:55, Cheng Jiang (IOE) <quic_chejiang@quicinc.com> wrote: > > Hi Dmitry, > > On 11/22/2024 12:28 AM, Dmitry Baryshkov wrote: > > On Thu, 21 Nov 2024 at 06:12, Cheng Jiang <quic_chejiang@quicinc.com> wrote: > >> > >> Hi Dmitry, > >> > >> On 11/20/2024 6:44 PM, Dmitry Baryshkov wrote: > >>> On Wed, Nov 20, 2024 at 05:54:26PM +0800, Cheng Jiang wrote: > >>>> Add QCA6698 qcom,qca6698-bt compatible strings. > >>> > >>> Why? Is it the same chip as WCN6855 or a different chip? Is it > >>> completely compatible? > >>> > >> They are different chips. But it's compatible with WCN6855. > > > > So, do we really need new compat? Will/can it use the same firmware? > We need to use a different firmware. Need because of the product needs or need because of the existing firmware not working with the chip? Wait... your WiFi colleagues were more helpful and they wrote that "it has different RF, IPA, thermal, RAM size and etc, so new firmware files used." ([1]). Please include that information in your commit messages too to let reviewers understand what is going on. [1] https://lore.kernel.org/linux-arm-msm/20241024002514.92290-1-quic_miaoqing@quicinc.com/ > Let me check if using > "firmware-name" allows us to omit the new soc type. > From the driver's perspective, the only change is the need to load a > different firmware. If you want to emphasise that it is not just WCN6855, extend schema to use fallback compatibles: compat = "qcom,qca6698-bt", "qcom,wcn6855-bt"; No driver changes are necessary with this approach. > > > > >>>> > >>>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > >>>> --- > >>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ > >>>> 1 file changed, 2 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >>>> index 9019fe7bcdc6..527f947289af 100644 > >>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > >>>> @@ -18,6 +18,7 @@ properties: > >>>> enum: > >>>> - qcom,qca2066-bt > >>>> - qcom,qca6174-bt > >>>> + - qcom,qca6698-bt > >>>> - qcom,qca9377-bt > >>>> - qcom,wcn3988-bt > >>>> - qcom,wcn3990-bt > >>>> @@ -175,6 +176,7 @@ allOf: > >>>> compatible: > >>>> contains: > >>>> enum: > >>>> + - qcom,qca6698-bt > >>>> - qcom,wcn6855-bt > >>>> then: > >>>> required: > >>>> -- > >>>> 2.25.1 > >>>> > >>> > >> > > > > > -- With best wishes Dmitry
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 9019fe7bcdc6..527f947289af 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -18,6 +18,7 @@ properties: enum: - qcom,qca2066-bt - qcom,qca6174-bt + - qcom,qca6698-bt - qcom,qca9377-bt - qcom,wcn3988-bt - qcom,wcn3990-bt @@ -175,6 +176,7 @@ allOf: compatible: contains: enum: + - qcom,qca6698-bt - qcom,wcn6855-bt then: required:
Add QCA6698 qcom,qca6698-bt compatible strings. Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ 1 file changed, 2 insertions(+)