| Message ID | 5252a28531deaee67af1edd8e72d45ca57783464.1733505542.git.Ryan.Wanner@microchip.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for SAMA7D65 | expand |
On 06.12.2024 21:59, Ryan.Wanner@microchip.com wrote: > From: Dharma Balasubiramani <dharma.b@microchip.com> > > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. > > Export MCK3 and MCK5 to be accessed and referenced in DT to assign to > the clocks property for sama7d65 SoC. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- > .../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ > include/dt-bindings/clock/at91.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > index c9eb60776b4d..885d47dd5724 100644 > --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > @@ -43,6 +43,7 @@ properties: > - atmel,sama5d4-pmc > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > - const: syscon > > @@ -90,6 +91,7 @@ allOf: > enum: > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > then: > properties: > diff --git a/include/dt-bindings/clock/at91.h b/include/dt-bindings/clock/at91.h > index 6ede88c3992d..e37f1b9cdabf 100644 > --- a/include/dt-bindings/clock/at91.h > +++ b/include/dt-bindings/clock/at91.h > @@ -42,6 +42,10 @@ > #define PMC_PLLADIV2 (PMC_MAIN + 11) > #define PMC_LVDSPLL (PMC_MAIN + 12) > > +/* SAMA7D65 */ > +#define PMC_MCK3 (PMC_MAIN + 13) > +#define PMC_MCK5 (PMC_MAIN + 14) Spaces here --------^ instead of tabs . I'll adjust it while applying. Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev> > + > #ifndef AT91_PMC_MOSCS > #define AT91_PMC_MOSCS 0 /* MOSCS Flag */ > #define AT91_PMC_LOCKA 1 /* PLLA Lock */
On Fri, Dec 06, 2024 at 12:59:52PM -0700, Ryan.Wanner@microchip.com wrote: > From: Dharma Balasubiramani <dharma.b@microchip.com> > > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. > > Export MCK3 and MCK5 to be accessed and referenced in DT to assign to > the clocks property for sama7d65 SoC. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> Missing Conor's ack.
On 12/10/24 09:46, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Fri, Dec 06, 2024 at 12:59:52PM -0700, Ryan.Wanner@microchip.com wrote: >> From: Dharma Balasubiramani <dharma.b@microchip.com> >> >> Add the `microchip,sama7d65-pmc` compatible string to the existing binding, >> since the SAMA7D65 PMC shares the same properties and clock requirements >> as the SAMA7G5. >> >> Export MCK3 and MCK5 to be accessed and referenced in DT to assign to >> the clocks property for sama7d65 SoC. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > > Missing Conor's ack. I removed the ack because I have changed the original patch that was acked. Should the ack not have been removed even though the original patch as been changed?
On Wed, Dec 11, 2024 at 08:25:32AM -0700, Ryan Wanner wrote: > On 12/10/24 09:46, Rob Herring wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Fri, Dec 06, 2024 at 12:59:52PM -0700, Ryan.Wanner@microchip.com wrote: > >> From: Dharma Balasubiramani <dharma.b@microchip.com> > >> > >> Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > >> since the SAMA7D65 PMC shares the same properties and clock requirements > >> as the SAMA7G5. > >> > >> Export MCK3 and MCK5 to be accessed and referenced in DT to assign to > >> the clocks property for sama7d65 SoC. > >> > >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > >> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > > > > Missing Conor's ack. > I removed the ack because I have changed the original patch that was > acked. Should the ack not have been removed even though the original > patch as been changed? Nothing in changelog says about changes to this patch. Nothing also mentions dropping acks. Please read: https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On Fri, Dec 06, 2024 at 12:59:52PM -0700, Ryan.Wanner@microchip.com wrote: > From: Dharma Balasubiramani <dharma.b@microchip.com> > > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. > > Export MCK3 and MCK5 to be accessed and referenced in DT to assign to > the clocks property for sama7d65 SoC. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml index c9eb60776b4d..885d47dd5724 100644 --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml @@ -43,6 +43,7 @@ properties: - atmel,sama5d4-pmc - microchip,sam9x60-pmc - microchip,sam9x7-pmc + - microchip,sama7d65-pmc - microchip,sama7g5-pmc - const: syscon @@ -90,6 +91,7 @@ allOf: enum: - microchip,sam9x60-pmc - microchip,sam9x7-pmc + - microchip,sama7d65-pmc - microchip,sama7g5-pmc then: properties: diff --git a/include/dt-bindings/clock/at91.h b/include/dt-bindings/clock/at91.h index 6ede88c3992d..e37f1b9cdabf 100644 --- a/include/dt-bindings/clock/at91.h +++ b/include/dt-bindings/clock/at91.h @@ -42,6 +42,10 @@ #define PMC_PLLADIV2 (PMC_MAIN + 11) #define PMC_LVDSPLL (PMC_MAIN + 12) +/* SAMA7D65 */ +#define PMC_MCK3 (PMC_MAIN + 13) +#define PMC_MCK5 (PMC_MAIN + 14) + #ifndef AT91_PMC_MOSCS #define AT91_PMC_MOSCS 0 /* MOSCS Flag */ #define AT91_PMC_LOCKA 1 /* PLLA Lock */