diff mbox series

[03/13] tests/tcg/plugins/insn: remove unused callback parameter

Message ID 20241217010707.2557258-4-pierrick.bouvier@linaro.org
State Superseded
Headers show
Series Fix 32-bit build for plugins | expand

Commit Message

Pierrick Bouvier Dec. 17, 2024, 1:06 a.m. UTC 
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 tests/tcg/plugins/insn.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Richard Henderson Dec. 17, 2024, 3:17 p.m. UTC | #1 
On 12/16/24 19:06, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   tests/tcg/plugins/insn.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c
> index baf2d07205d..0c723cb9ed8 100644
> --- a/tests/tcg/plugins/insn.c
> +++ b/tests/tcg/plugins/insn.c
> @@ -150,10 +150,8 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
>               qemu_plugin_register_vcpu_insn_exec_inline_per_vcpu(
>                   insn, QEMU_PLUGIN_INLINE_ADD_U64, insn_count, 1);
>           } else {
> -            uint64_t vaddr = qemu_plugin_insn_vaddr(insn);
>               qemu_plugin_register_vcpu_insn_exec_cb(
> -                insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS,
> -                GUINT_TO_POINTER(vaddr));
> +                insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS, NULL);
>           }
>   
>           if (do_size) {
Alex Bennée Dec. 17, 2024, 3:23 p.m. UTC | #2 
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff mbox series

Patch

diff --git a/tests/tcg/plugins/insn.c b/tests/tcg/plugins/insn.c
index baf2d07205d..0c723cb9ed8 100644
--- a/tests/tcg/plugins/insn.c
+++ b/tests/tcg/plugins/insn.c
@@ -150,10 +150,8 @@  static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
             qemu_plugin_register_vcpu_insn_exec_inline_per_vcpu(
                 insn, QEMU_PLUGIN_INLINE_ADD_U64, insn_count, 1);
         } else {
-            uint64_t vaddr = qemu_plugin_insn_vaddr(insn);
             qemu_plugin_register_vcpu_insn_exec_cb(
-                insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS,
-                GUINT_TO_POINTER(vaddr));
+                insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS, NULL);
         }
 
         if (do_size) {