| Message ID | 20241218182001.41476-3-vicentiu.galanopulo@remote-tech.co.uk |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add LED1202 LED Controller | expand |
On 18/12/2024 19:19, Vicentiu Galanopulo wrote: > The LED1202 is a 12-channel low quiescent current LED driver with: > * Supply range from 2.6 V to 5 V > * 20 mA current capability per channel > * 1.8 V compatible I2C control interface > * 8-bit analog dimming individual control > * 12-bit local PWM resolution > * 8 programmable patterns > > If the led node is present in the controller then the channel is > set to active. > > Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Stop sending the same 5 times to people. Best regards, Krzysztof
On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > On 18/12/2024 19:19, Vicentiu Galanopulo wrote: > > The LED1202 is a 12-channel low quiescent current LED driver with: > > * Supply range from 2.6 V to 5 V > > * 20 mA current capability per channel > > * 1.8 V compatible I2C control interface > > * 8-bit analog dimming individual control > > * 12-bit local PWM resolution > > * 8 programmable patterns > > > > If the led node is present in the controller then the channel is > > set to active. > > > > Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > Stop sending the same 5 times to people. Without additional context, I don't think this is a reasonable request. If you're a maintainer of an affected subsystem and the set is at v10, you should expect to receive (and discard) the submission 10 times. I certainly don't start stripping out maintainers once they've provided their A-b or R-b, do you do that?
On 19/12/2024 09:28, Lee Jones wrote: > On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > >> On 18/12/2024 19:19, Vicentiu Galanopulo wrote: >>> The LED1202 is a 12-channel low quiescent current LED driver with: >>> * Supply range from 2.6 V to 5 V >>> * 20 mA current capability per channel >>> * 1.8 V compatible I2C control interface >>> * 8-bit analog dimming individual control >>> * 12-bit local PWM resolution >>> * 8 programmable patterns >>> >>> If the led node is present in the controller then the channel is >>> set to active. >>> >>> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >> Stop sending the same 5 times to people. > > Without additional context, I don't think this is a reasonable request. > > If you're a maintainer of an affected subsystem and the set is at v10, > you should expect to receive (and discard) the submission 10 times. I received the same patch - v10 - like 5 or 6 times. I replied to the last one, apparently all others were sent only to me. > > I certainly don't start stripping out maintainers once they've provided > their A-b or R-b, do you do that? Best regards, Krzysztof
On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > On 19/12/2024 09:28, Lee Jones wrote: > > On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > > > >> On 18/12/2024 19:19, Vicentiu Galanopulo wrote: > >>> The LED1202 is a 12-channel low quiescent current LED driver with: > >>> * Supply range from 2.6 V to 5 V > >>> * 20 mA current capability per channel > >>> * 1.8 V compatible I2C control interface > >>> * 8-bit analog dimming individual control > >>> * 12-bit local PWM resolution > >>> * 8 programmable patterns > >>> > >>> If the led node is present in the controller then the channel is > >>> set to active. > >>> > >>> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> --- > >> Stop sending the same 5 times to people. > > > > Without additional context, I don't think this is a reasonable request. > > > > If you're a maintainer of an affected subsystem and the set is at v10, > > you should expect to receive (and discard) the submission 10 times. > > I received the same patch - v10 - like 5 or 6 times. I replied to the > last one, apparently all others were sent only to me. Okay, so there is additional context. Fair enough.
On Thu, Dec 19, 2024 at 08:42:27AM +0000, Lee Jones wrote: > On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > > > On 19/12/2024 09:28, Lee Jones wrote: > > > On Thu, 19 Dec 2024, Krzysztof Kozlowski wrote: > > > > > >> On 18/12/2024 19:19, Vicentiu Galanopulo wrote: > > >>> The LED1202 is a 12-channel low quiescent current LED driver with: > > >>> * Supply range from 2.6 V to 5 V > > >>> * 20 mA current capability per channel > > >>> * 1.8 V compatible I2C control interface > > >>> * 8-bit analog dimming individual control > > >>> * 12-bit local PWM resolution > > >>> * 8 programmable patterns > > >>> > > >>> If the led node is present in the controller then the channel is > > >>> set to active. > > >>> > > >>> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> > > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > >>> --- > > >> Stop sending the same 5 times to people. This is the command I used: $ git send-email --to-cmd='./scripts/get_maintainer.pl --norolestats v11/v11-000*' v11/v11-000* I received the submitting only once and I do not know why it sent you 5 times.
diff --git a/Documentation/devicetree/bindings/leds/st,led1202.yaml b/Documentation/devicetree/bindings/leds/st,led1202.yaml new file mode 100644 index 000000000000..f1e5e4efaa3a --- /dev/null +++ b/Documentation/devicetree/bindings/leds/st,led1202.yaml @@ -0,0 +1,132 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/st,led1202.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ST LED1202 LED controllers + +maintainers: + - Vicentiu Galanopulo <vicentiu.galanopulo@remote-tech.co.uk> + +description: | + The LED1202 is a 12-channel low quiescent current LED controller + programmable via I2C; The output current can be adjusted separately + for each channel by 8-bit analog and 12-bit digital dimming control. + Datasheet available at + https://www.st.com/en/power-management/led1202.html + +properties: + compatible: + const: st,led1202 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@[0-9a-f]$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + minimum: 0 + maximum: 11 + + required: + - reg + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/leds/common.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@58 { + compatible = "st,led1202"; + reg = <0x58>; + #address-cells = <1>; + #size-cells = <0>; + + led@0 { + reg = <0x0>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <1>; + }; + + led@1 { + reg = <0x1>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <2>; + }; + + led@2 { + reg = <0x2>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <3>; + }; + + led@3 { + reg = <0x3>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <4>; + }; + + led@4 { + reg = <0x4>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <5>; + }; + + led@5 { + reg = <0x5>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <6>; + }; + + led@6 { + reg = <0x6>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + function-enumerator = <7>; + }; + + led@7 { + reg = <0x7>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + function-enumerator = <8>; + }; + + led@8 { + reg = <0x8>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + function-enumerator = <9>; + }; + }; + }; +...