| Message ID | 20241224142424.10572-2-mahesh.talewad@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | HID device connection issue fixed. | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=920753 ---Test result--- Test Summary: CheckPatch PENDING 0.18 seconds GitLint PENDING 0.19 seconds BuildEll PASS 22.57 seconds BluezMake PASS 1563.66 seconds MakeCheck PASS 13.64 seconds MakeDistcheck PASS 161.53 seconds CheckValgrind PASS 215.49 seconds CheckSmatch PASS 274.53 seconds bluezmakeextell PASS 99.83 seconds IncrementalBuild PENDING 0.24 seconds ScanBuild PASS 863.68 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hi Luiz, We tried with option - " UserspaceHID=true" in input.conf but HID Connection did not happen. Thanks and regards, Mahesh Vithal Talewad -----Original Message----- From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> Sent: Tuesday, January 7, 2025 1:24 AM To: Mahesh Talewad <mahesh.talewad@nxp.com> Cc: linux-bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>; Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>; Vinit Mehta <vinit.mehta@nxp.com> Subject: [EXT] Re: [PATCH BlueZ v1 1/1] HID device not connecting issue fixed. Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button Hi Mahesh, On Tue, Dec 24, 2024 at 9:24 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote: > > While connecting BT-HID device showing br-profile unavailable and > connection did not happen. > Steps followed: > 1. Pair Ref device > 2. Connect Ref device > With this patch HID device is able to connect and HID traffic can be > observed in btmon. > --- > profiles/input/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/profiles/input/device.c b/profiles/input/device.c index > 8cf8e5ea7..a6047998a 100644 > --- a/profiles/input/device.c > +++ b/profiles/input/device.c > @@ -89,7 +89,7 @@ struct input_device { }; > > static int idle_timeout = 0; > -static uhid_state_t uhid_state = UHID_ENABLED; > +static uhid_state_t uhid_state = UHID_DISABLED; Well this would contradict input.conf: https://github.com/bluez/bluez/blob/master/profiles/input/input.conf#L18 Perhaps what is missing is the detection that if uhid is not enabled in the kernel it would switch it off automatically, that said it was intended by the distro to know whether to enable it or not, so we don't have to play a guess game runtime. > static bool classic_bonded_only = true; > > void input_set_idle_timeout(int timeout) > -- > 2.34.1 > -- Luiz Augusto von Dentz
Hi Mahesh, On Tue, Jan 7, 2025 at 7:05 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote: > > Hi Luiz, > > We tried with option - " UserspaceHID=true" in input.conf but HID Connection did not happen. Do you have the HCI trace? Does it fail to connect or just doesn't work because your kernel don't have uhid enabled? > Thanks and regards, > Mahesh Vithal Talewad > > -----Original Message----- > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > Sent: Tuesday, January 7, 2025 1:24 AM > To: Mahesh Talewad <mahesh.talewad@nxp.com> > Cc: linux-bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>; Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>; Vinit Mehta <vinit.mehta@nxp.com> > Subject: [EXT] Re: [PATCH BlueZ v1 1/1] HID device not connecting issue fixed. > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > Hi Mahesh, > > On Tue, Dec 24, 2024 at 9:24 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote: > > > > While connecting BT-HID device showing br-profile unavailable and > > connection did not happen. > > Steps followed: > > 1. Pair Ref device > > 2. Connect Ref device > > With this patch HID device is able to connect and HID traffic can be > > observed in btmon. > > --- > > profiles/input/device.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/profiles/input/device.c b/profiles/input/device.c index > > 8cf8e5ea7..a6047998a 100644 > > --- a/profiles/input/device.c > > +++ b/profiles/input/device.c > > @@ -89,7 +89,7 @@ struct input_device { }; > > > > static int idle_timeout = 0; > > -static uhid_state_t uhid_state = UHID_ENABLED; > > +static uhid_state_t uhid_state = UHID_DISABLED; > > Well this would contradict input.conf: > > https://github.com/bluez/bluez/blob/master/profiles/input/input.conf#L18 > > Perhaps what is missing is the detection that if uhid is not enabled in the kernel it would switch it off automatically, that said it was intended by the distro to know whether to enable it or not, so we don't have to play a guess game runtime. > > > static bool classic_bonded_only = true; > > > > void input_set_idle_timeout(int timeout) > > -- > > 2.34.1 > > > > > -- > Luiz Augusto von Dentz
Hi Mahesh, On Tue, Jan 7, 2025 at 9:49 AM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Mahesh, > > On Tue, Jan 7, 2025 at 7:05 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote: > > > > Hi Luiz, > > > > We tried with option - " UserspaceHID=true" in input.conf but HID Connection did not happen. > > Do you have the HCI trace? Does it fail to connect or just doesn't > work because your kernel don't have uhid enabled? If the problem is just that the kernel doesn't have it enabled you can try with the following change: https://patchwork.kernel.org/project/bluetooth/patch/20250107203056.1470303-1-luiz.dentz@gmail.com/ > > Thanks and regards, > > Mahesh Vithal Talewad > > > > -----Original Message----- > > From: Luiz Augusto von Dentz <luiz.dentz@gmail.com> > > Sent: Tuesday, January 7, 2025 1:24 AM > > To: Mahesh Talewad <mahesh.talewad@nxp.com> > > Cc: linux-bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>; Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>; Vinit Mehta <vinit.mehta@nxp.com> > > Subject: [EXT] Re: [PATCH BlueZ v1 1/1] HID device not connecting issue fixed. > > > > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > > > > Hi Mahesh, > > > > On Tue, Dec 24, 2024 at 9:24 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote: > > > > > > While connecting BT-HID device showing br-profile unavailable and > > > connection did not happen. > > > Steps followed: > > > 1. Pair Ref device > > > 2. Connect Ref device > > > With this patch HID device is able to connect and HID traffic can be > > > observed in btmon. > > > --- > > > profiles/input/device.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/profiles/input/device.c b/profiles/input/device.c index > > > 8cf8e5ea7..a6047998a 100644 > > > --- a/profiles/input/device.c > > > +++ b/profiles/input/device.c > > > @@ -89,7 +89,7 @@ struct input_device { }; > > > > > > static int idle_timeout = 0; > > > -static uhid_state_t uhid_state = UHID_ENABLED; > > > +static uhid_state_t uhid_state = UHID_DISABLED; > > > > Well this would contradict input.conf: > > > > https://github.com/bluez/bluez/blob/master/profiles/input/input.conf#L18 > > > > Perhaps what is missing is the detection that if uhid is not enabled in the kernel it would switch it off automatically, that said it was intended by the distro to know whether to enable it or not, so we don't have to play a guess game runtime. > > > > > static bool classic_bonded_only = true; > > > > > > void input_set_idle_timeout(int timeout) > > > -- > > > 2.34.1 > > > > > > > > > -- > > Luiz Augusto von Dentz > > > > -- > Luiz Augusto von Dentz
diff --git a/profiles/input/device.c b/profiles/input/device.c index 8cf8e5ea7..a6047998a 100644 --- a/profiles/input/device.c +++ b/profiles/input/device.c @@ -89,7 +89,7 @@ struct input_device { }; static int idle_timeout = 0; -static uhid_state_t uhid_state = UHID_ENABLED; +static uhid_state_t uhid_state = UHID_DISABLED; static bool classic_bonded_only = true; void input_set_idle_timeout(int timeout)