| Message ID | 20241221111454.1074285-3-ariel.otilibili-anieli@eurecom.fr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code | expand |
On 21/12/2024 12:06, Ariel Otilibili wrote: > Coverity-ID: 1269153 > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> > --- > drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c > index 1cfec76b72f3..f2a2d0c39080 100644 > --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c > +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c > @@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard) > status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB, > 0x00000000); > /* Save the Spec Inversion value */ > - dif_misc_ctrl_value &= FLD_DIF_SPEC_INV; Don't remove this line, > dif_misc_ctrl_value = 0x3A093F10; instead this should have been |=, just like is done elsewhere in this function. > } else if (standard & > (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G | Also, please just post this as a separate patch to linux-media. It is bad form to mix subsystems in the same patch series if there is no reason for it. Regards, Hans
diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c index 1cfec76b72f3..f2a2d0c39080 100644 --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c @@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard) status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB, 0x00000000); /* Save the Spec Inversion value */ - dif_misc_ctrl_value &= FLD_DIF_SPEC_INV; dif_misc_ctrl_value = 0x3A093F10; } else if (standard & (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |
Coverity-ID: 1269153 Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 - 1 file changed, 1 deletion(-)