diff mbox series

[1/3] linux-user: Only include 'exec/tb-flush.h' header when necessary

Message ID 20250102182521.65428-2-philmd@linaro.org
State New
Headers show
Series linux-user: Call tcg_flush_jmp_cache() before re-using threads | expand

Commit Message

Philippe Mathieu-Daudé Jan. 2, 2025, 6:25 p.m. UTC 
Very few source files require to access "exec/tb-flush.h"
declarations, and except a pair, they all include it
explicitly. No need to overload the generic "user-internals.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 linux-user/user-internals.h | 1 -
 linux-user/mmap.c           | 1 +
 linux-user/syscall.c        | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

Comments

Ilya Leoshkevich Jan. 9, 2025, 10:13 p.m. UTC | #1 
On Thu, 2025-01-02 at 19:25 +0100, Philippe Mathieu-Daudé wrote:
> Very few source files require to access "exec/tb-flush.h"
> declarations, and except a pair, they all include it
> explicitly. No need to overload the generic "user-internals.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  linux-user/user-internals.h | 1 -
>  linux-user/mmap.c           | 1 +
>  linux-user/syscall.c        | 1 +
>  3 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Pierrick Bouvier Jan. 22, 2025, 12:41 a.m. UTC | #2 
On 1/2/25 10:25, Philippe Mathieu-Daudé wrote:
> Very few source files require to access "exec/tb-flush.h"
> declarations, and except a pair, they all include it
> explicitly. No need to overload the generic "user-internals.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   linux-user/user-internals.h | 1 -
>   linux-user/mmap.c           | 1 +
>   linux-user/syscall.c        | 1 +
>   3 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
> index b9b05c1d11f..4aa253b5663 100644
> --- a/linux-user/user-internals.h
> +++ b/linux-user/user-internals.h
> @@ -20,7 +20,6 @@
>   
>   #include "user/thunk.h"
>   #include "exec/exec-all.h"
> -#include "exec/tb-flush.h"
>   #include "qemu/log.h"
>   
>   extern char *exec_path;
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 6828b17a63f..d1f36e6f16b 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -21,6 +21,7 @@
>   #include "trace.h"
>   #include "exec/log.h"
>   #include "exec/page-protection.h"
> +#include "exec/tb-flush.h"
>   #include "exec/translation-block.h"
>   #include "qemu.h"
>   #include "user/page-protection.h"
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 78c7c0b34ef..cbbfcf10d28 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -26,6 +26,7 @@
>   #include "tcg/startup.h"
>   #include "target_mman.h"
>   #include "exec/page-protection.h"
> +#include "exec/tb-flush.h"
>   #include "exec/translation-block.h"
>   #include <elf.h>
>   #include <endian.h>

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff mbox series

Patch

diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
index b9b05c1d11f..4aa253b5663 100644
--- a/linux-user/user-internals.h
+++ b/linux-user/user-internals.h
@@ -20,7 +20,6 @@ 
 
 #include "user/thunk.h"
 #include "exec/exec-all.h"
-#include "exec/tb-flush.h"
 #include "qemu/log.h"
 
 extern char *exec_path;
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 6828b17a63f..d1f36e6f16b 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -21,6 +21,7 @@ 
 #include "trace.h"
 #include "exec/log.h"
 #include "exec/page-protection.h"
+#include "exec/tb-flush.h"
 #include "exec/translation-block.h"
 #include "qemu.h"
 #include "user/page-protection.h"
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 78c7c0b34ef..cbbfcf10d28 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -26,6 +26,7 @@ 
 #include "tcg/startup.h"
 #include "target_mman.h"
 #include "exec/page-protection.h"
+#include "exec/tb-flush.h"
 #include "exec/translation-block.h"
 #include <elf.h>
 #include <endian.h>