Message ID | 20241105222326.194417-1-rosenp@gmail.com |
---|---|
State | New |
Headers | show |
Series | [PATCHv3] wifi: ath9k: return by of_get_mac_address | expand |
On Tue, 05 Nov 2024 14:23:26 -0800, Rosen Penev wrote: > When using nvmem, ath9k could potentially be loaded before nvmem, which > loads after mtd. This is an issue if DT contains an nvmem mac address. > > If nvmem is not ready in time for ath9k, -EPROBE_DEFER is returned. Pass > it to _probe so that ath9k can properly grab a potentially present MAC > address. > > [...] Applied, thanks! [1/1] wifi: ath9k: return by of_get_mac_address commit: dfffb317519f88534bb82797f055f0a2fd867e7b Best regards,
diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index f9e77c4624d9..01e0dffbf57e 100644 --- a/drivers/net/wireless/ath/ath9k/init.c +++ b/drivers/net/wireless/ath/ath9k/init.c @@ -647,7 +647,9 @@ static int ath9k_of_init(struct ath_softc *sc) ah->ah_flags |= AH_NO_EEP_SWAP; } - of_get_mac_address(np, common->macaddr); + ret = of_get_mac_address(np, common->macaddr); + if (ret == -EPROBE_DEFER) + return ret; return 0; }
When using nvmem, ath9k could potentially be loaded before nvmem, which loads after mtd. This is an issue if DT contains an nvmem mac address. If nvmem is not ready in time for ath9k, -EPROBE_DEFER is returned. Pass it to _probe so that ath9k can properly grab a potentially present MAC address. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- v3: only return EPROBE_DEFER to avoid terminating probe. v2: modified commit message drivers/net/wireless/ath/ath9k/init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)