| Message ID | 20241224013257.185742-1-linux@treblig.org |
|---|---|
| Headers | show |
| Series | wifi: mac80211: Deadcode cleanup | expand |
* linux@treblig.org (linux@treblig.org) wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > Hi, > This pair of patches removes a bunch of functions that haven't > been called for more than a few years. > > I suspect I could go further; in particular I wonder > if > ieee80211_debugfs_key_remove_beacon_default() > and > ieee80211_debugfs_key_remove_mgmt_default() > > could go together with a data structure somewhere? > > Also, ieee80211_nan_func_match() was the last use of > cfg80211_nan_match(); but that would be in a separate area. > > Dave > > Dr. David Alan Gilbert (2): > wifi: mac80211: Clean up debugfs_key deadcode > wifi: mac80211: Remove unused ieee80211_nan_func_match Hi, I noticed one of these patches (debugfs_key) has landed in 6.14 but the other one I don't think has - any particular reason? Dave > > include/net/mac80211.h | 15 ------------ > net/mac80211/cfg.c | 25 -------------------- > net/mac80211/debugfs_key.c | 47 -------------------------------------- > net/mac80211/debugfs_key.h | 15 ------------ > 4 files changed, 102 deletions(-) > > -- > 2.47.1 >
On Tue, 2025-01-28 at 18:39 +0000, Dr. David Alan Gilbert wrote: > > > wifi: mac80211: Remove unused ieee80211_nan_func_match > > Hi, > I noticed one of these patches (debugfs_key) has landed in 6.14 > but the other one I don't think has - any particular reason? We were still using NAN internally, and there's a chance that it might make a comeback, so I was holding off on it for now. johannes
* Johannes Berg (johannes@sipsolutions.net) wrote: > On Tue, 2025-01-28 at 18:39 +0000, Dr. David Alan Gilbert wrote: > > > > > wifi: mac80211: Remove unused ieee80211_nan_func_match > > > > Hi, > > I noticed one of these patches (debugfs_key) has landed in 6.14 > > but the other one I don't think has - any particular reason? > > We were still using NAN internally, and there's a chance that it might > make a comeback, so I was holding off on it for now. Ah OK. Thanks! Dave > johannes
From: "Dr. David Alan Gilbert" <linux@treblig.org> Hi, This pair of patches removes a bunch of functions that haven't been called for more than a few years. I suspect I could go further; in particular I wonder if ieee80211_debugfs_key_remove_beacon_default() and ieee80211_debugfs_key_remove_mgmt_default() could go together with a data structure somewhere? Also, ieee80211_nan_func_match() was the last use of cfg80211_nan_match(); but that would be in a separate area. Dave Dr. David Alan Gilbert (2): wifi: mac80211: Clean up debugfs_key deadcode wifi: mac80211: Remove unused ieee80211_nan_func_match include/net/mac80211.h | 15 ------------ net/mac80211/cfg.c | 25 -------------------- net/mac80211/debugfs_key.c | 47 -------------------------------------- net/mac80211/debugfs_key.h | 15 ------------ 4 files changed, 102 deletions(-)