| Message ID | 20250117181953.3375273-1-nico.escande@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: ath11k: remove peer extra rssi update | expand |
On 1/17/2025 10:19 AM, Nicolas Escande wrote: > Commit b205ce4c266c (ath11k: support avg signal in station dump) added an I'll fixup this reference to address the checkpatch error: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")' total: 1 errors, 0 warnings, 0 checks, 8 lines checked > extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats > when it added the average rssi support. So lets keeps only one by removing > the legacy assignment so the two statements about rssi stay next to each > other. Compile tested only. > > Signed-off-by: Nicolas Escande <nico.escande@gmail.com> > --- > drivers/net/wireless/ath/ath11k/dp_rx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c > index 029ecf51c9efd..24774cba9823b 100644 > --- a/drivers/net/wireless/ath/ath11k/dp_rx.c > +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c > @@ -2831,8 +2831,6 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta, > rx_stats->dcm_count += ppdu_info->dcm; > rx_stats->ru_alloc_cnt[ppdu_info->ru_alloc] += num_msdu; > > - arsta->rssi_comb = ppdu_info->rssi_comb; > - > BUILD_BUG_ON(ARRAY_SIZE(arsta->chain_signal) > > ARRAY_SIZE(ppdu_info->rssi_chain_pri20)); >
On 1/28/2025 2:29 PM, Jeff Johnson wrote: > On 1/17/2025 10:19 AM, Nicolas Escande wrote: >> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an > > I'll fixup this reference to address the checkpatch error: > ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")' > total: 1 errors, 0 warnings, 0 checks, 8 lines checked > >> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats >> when it added the average rssi support. So lets keeps only one by removing >> the legacy assignment so the two statements about rssi stay next to each >> other. Compile tested only. I actually made three fixups, please check: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=7946ec554fbea5db9a3aedb7087f0eb9e3749abc 1) commit reference 2) add () to function name 3) lets => let's
On Wed Jan 29, 2025 at 1:08 AM CET, Jeff Johnson wrote: > On 1/28/2025 2:29 PM, Jeff Johnson wrote: >> On 1/17/2025 10:19 AM, Nicolas Escande wrote: >>> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an >> >> I'll fixup this reference to address the checkpatch error: >> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")' >> total: 1 errors, 0 warnings, 0 checks, 8 lines checked >> >>> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats >>> when it added the average rssi support. So lets keeps only one by removing >>> the legacy assignment so the two statements about rssi stay next to each >>> other. Compile tested only. > > I actually made three fixups, please check: > https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=7946ec554fbea5db9a3aedb7087f0eb9e3749abc > > 1) commit reference > 2) add () to function name > 3) lets => let's Thanks, it looks perfect.
On Tue Jan 28, 2025 at 11:29 PM CET, Jeff Johnson wrote: > On 1/17/2025 10:19 AM, Nicolas Escande wrote: >> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an > > I'll fixup this reference to address the checkpatch error: > ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit b205ce4c266c ("ath11k: support avg signal in station dump")' > total: 1 errors, 0 warnings, 0 checks, 8 lines checked Arf I can see that the commit format is wrong but I wonder why checkpatch didn't arn me. Do I need more options set on the cmdline ? scripts/checkpatch.pl mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch total: 0 errors, 0 warnings, 0 checks, 8 lines checked mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch has no obvious style problems and is ready for submission. > >> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats >> when it added the average rssi support. So lets keeps only one by removing >> the legacy assignment so the two statements about rssi stay next to each >> other. Compile tested only. >> >> Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
On Fri, 17 Jan 2025 19:19:53 +0100, Nicolas Escande wrote: > Commit b205ce4c266c (ath11k: support avg signal in station dump) added an > extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats > when it added the average rssi support. So lets keeps only one by removing > the legacy assignment so the two statements about rssi stay next to each > other. Compile tested only. > > > [...] Applied, thanks! [1/1] wifi: ath11k: remove peer extra rssi update commit: bee577165a0a375a1d47d8ddef1c321e0f7dd6c8 Best regards,
On 1/29/2025 1:24 AM, Nicolas Escande wrote: > Arf I can see that the commit format is wrong but I wonder why checkpatch didn't > arn me. Do I need more options set on the cmdline ? > > scripts/checkpatch.pl mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch > total: 0 errors, 0 warnings, 0 checks, 8 lines checked > > mail/0001-wifi-ath11k-remove-extra-rssi-update-in-ath11k_dp_rx.patch has no obvious style problems and is ready for submission. Are you running checkpatch from within a kernel tree? Looking at the code: ($id, $description) = git_commit_info($orig_commit, $id, $orig_desc); if (defined($id) && ($short || $long || $space || $case || ($orig_desc ne $description) || !$has_quotes) && $last_git_commit_id_linenr != $linenr - 1) { ERROR("GIT_COMMIT_ID", "Please use git commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}ommit $id (\"$description\")'\n" . $herectx); } So it will only report the problem if it can find the commit in git so that it can provide the correct id and description. /jeff
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 029ecf51c9efd..24774cba9823b 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -2831,8 +2831,6 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta, rx_stats->dcm_count += ppdu_info->dcm; rx_stats->ru_alloc_cnt[ppdu_info->ru_alloc] += num_msdu; - arsta->rssi_comb = ppdu_info->rssi_comb; - BUILD_BUG_ON(ARRAY_SIZE(arsta->chain_signal) > ARRAY_SIZE(ppdu_info->rssi_chain_pri20));
Commit b205ce4c266c (ath11k: support avg signal in station dump) added an extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats when it added the average rssi support. So lets keeps only one by removing the legacy assignment so the two statements about rssi stay next to each other. Compile tested only. Signed-off-by: Nicolas Escande <nico.escande@gmail.com> --- drivers/net/wireless/ath/ath11k/dp_rx.c | 2 -- 1 file changed, 2 deletions(-)