mbox series

[V3,0/6] Drivers for Loongson security engine

Message ID 20250219073350.16915-1-zhaoqunqin@loongson.cn
Headers show
Series Drivers for Loongson security engine | expand

Message

Qunqin Zhao Feb. 19, 2025, 7:33 a.m. UTC 
Loongson security engine supports random number generation, hash,
symmetric encryption and asymmetric encryption. Based on these
encryption functions, TPM2 have been implemented in it.

mfd is the baser driver, crypto and tpm are users.

v3: Put the updates to the MAINTAINERS in a separate patch.
v2: Removed misc driver. Added tpm driver.

Qunqin Zhao (6):
  mfd: Add support for Loongson Security Module
  MAINTAINERS: Add maintainer for Loongson Security Module driver
  crypto: loongson - add Loongson RNG driver support
  MAINTAINERS: Add maintainer for Loongson RNG driver
  tpm: Add a driver for Loongson TPM device
  MAINTAINERS: Add tpm_lsse.c to LOONGSON CRYPTO DRIVER entry

 MAINTAINERS                            |  14 +
 drivers/char/tpm/Kconfig               |   9 +
 drivers/char/tpm/Makefile              |   1 +
 drivers/char/tpm/tpm_lsse.c            | 104 +++++++
 drivers/crypto/Kconfig                 |   1 +
 drivers/crypto/Makefile                |   1 +
 drivers/crypto/loongson/Kconfig        |   6 +
 drivers/crypto/loongson/Makefile       |   2 +
 drivers/crypto/loongson/ls6000se-rng.c | 190 +++++++++++++
 drivers/mfd/Kconfig                    |   9 +
 drivers/mfd/Makefile                   |   2 +
 drivers/mfd/ls6000se.c                 | 374 +++++++++++++++++++++++++
 include/linux/mfd/ls6000se.h           |  75 +++++
 13 files changed, 788 insertions(+)
 create mode 100644 drivers/char/tpm/tpm_lsse.c
 create mode 100644 drivers/crypto/loongson/Kconfig
 create mode 100644 drivers/crypto/loongson/Makefile
 create mode 100644 drivers/crypto/loongson/ls6000se-rng.c
 create mode 100644 drivers/mfd/ls6000se.c
 create mode 100644 include/linux/mfd/ls6000se.h


base-commit: 2816b0c949af89640b8dc05de53e650cbf1d55fb

Comments

Jarkko Sakkinen Feb. 20, 2025, 2:12 p.m. UTC | #1 
On Thu, Feb 20, 2025 at 07:23:42PM +0800, Qunqin Zhao wrote:
> 
> 在 2025/2/19 下午9:44, Jarkko Sakkinen 写道:
> > > +
> > > +static const struct tpm_class_ops lsse_tpm_ops = {
> > > +	.flags = TPM_OPS_AUTO_STARTUP,
> > > +	.recv = tpm_ls_recv,
> > > +	.send = tpm_ls_send,
> > > +};
> > > +
> > > +static int lsse_tpm_probe(struct platform_device *pdev)
> > tpm_lsse_
> OK.
> > +
> > +static struct platform_driver lsse_tpm_driver = {
> > +	.probe   = lsse_tpm_probe,
> > +	.driver  = {
> > +		.name  = "ls6000se-tpm",
> > +	},
> > +};
> > +module_platform_driver(lsse_tpm_driver);
> > +
> > +MODULE_ALIAS("platform:ls6000se-tpm");
> > +MODULE_LICENSE("GPL");
> > +MODULE_AUTHOR("Yinggang Gu <guyinggang@loongson.cn>");
> > +MODULE_AUTHOR("Qunqin Zhao <zhaoqunqin@loongson.cn>");
> > Remove MODULE_AUTHOR fields. Git encodes this already.
> 
> Do you mean that "modinfo" will still show the author after removing
> MODULE_AUTHOR fields?

What is the utility of showing that? Nobody ever updates those in real
life, so you really can't trust them anyhow. We're better of not showing
anything at all.

> 
> > 
> > > +MODULE_DESCRIPTION("Loongson TPM driver");
> > > -- 
> > > 2.43.0
> > > 
> > Prefix all with tpm_lsse instead of tpm
> 
> OK, thanks for your comments.
> 
> BR, Qunqin.
> 
> > 
> > BR, Jarkko
> 

BR, Jarkko