| Message ID | 20250220-b4-sm8750-cdsp-v2-0-a70dd2d04419@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sm8750: CDSP and modem | expand |
On Fri, Feb 21, 2025 at 09:38:09AM +0100, Krzysztof Kozlowski wrote: > On 20/02/2025 17:19, Dmitry Baryshkov wrote: > > On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote: > >> Enable the CDSP on MPT8750 board and add firmware for the modem, however > >> keep it as failed because modem crashes after booting for unknown > >> reasons. > > > > So the modem crashes on MTP, but does not on QRD? > QRD was not tested - which mentioned in that patch - and I hope someone > will test it and tell me :) Then it might also be broken. I have the same situation on SAR2130P, ADSP works, but CDSP crashes. Please separate modem to a separate series and clearly mark that it is not supposed to work. Until it works on any of the boards I don't think we should be merging corresponding driver bits, which are known-broken.
On 21/02/2025 15:15, Dmitry Baryshkov wrote: > On Fri, Feb 21, 2025 at 09:38:09AM +0100, Krzysztof Kozlowski wrote: >> On 20/02/2025 17:19, Dmitry Baryshkov wrote: >>> On Thu, Feb 20, 2025 at 04:44:13PM +0100, Krzysztof Kozlowski wrote: >>>> Enable the CDSP on MPT8750 board and add firmware for the modem, however >>>> keep it as failed because modem crashes after booting for unknown >>>> reasons. >>> >>> So the modem crashes on MTP, but does not on QRD? >> QRD was not tested - which mentioned in that patch - and I hope someone >> will test it and tell me :) > > Then it might also be broken. I have the same situation on SAR2130P, > ADSP works, but CDSP crashes. Please separate modem to a separate series > and clearly mark that it is not supposed to work. Until it works on any > of the boards I don't think we should be merging corresponding driver > bits, which are known-broken. > OK Best regards, Krzysztof
Hi, Changes in v2: - Fix CDSP and MPSS PAS address space range. - Re-order nodes for correct placement. - Rb tags. - Link to v1: https://lore.kernel.org/r/20241122-b4-sm8750-cdsp-v1-0-9a69a889d1b7@linaro.org Context of this depends on my audio patches: https://lore.kernel.org/r/20250220-sm8750-audio-v2-0-fbe243c4afc3@linaro.org Bindings for remoteproc: https://lore.kernel.org/linux-arm-msm/20250220154132.199358-1-krzysztof.kozlowski@linaro.org/T/#t Best regards, Krzysztof --- Krzysztof Kozlowski (4): arm64: dts: qcom: sm8750: Add CDSP arm64: dts: qcom: sm8750: Add Modem / MPSS arm64: dts: qcom: sm8750-mtp: Enable CDSP and mention MPSS arm64: dts: qcom: sm8750-qrd: Enable CDSP and mention MPSS arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 15 ++ arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 14 ++ arch/arm64/boot/dts/qcom/sm8750.dtsi | 286 ++++++++++++++++++++++++++++++++ 3 files changed, 315 insertions(+) --- base-commit: 51ad5d52335d6aa0bda1d8305d44679dddbbfec5 change-id: 20241122-b4-sm8750-cdsp-38a6c2643a3d Best regards,