| Message ID | 20250124113331.93476-1-nico.escande@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: ath12k: fbx: Add missing htt_metadata flag in ath12k_dp_tx() | expand |
On Fri Jan 24, 2025 at 12:33 PM CET, Nicolas Escande wrote: > When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to > the tx_info's meta_data_flags . Without this flag the firmware seems to > reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k > did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 > > Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support") > Signed-off-by: Nicolas Escande <nico.escande@gmail.com> I left a 'fbx' in the title that needs to be removed here. I'll send a v2 if need be, but feel free to remove it yourselves if you take the patch as is.
On 1/24/2025 5:03 PM, Nicolas Escande wrote: > When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to > the tx_info's meta_data_flags . Without this flag the firmware seems to > reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k > did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 > > Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support") > Signed-off-by: Nicolas Escande <nico.escande@gmail.com> Thanks for the this. Can you pls resend the patch without fbx in the patch title? The rest looks good. Vasanth
On 2/12/2025 9:37 AM, Vasanthakumar Thiagarajan wrote: > > > On 1/24/2025 5:03 PM, Nicolas Escande wrote: >> When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to >> the tx_info's meta_data_flags . Without this flag the firmware seems to >> reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k >> did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 >> >> Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support") >> Signed-off-by: Nicolas Escande <nico.escande@gmail.com> > > Thanks for the this. My bad, I meant "Thanks for the fix"
On 1/24/2025 3:33 AM, Nicolas Escande wrote: > When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to > the tx_info's meta_data_flags . Without this flag the firmware seems to > reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k > did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") checkpatch complains: WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5e8a373c8699', maybe rebased or not pulled? And I don't see such a change in kernel.org Perhaps this is an out-of-tree change that should be referenced in a different way? /jeff
On Wed Feb 19, 2025 at 6:58 PM CET, Jeff Johnson wrote: > > checkpatch complains: > WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5e8a373c8699', maybe rebased or not pulled? > > And I don't see such a change in kernel.org > > Perhaps this is an out-of-tree change that should be referenced in a different > way? > > /jeff Indeed I didn't realize that was not mainline, but just in our internal tree. My bad. Honestly surprised this has never been pushed upstream. So the corresponding patch I was refering to is this one: https://git.codelinaro.org/clo/qsdk/oss/system/feeds/wlan-open/-/blob/win.wlan_host_opensource.3.0.r24/patches/ath11k/207-ath11k-Add-support-for-dynamic-vlan.patch How would you like to proceed ? I can respin it without this wrong reference if need be. But if one of you guys has a better fix or something we can drop it too Thanks
On 2/19/2025 10:33 AM, Nicolas Escande wrote: > On Wed Feb 19, 2025 at 6:58 PM CET, Jeff Johnson wrote: >> >> checkpatch complains: >> WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5e8a373c8699', maybe rebased or not pulled? >> >> And I don't see such a change in kernel.org >> >> Perhaps this is an out-of-tree change that should be referenced in a different >> way? >> >> /jeff > > Indeed I didn't realize that was not mainline, but just in our internal tree. > My bad. Honestly surprised this has never been pushed upstream. > > So the corresponding patch I was refering to is this one: > https://git.codelinaro.org/clo/qsdk/oss/system/feeds/wlan-open/-/blob/win.wlan_host_opensource.3.0.r24/patches/ath11k/207-ath11k-Add-support-for-dynamic-vlan.patch > > How would you like to proceed ? I can respin it without this wrong reference if > need be. But if one of you guys has a better fix or something we can drop it too Let me fix this up in the 'pending' branch /jeff
On 2/19/2025 10:33 AM, Nicolas Escande wrote: > On Wed Feb 19, 2025 at 6:58 PM CET, Jeff Johnson wrote: >> >> checkpatch complains: >> WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '5e8a373c8699', maybe rebased or not pulled? >> >> And I don't see such a change in kernel.org >> >> Perhaps this is an out-of-tree change that should be referenced in a different >> way? >> >> /jeff > > Indeed I didn't realize that was not mainline, but just in our internal tree. > My bad. Honestly surprised this has never been pushed upstream. > > So the corresponding patch I was refering to is this one: > https://git.codelinaro.org/clo/qsdk/oss/system/feeds/wlan-open/-/blob/win.wlan_host_opensource.3.0.r24/patches/ath11k/207-ath11k-Add-support-for-dynamic-vlan.patch > > How would you like to proceed ? I can respin it without this wrong reference if > need be. But if one of you guys has a better fix or something we can drop it too > > Thanks Fixed the subject and description in pending, please check: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=e5c718f0c65701ec941ab3121266f33f83ee9803
On Thu Feb 20, 2025 at 4:46 PM CET, Jeff Johnson wrote: > > Fixed the subject and description in pending, please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=e5c718f0c65701ec941ab3121266f33f83ee9803 Perfect, Thanks a lot Jeff
On Fri, 24 Jan 2025 12:33:31 +0100, Nicolas Escande wrote: > When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to > the tx_info's meta_data_flags . Without this flag the firmware seems to > reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k > did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 > > [...] Applied, thanks! [1/1] wifi: ath12k: fbx: Add missing htt_metadata flag in ath12k_dp_tx() commit: af1c6007a64e78b729eb5a8d149637a820077bee Best regards,
diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c index 00437736e0322..0d7a079f4c6d1 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.c +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c @@ -368,6 +368,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, add_htt_metadata = true; msdu_ext_desc = true; ti.flags0 |= u32_encode_bits(1, HAL_TCL_DATA_CMD_INFO2_TO_FW); + ti.meta_data_flags |= HTT_TCL_META_DATA_VALID_HTT; ti.encap_type = HAL_TCL_ENCAP_TYPE_RAW; ti.encrypt_type = HAL_ENCRYPT_TYPE_OPEN; }
When AP-VLAN was added, we did not add HTT_TCL_META_DATA_VALID_HTT flag to the tx_info's meta_data_flags . Without this flag the firmware seems to reject all the broadcast (ap-vlan) frames. So lets add it same as ath11k did it in commit 5e8a373c8699 ("ath11k: Add support for dynamic vlan") Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support") Signed-off-by: Nicolas Escande <nico.escande@gmail.com> --- drivers/net/wireless/ath/ath12k/dp_tx.c | 1 + 1 file changed, 1 insertion(+)