diff mbox series

[v10,08/11] governors/haltpoll: drop kvm_para_available() check

Message ID 20250218213337.377987-9-ankur.a.arora@oracle.com
State New
Headers show
Series arm64: support poll_idle() | expand

Commit Message

Ankur Arora Feb. 18, 2025, 9:33 p.m. UTC 
From: Joao Martins <joao.m.martins@oracle.com>

The haltpoll governor is selected either by the cpuidle-haltpoll
driver, or explicitly by the user.
In particular, it is never selected by default since it has the lowest
rating of all governors (menu=20, teo=19, ladder=10/25, haltpoll=9).

So, we can safely forgo the kvm_para_available() check. This also
allows cpuidle-haltpoll to be tested on baremetal.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 drivers/cpuidle/governors/haltpoll.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Ankur Arora Feb. 25, 2025, 7:06 p.m. UTC | #1 
Christoph Lameter (Ampere) <cl@gentwo.org> writes:

> On Tue, 18 Feb 2025, Ankur Arora wrote:
>
>> So, we can safely forgo the kvm_para_available() check. This also
>> allows cpuidle-haltpoll to be tested on baremetal.
>
> I would hope that we will have this functionality as the default on
> baremetal after testing in the future.

Yeah, supporting haltpoll style adaptive polling on baremetal has some
way to go.

But, with Lifeng's patch-6 "ACPI: processor_idle: Support polling state
for LPI" we do get polling support in acpi-idle.

> Reviewed-by; Christoph Lameter (Ampere) <cl@linux.com>

Thanks Christoph!

--
ankur
diff mbox series

Patch

diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/governors/haltpoll.c
index 663b7f164d20..c8752f793e61 100644
--- a/drivers/cpuidle/governors/haltpoll.c
+++ b/drivers/cpuidle/governors/haltpoll.c
@@ -18,7 +18,6 @@ 
 #include <linux/tick.h>
 #include <linux/sched.h>
 #include <linux/module.h>
-#include <linux/kvm_para.h>
 #include <trace/events/power.h>
 
 static unsigned int guest_halt_poll_ns __read_mostly = 200000;
@@ -148,10 +147,7 @@  static struct cpuidle_governor haltpoll_governor = {
 
 static int __init init_haltpoll(void)
 {
-	if (kvm_para_available())
-		return cpuidle_register_governor(&haltpoll_governor);
-
-	return 0;
+	return cpuidle_register_governor(&haltpoll_governor);
 }
 
 postcore_initcall(init_haltpoll);