| Message ID | 20250306-topic-dt_bindings_fixups-v1-0-0c84aceb0ef9@oss.qualcomm.com |
|---|---|
| Headers | show |
| Series | Various dt-bindings fixes | expand |
On Thu, Mar 06, 2025 at 07:11:19PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > The node is currently named power-controller, which requires the device > underneath is a power domain provider. Rename it to align with other > SoCs and resolve this sort of warnings: > > power-controller@c300000: '#power-domain-cells' is a required property > > Fixes: 0775021783b5 ("arm64: dts: qcom: qcs615: add AOSS_QMP node") > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/qcs615.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, Mar 06, 2025 at 07:11:23PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > The preemptively-merged node contains a property absent from the final > bindings. Remove it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 --- > 1 file changed, 3 deletions(-) > Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, Mar 06, 2025 at 07:11:21PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > The preemptively-merged node contains a property absent from the final > bindings. Remove it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 -- > 1 file changed, 2 deletions(-) > Fixes: bd2dbbb1f35a ("arm64: dts: qcom: x1e80100-dell-xps13-9345: Introduce retimer support") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. Ok, I should have read dt-bindigns before sending a comment. But this commit doesn't explain, why do you need an extra compat string. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 > --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > @@ -18,7 +18,9 @@ description: > > properties: > compatible: > - const: qcom,kpss-acc-v2 > + enum: > + - qcom,msm8916-kpss-acc > + - qcom,kpss-acc-v2 > > reg: > items: > > -- > 2.48.1 >
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 > --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml > @@ -18,7 +18,9 @@ description: > > properties: > compatible: > - const: qcom,kpss-acc-v2 > + enum: > + - qcom,msm8916-kpss-acc Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). I think this should be either qcom,msm8916-apss-acc, or you just keep the qcom,msm8916-acc we already use. I'm guessing ACC stands for "Application Clock Controller", so it would be unique enough already. There is actually a patch from Rayyan already with a R-b from Krzysztof. Maybe you, or whoever is responsible, can pick it up? https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ Thanks, Stephan
On Thu, 06 Mar 2025 19:11:13 +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > Some MMU instances feature a Translation Buffer Unit (TBU), which comes > with its own clock. Allow describing it. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 7.03.2025 12:07 PM, Stephan Gerhold wrote: > On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> >> MSM8916 seems to reuse the same hardware as MSM8974 and friends (for >> whom this binding document was created). Add a new compatible for it. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> --- >> Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> @@ -18,7 +18,9 @@ description: >> >> properties: >> compatible: >> - const: qcom,kpss-acc-v2 >> + enum: >> + - qcom,msm8916-kpss-acc > > Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an > *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). You would think that, but actually it's still called KPSS internally.. > > I think this should be either qcom,msm8916-apss-acc, or you just keep > the qcom,msm8916-acc we already use. I'm guessing ACC stands for > "Application Clock Controller", so it would be unique enough already. > > There is actually a patch from Rayyan already with a R-b from Krzysztof. > Maybe you, or whoever is responsible, can pick it up? > > https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ I'm not opposed to this either Looks like Sebastian Reichel and/or Ulf pick up power dt-bindings patches Konrad
A set of not quite related bindings warnings fixes. Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> --- Konrad Dybcio (11): dt-bindings: iommu: qcom,iommu: Add optional TBU clock dt-bindings: display: msm: sm8350-mdss: Describe the CPU-CFG icc path dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible arm64: dts: qcom: msm8916: Fix KPSS ACC compatible arm64: dts: qcom: sdx75: Fix up the USB interrupt description arm64: dts: qcom: sdx75: Rename AOSS_QMP to power-management arm64: dts: qcom: qcs615: Rename AOSS_QMP to power-management arm64: dts: qcom: sc8180x: Rename AOSS_QMP to power-management arm64: dts: qcom: x1e80100-dell-xps13-9345: Drop clock-names from PS8830 arm64: dts: qcom: x1e80100-romulus: Drop clock-names from PS8830 arm64: dts: qcom: x1e001de-devkit: Drop clock-names from PS8830 .../bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++++- Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 4 ++++ .../devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- arch/arm64/boot/dts/qcom/msm8916.dtsi | 8 ++++---- arch/arm64/boot/dts/qcom/qcs615.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdx75.dtsi | 16 +++++++++------- arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 --- arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 -- arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 2 -- 10 files changed, 27 insertions(+), 22 deletions(-) --- base-commit: 565351ae7e0cee80e9b5ed84452a5b13644ffc4d change-id: 20250306-topic-dt_bindings_fixups-602d47c3c365 Best regards,