| Message ID | 20250304-sm8750_usb_master-v2-5-a698a2e68e06@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom: Introduce USB support for SM8750 | expand |
On 4.03.2025 10:56 PM, Melody Olvera wrote: > From: Wesley Cheng <quic_wcheng@quicinc.com> > > The eUSB2 repeater that exists in the QCOM PMICs are utilized for several > different eUSB2 PHY vendors, such as M31 or Synopsys. Hence, the wording > needs to be updated to remove associations to a specific vendor. > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > drivers/phy/qualcomm/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig > index 846f8c99547fd5132feaa1e41093b8eab51714f9..f281e3b7f3f20b4a4bb1602be94b8a1b041a876f 100644 > --- a/drivers/phy/qualcomm/Kconfig > +++ b/drivers/phy/qualcomm/Kconfig > @@ -135,12 +135,12 @@ config PHY_QCOM_SNPS_EUSB2 > on Qualcomm SOCs. > > config PHY_QCOM_EUSB2_REPEATER > - tristate "Qualcomm SNPS eUSB2 Repeater Driver" > + tristate "Qualcomm PMIC eUSB2 Repeater Driver" > depends on OF && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > - Enable support for the USB high-speed SNPS eUSB2 repeater on Qualcomm > - PMICs. The repeater is paired with a Synopsys eUSB2 Phy > + Enable support for the USB high-speed eUSB2 repeater on Qualcomm > + PMICs. The repeater can be paired with a Synopsys or M31 eUSB2 Phy > on Qualcomm SOCs. I guess the repeater doesn't really check the vendor of the PHY, i.e. if someone took a SMB2360 and hooked it up to any other eUSB signal, it would happily crunch through them.. That said, I'm just spitting out words and this is probably good to inform the user about the actual real-world usage Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig index 846f8c99547fd5132feaa1e41093b8eab51714f9..f281e3b7f3f20b4a4bb1602be94b8a1b041a876f 100644 --- a/drivers/phy/qualcomm/Kconfig +++ b/drivers/phy/qualcomm/Kconfig @@ -135,12 +135,12 @@ config PHY_QCOM_SNPS_EUSB2 on Qualcomm SOCs. config PHY_QCOM_EUSB2_REPEATER - tristate "Qualcomm SNPS eUSB2 Repeater Driver" + tristate "Qualcomm PMIC eUSB2 Repeater Driver" depends on OF && (ARCH_QCOM || COMPILE_TEST) select GENERIC_PHY help - Enable support for the USB high-speed SNPS eUSB2 repeater on Qualcomm - PMICs. The repeater is paired with a Synopsys eUSB2 Phy + Enable support for the USB high-speed eUSB2 repeater on Qualcomm + PMICs. The repeater can be paired with a Synopsys or M31 eUSB2 Phy on Qualcomm SOCs. config PHY_QCOM_M31_USB