| Message ID | 20250305220146.3932955-1-superm1@kernel.org |
|---|---|
| Headers | show |
| Series | Add LPS0 check() for pinctrl-amd | expand |
On Wed, Mar 5, 2025 at 11:01 PM Mario Limonciello <superm1@kernel.org> wrote: > > From: Mario Limonciello <mario.limonciello@amd.com> > > During suspend the pinctrl_amd driver disables the interrupts for > any GPIOs that are not marked as wake sources. > > This however does not prevent them from changing the wake status > bit during suspend, it just stops the system from waking. > > If the system wakes from hardware sleep for another reason (such > as plugging in the AC adapter) this wake bits might be active. > > This could potentially cause problems with going back to hardware > sleep. Add an extra debugging message when PM debugging is enabled > to help identify if this is happening. > > --- > I'm resending this because kw seemed to have split the patches on > separate mailing lists and the lkp robot didn't know and reported > failures. > No changes from v3 -> v3 RESEND > > Mario Limonciello (2): > ACPI: Add missing prototype for non CONFIG_SUSPEND/CONFIG_X86 case > pinctrl: amd: Add an LPS0 check() callback > > drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++++++++++++++++ > include/linux/acpi.h | 9 ++++++++- > 2 files changed, 36 insertions(+), 1 deletion(-) > > -- I've dropped this because of a build issue in linux-next introduced by it: https://lore.kernel.org/lkml/20250312235829.2ac0c991@canb.auug.org.au/
From: Mario Limonciello <mario.limonciello@amd.com> During suspend the pinctrl_amd driver disables the interrupts for any GPIOs that are not marked as wake sources. This however does not prevent them from changing the wake status bit during suspend, it just stops the system from waking. If the system wakes from hardware sleep for another reason (such as plugging in the AC adapter) this wake bits might be active. This could potentially cause problems with going back to hardware sleep. Add an extra debugging message when PM debugging is enabled to help identify if this is happening. --- I'm resending this because kw seemed to have split the patches on separate mailing lists and the lkp robot didn't know and reported failures. No changes from v3 -> v3 RESEND Mario Limonciello (2): ACPI: Add missing prototype for non CONFIG_SUSPEND/CONFIG_X86 case pinctrl: amd: Add an LPS0 check() callback drivers/pinctrl/pinctrl-amd.c | 28 ++++++++++++++++++++++++++++ include/linux/acpi.h | 9 ++++++++- 2 files changed, 36 insertions(+), 1 deletion(-)