diff mbox series

[v3,2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO

Message ID 20250307052231.551737-3-raag.jadav@intel.com
State New
Headers show
Series Introduce Intel Elkhart Lake PSE TIO | expand

Commit Message

Raag Jadav March 7, 2025, 5:22 a.m. UTC
Now that we have Intel MFD driver for PSE GPIO, depend on it.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko March 12, 2025, 11 a.m. UTC | #1
On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > Now that we have Intel MFD driver for PSE GPIO, depend on it.

> Andy, any guidance on GPIO?

I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
part already?
Raag Jadav March 12, 2025, 5:03 p.m. UTC | #2
On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> 
> > Andy, any guidance on GPIO?
> 
> I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> part already?

Ah, I added MFD dependency for leaf drivers after your v1 review.
So this one seems missing the tag. Can I add it?

Raag
Andy Shevchenko March 12, 2025, 6:32 p.m. UTC | #3
On Wed, Mar 12, 2025 at 07:03:01PM +0200, Raag Jadav wrote:
> On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> > 
> > > Andy, any guidance on GPIO?
> > 
> > I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> > part already?
> 
> Ah, I added MFD dependency for leaf drivers after your v1 review.
> So this one seems missing the tag. Can I add it?

I see, but this can be added later on.
And on the second thought, do we accept the configurations
when user wants to have GPIO on EHL, and doesn't care about TIO?
Maybe this patch is not needed after all?
Raag Jadav March 13, 2025, 9:19 a.m. UTC | #4
On Wed, Mar 12, 2025 at 08:32:51PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 12, 2025 at 07:03:01PM +0200, Raag Jadav wrote:
> > On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> > > On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > > > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> > > 
> > > > Andy, any guidance on GPIO?
> > > 
> > > I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> > > part already?
> > 
> > Ah, I added MFD dependency for leaf drivers after your v1 review.
> > So this one seems missing the tag. Can I add it?
> 
> I see, but this can be added later on.
> And on the second thought, do we accept the configurations
> when user wants to have GPIO on EHL, and doesn't care about TIO?

Yes, here we're making the leaf driver (GPIO) depend on MFD regardless
of what TIO config is.

> Maybe this patch is not needed after all?

My understanding is that GPIO should depend on MFD. Not much point in
adding a standalone leaf driver right?

Raag
Andy Shevchenko March 13, 2025, 2 p.m. UTC | #5
On Thu, Mar 13, 2025 at 11:19:28AM +0200, Raag Jadav wrote:
> On Wed, Mar 12, 2025 at 08:32:51PM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 12, 2025 at 07:03:01PM +0200, Raag Jadav wrote:
> > > On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> > > > On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > > > > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > > > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> > > > 
> > > > > Andy, any guidance on GPIO?
> > > > 
> > > > I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> > > > part already?
> > > 
> > > Ah, I added MFD dependency for leaf drivers after your v1 review.
> > > So this one seems missing the tag. Can I add it?
> > 
> > I see, but this can be added later on.
> > And on the second thought, do we accept the configurations
> > when user wants to have GPIO on EHL, and doesn't care about TIO?
> 
> Yes, here we're making the leaf driver (GPIO) depend on MFD regardless
> of what TIO config is.
> 
> > Maybe this patch is not needed after all?
> 
> My understanding is that GPIO should depend on MFD. Not much point in
> adding a standalone leaf driver right?

Ah, indeed, we have no other means to enumerate it (as we don't have any board
file that does direct creation of the device), this patch is correct.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Raag Jadav March 13, 2025, 2:24 p.m. UTC | #6
On Thu, Mar 13, 2025 at 04:00:01PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 13, 2025 at 11:19:28AM +0200, Raag Jadav wrote:
> > On Wed, Mar 12, 2025 at 08:32:51PM +0200, Andy Shevchenko wrote:
> > > On Wed, Mar 12, 2025 at 07:03:01PM +0200, Raag Jadav wrote:
> > > > On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> > > > > On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > > > > > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > > > > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> > > > > 
> > > > > > Andy, any guidance on GPIO?
> > > > > 
> > > > > I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> > > > > part already?
> > > > 
> > > > Ah, I added MFD dependency for leaf drivers after your v1 review.
> > > > So this one seems missing the tag. Can I add it?
> > > 
> > > I see, but this can be added later on.
> > > And on the second thought, do we accept the configurations
> > > when user wants to have GPIO on EHL, and doesn't care about TIO?
> > 
> > Yes, here we're making the leaf driver (GPIO) depend on MFD regardless
> > of what TIO config is.
> > 
> > > Maybe this patch is not needed after all?
> > 
> > My understanding is that GPIO should depend on MFD. Not much point in
> > adding a standalone leaf driver right?
> 
> Ah, indeed, we have no other means to enumerate it (as we don't have any board
> file that does direct creation of the device), this patch is correct.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Awesome.

I'm guessing this series will only apply on Greg's tree due to TIO stuff.
If I'd rather need to route it any other way, please let me know.

Raag
diff mbox series

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 98b4d1633b25..232ef211ef38 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1372,7 +1372,7 @@  config HTC_EGPIO
 
 config GPIO_ELKHARTLAKE
 	tristate "Intel Elkhart Lake PSE GPIO support"
-	depends on X86 || COMPILE_TEST
+	depends on (X86 || COMPILE_TEST) && MFD_INTEL_EHL_PSE_GPIO
 	select GPIO_TANGIER
 	help
 	  Select this option to enable GPIO support for Intel Elkhart Lake