| Message ID | 20250327004945.563765-1-peng.fan@oss.nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V2,1/2] gpiolib: of: Add polarity quirk for s5m8767 | expand |
> Subject: Re: [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767 > > On Thu, Mar 27, 2025 at 08:49:44AM +0800, Peng Fan (OSS) wrote: > > > > This is prepare patch for switching s5m8767 regulator driver to use > > GPIO descriptor. DTS for exynos5250 spring incorrectly specifies > > "active low" polarity for the DVS and DS line. But per datasheet, they > > are actually active high. So add polarity quirk for it. > > So, to make this clear: this is simply DTS mistake as driver basically > ignores the polarity or other flags in it, correct? Correct. Regards, Peng. > > -- > With Best Regards, > Andy Shevchenko >
On Thu, Mar 27, 2025 at 08:49:45AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors. > Then drop the usage of 'of_gpio.h' which should be deprecated. > Based on commit 84618d5e31cf ("regulator: max8997: > Convert to GPIO descriptors") as a reference to make the changes. Acked-by: Mark Brown <broonie@kernel.org>
On 27/03/2025 01:49, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors. > Then drop the usage of 'of_gpio.h' which should be deprecated. > Based on commit 84618d5e31cf ("regulator: max8997: > Convert to GPIO descriptors") as a reference to make the changes. > > With the quirk fix for s5m8767 in of_gpio_try_fixup_polarity, > the polarity will be active-high, even if exynos5250 spring DTS > wrongly use active-low polarity. So using GPIO descriptors, > it should work as before. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Thu, Mar 27, 2025 at 1:51 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors. > Then drop the usage of 'of_gpio.h' which should be deprecated. > Based on commit 84618d5e31cf ("regulator: max8997: > Convert to GPIO descriptors") as a reference to make the changes. > > With the quirk fix for s5m8767 in of_gpio_try_fixup_polarity, > the polarity will be active-high, even if exynos5250 spring DTS > wrongly use active-low polarity. So using GPIO descriptors, > it should work as before. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, Mar 27, 2025 at 1:50 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > From: Peng Fan <peng.fan@nxp.com> > > This is prepare patch for switching s5m8767 regulator driver to > use GPIO descriptor. DTS for exynos5250 spring incorrectly specifies > "active low" polarity for the DVS and DS line. But per datasheet, > they are actually active high. So add polarity quirk for it. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Thu, 27 Mar 2025 08:49:44 +0800, Peng Fan (OSS) wrote: > This is prepare patch for switching s5m8767 regulator driver to > use GPIO descriptor. DTS for exynos5250 spring incorrectly specifies > "active low" polarity for the DVS and DS line. But per datasheet, > they are actually active high. So add polarity quirk for it. > > Applied, thanks! [1/2] gpiolib: of: Add polarity quirk for s5m8767 commit: 4e310626eb4df52a31a142c1360fead0fcbd3793 Best regards,
On Thu, 27 Mar 2025 08:49:44 +0800, Peng Fan (OSS) wrote: > This is prepare patch for switching s5m8767 regulator driver to > use GPIO descriptor. DTS for exynos5250 spring incorrectly specifies > "active low" polarity for the DVS and DS line. But per datasheet, > they are actually active high. So add polarity quirk for it. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/2] gpiolib: of: Add polarity quirk for s5m8767 (no commit info) [2/2] regulator: s5m8767: Convert to GPIO descriptors commit: 16b19bfd80402bb98135c4b65344e859883766ec All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index eb667f8f1ead..83559dd24f32 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -222,6 +222,15 @@ static void of_gpio_try_fixup_polarity(const struct device_node *np, */ { "lantiq,pci-xway", "gpio-reset", false }, #endif +#if IS_ENABLED(CONFIG_REGULATOR_S5M8767) + /* + * According to S5M8767, the DVS and DS pin are + * active-high signals. However, exynos5250-spring.dts use + * active-low setting. + */ + { "samsung,s5m8767-pmic", "s5m8767,pmic-buck-dvs-gpios", true }, + { "samsung,s5m8767-pmic", "s5m8767,pmic-buck-ds-gpios", true }, +#endif #if IS_ENABLED(CONFIG_TOUCHSCREEN_TSC2005) /* * DTS for Nokia N900 incorrectly specified "active high"