diff mbox series

[v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller

Message ID 20250328122917.43273-1-francesco@dolcini.it
State Superseded
Headers show
Series [v1] dt-bindings: gpio: pca95xx: add Toradex Embedded Controller | expand

Commit Message

Francesco Dolcini March 28, 2025, 12:29 p.m. UTC 
From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

The Toradex Embedded Controller IO16 is a 16-bit I2C I/O expander
implemented using a small MCU.
Its register interface and behavior are compatible with the PCAL6416.

Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Francesco Dolcini March 31, 2025, 7:03 a.m. UTC | #1 
Hello,

On Fri, Mar 28, 2025 at 01:29:17PM +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> The Toradex Embedded Controller IO16 is a 16-bit I2C I/O expander
> implemented using a small MCU.
> Its register interface and behavior are compatible with the PCAL6416.
> 
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Please ignore this patch, I'll send soon a v2.

The issue with this patch is that the compatible is too long, we are
going to re-use "embedded-controller" prefix for other devices and this
creates clashes with the i2c compatible match fallback function
(i2c_of_match_device_sysfs).

Francesco
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 7b1eb08fa055..db1520ff38bd 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -16,6 +16,9 @@  description: |+
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: toradex,embedded-controller-io16
+          - const: nxp,pcal6416
       - items:
           - const: diodes,pi4ioe5v6534q
           - const: nxp,pcal6534
@@ -132,6 +135,7 @@  allOf:
               - maxim,max7325
               - maxim,max7326
               - maxim,max7327
+              - toradex,embedded-controller-io16
     then:
       properties:
         reset-gpios: false