| Message ID | 20250404-ml-topic-tcpci-v1-1-4442c7d0ee1e@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: tcpci: add regulator support | expand |
+Badhri On Fri, Apr 04, 2025 at 01:17:20AM +0200, Michael Grzeschik wrote: > The tcpci chip vbus pin is possibly driven by an regulator. This patch > is adding support to enable an optional vdd regulator before probing. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c > index 19ab6647af706..a56e31b20c214 100644 > --- a/drivers/usb/typec/tcpm/tcpci.c > +++ b/drivers/usb/typec/tcpm/tcpci.c > @@ -17,6 +17,7 @@ > #include <linux/usb/tcpci.h> > #include <linux/usb/tcpm.h> > #include <linux/usb/typec.h> > +#include <linux/regulator/consumer.h> > > #define PD_RETRY_COUNT_DEFAULT 3 > #define PD_RETRY_COUNT_3_0_OR_HIGHER 2 > @@ -905,6 +906,10 @@ static int tcpci_probe(struct i2c_client *client) > int err; > u16 val = 0; > > + err = devm_regulator_get_enable_optional(&client->dev, "vdd"); > + if (err && err != -ENODEV) > + return dev_err_probe(&client->dev, err, "Failed to get regulator\n"); > + > chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); > if (!chip) > return -ENOMEM; > > --- > base-commit: a1b5bd45d4ee58af4f56e49497b8c3db96d8f8a3 > change-id: 20250404-ml-topic-tcpci-524d1d6bfede > > Best regards, > -- > Michael Grzeschik <m.grzeschik@pengutronix.de>
diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c index 19ab6647af706..a56e31b20c214 100644 --- a/drivers/usb/typec/tcpm/tcpci.c +++ b/drivers/usb/typec/tcpm/tcpci.c @@ -17,6 +17,7 @@ #include <linux/usb/tcpci.h> #include <linux/usb/tcpm.h> #include <linux/usb/typec.h> +#include <linux/regulator/consumer.h> #define PD_RETRY_COUNT_DEFAULT 3 #define PD_RETRY_COUNT_3_0_OR_HIGHER 2 @@ -905,6 +906,10 @@ static int tcpci_probe(struct i2c_client *client) int err; u16 val = 0; + err = devm_regulator_get_enable_optional(&client->dev, "vdd"); + if (err && err != -ENODEV) + return dev_err_probe(&client->dev, err, "Failed to get regulator\n"); + chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL); if (!chip) return -ENOMEM;
The tcpci chip vbus pin is possibly driven by an regulator. This patch is adding support to enable an optional vdd regulator before probing. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/usb/typec/tcpm/tcpci.c | 5 +++++ 1 file changed, 5 insertions(+) --- base-commit: a1b5bd45d4ee58af4f56e49497b8c3db96d8f8a3 change-id: 20250404-ml-topic-tcpci-524d1d6bfede Best regards,