| Message ID | 20250407-revert_hs_phy_settings-v1-1-ec94e316ea19@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom-qusb2: Update the phy settings for IPQ5424 | expand |
On 07-04-25, 19:51, Kathiravan Thirumoorthy wrote: > Update the phy settings for IPQ5424 to meet compliance requirements. Can you specify which requirements are these? > The current settings do not meet the requirements, and the design team > has requested to use the settings used for IPQ6018. > > Revert the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for > IPQ5424") and reuse the IPQ6018 settings. Why not do revert first and then add the settings?
On 4/11/2025 12:34 PM, Vinod Koul wrote: > On 07-04-25, 19:51, Kathiravan Thirumoorthy wrote: >> Update the phy settings for IPQ5424 to meet compliance requirements. > Can you specify which requirements are these? The eye diagram (Host High-speed Signal Quality) tests are failed with the current settings. So design team asked to revert. > >> The current settings do not meet the requirements, and the design team >> has requested to use the settings used for IPQ6018. >> >> Revert the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for >> IPQ5424") and reuse the IPQ6018 settings. > Why not do revert first and then add the settings? I thought of submitting it separately. But what-if only the first patch merged and second one didn't due to some issue, it will break the USB feature. So, I thought it would be better to keep it in single commit. Please let me know, I can send V2 with 2 patches with the merging strategy (both patches should go together to avoid the USB breakage) in cover letter. >
On 11-04-25, 14:29, Kathiravan Thirumoorthy wrote: > > On 4/11/2025 12:34 PM, Vinod Koul wrote: > > On 07-04-25, 19:51, Kathiravan Thirumoorthy wrote: > > > Update the phy settings for IPQ5424 to meet compliance requirements. > > Can you specify which requirements are these? > > The eye diagram (Host High-speed Signal Quality) tests are failed with the > current settings. So design team asked to revert. That would be good to mention in changelog.. am sure you wont recall 6 months down the line, which requirement this triggered the change! > > > The current settings do not meet the requirements, and the design team > > > has requested to use the settings used for IPQ6018. > > > > > > Revert the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for > > > IPQ5424") and reuse the IPQ6018 settings. > > Why not do revert first and then add the settings? > > > I thought of submitting it separately. But what-if only the first patch > merged and second one didn't due to some issue, it will break the USB > feature. So, I thought it would be better to keep it in single commit. > Please let me know, I can send V2 with 2 patches with the merging strategy > (both patches should go together to avoid the USB breakage) in cover letter. Series is applied together and you can mention the dependency on cover letter
On 4/11/2025 5:05 PM, Vinod Koul wrote: > On 11-04-25, 14:29, Kathiravan Thirumoorthy wrote: >> On 4/11/2025 12:34 PM, Vinod Koul wrote: >>> On 07-04-25, 19:51, Kathiravan Thirumoorthy wrote: >>>> Update the phy settings for IPQ5424 to meet compliance requirements. >>> Can you specify which requirements are these? >> The eye diagram (Host High-speed Signal Quality) tests are failed with the >> current settings. So design team asked to revert. > That would be good to mention in changelog.. am sure you wont recall 6 > months down the line, which requirement this triggered the change! Sure, let me mention in the commit message. And yes, as of now, all the compliance requirements are met. > >>>> The current settings do not meet the requirements, and the design team >>>> has requested to use the settings used for IPQ6018. >>>> >>>> Revert the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for >>>> IPQ5424") and reuse the IPQ6018 settings. >>> Why not do revert first and then add the settings? >> >> I thought of submitting it separately. But what-if only the first patch >> merged and second one didn't due to some issue, it will break the USB >> feature. So, I thought it would be better to keep it in single commit. >> Please let me know, I can send V2 with 2 patches with the merging strategy >> (both patches should go together to avoid the USB breakage) in cover letter. > Series is applied together and you can mention the dependency on cover > letter Sure, will send V2 accordingly.
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 1f5f7df14d5a2ff041fe15aaeb6ec5ce52ab2a81..49c37c53b38e70db2a1591081a1a12db7092555d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = { QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F), }; -static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = { - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14), - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00), - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53), - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21), - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00), - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80), - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f), -}; - static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = { QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8), QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3), @@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = { .autoresume_en = BIT(0), }; -static const struct qusb2_phy_cfg ipq5424_phy_cfg = { - .tbl = ipq5424_init_tbl, - .tbl_num = ARRAY_SIZE(ipq5424_init_tbl), - .regs = ipq6018_regs_layout, - - .disable_ctrl = POWER_DOWN, - .mask_core_ready = PLL_LOCKED, - .autoresume_en = BIT(0), -}; - static const struct qusb2_phy_cfg qcs615_phy_cfg = { .tbl = qcs615_init_tbl, .tbl_num = ARRAY_SIZE(qcs615_init_tbl), @@ -955,7 +930,7 @@ static const struct phy_ops qusb2_phy_gen_ops = { static const struct of_device_id qusb2_phy_of_match_table[] = { { .compatible = "qcom,ipq5424-qusb2-phy", - .data = &ipq5424_phy_cfg, + .data = &ipq6018_phy_cfg, }, { .compatible = "qcom,ipq6018-qusb2-phy", .data = &ipq6018_phy_cfg,
Update the phy settings for IPQ5424 to meet compliance requirements. The current settings do not meet the requirements, and the design team has requested to use the settings used for IPQ6018. Revert the commit 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424") and reuse the IPQ6018 settings. Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424") Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com> --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) --- base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c change-id: 20250407-revert_hs_phy_settings-f6b9ec6b2297 Best regards,