| Message ID | Z_442PWaMVoZcbbU@stanley.mountain |
|---|---|
| State | New |
| Headers | show |
| Series | [next] ASoC: qcom: qdsp6: Set error code in q6usb_hw_params() | expand |
On Tue, Apr 15, 2025 at 01:45:44PM +0300, Dan Carpenter wrote: > Propagate the error code if q6afe_port_get_from_id() fails. Don't > return success. > > Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > sound/soc/qcom/qdsp6/q6usb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
On Tue, Apr 15, 2025 at 01:45:44PM +0300, Dan Carpenter wrote: > Propagate the error code if q6afe_port_get_from_id() fails. Don't > return success. Acked-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/qcom/qdsp6/q6usb.c b/sound/soc/qcom/qdsp6/q6usb.c index 274c251e84dd..adba0446f301 100644 --- a/sound/soc/qcom/qdsp6/q6usb.c +++ b/sound/soc/qcom/qdsp6/q6usb.c @@ -74,8 +74,10 @@ static int q6usb_hw_params(struct snd_pcm_substream *substream, goto out; q6usb_afe = q6afe_port_get_from_id(cpu_dai->dev, USB_RX); - if (IS_ERR(q6usb_afe)) + if (IS_ERR(q6usb_afe)) { + ret = PTR_ERR(q6usb_afe); goto out; + } /* Notify audio DSP about the devices being offloaded */ ret = afe_port_send_usb_dev_param(q6usb_afe, sdev->card_idx,
Propagate the error code if q6afe_port_get_from_id() fails. Don't return success. Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- sound/soc/qcom/qdsp6/q6usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)